New issue
Advanced search Search tips

Issue 755315 link

Starred by 1 user
Status: Fixed
Owner:
chfremer@chromium.org
Closed: Sep 2017
Cc:
guidou@chromium.org
niklase@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

[Video Capture Service] Service is launched when doing non-device capture

Project Member Reported by chfremer@chromium.org, Aug 14 2017 
The Video Capture Service is supposed to be launched on-demand when video capture from a device is requested. However, currently, it is also launched when capture from desktop or tab is requested. In such cases the service is kept alive until the desktop/tab capture session has finished.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee5b64225752798c28457523786bb910eb4c892a

commit ee5b64225752798c28457523786bb910eb4c892a
Author: Christian Fremerey <chfremer@chromium.org>
Date: Tue Aug 29 14:57:22 2017

[Video Capture Service] Do no launch service when doing non-device capture

This CL makes launching the service more lazy, so that it does not get
launched before actual capture from a device is requested.

Bug:  755315 
Change-Id: I9eab267b6728b9ef2065ee56eff40bc8a37ee1a5
Reviewed-on: https://chromium-review.googlesource.com/619926
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Commit-Queue: Christian Fremerey <chfremer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498108}
[modify] https://crrev.com/ee5b64225752798c28457523786bb910eb4c892a/content/browser/BUILD.gn
[modify] https://crrev.com/ee5b64225752798c28457523786bb910eb4c892a/content/browser/renderer_host/media/service_video_capture_device_launcher.cc
[modify] https://crrev.com/ee5b64225752798c28457523786bb910eb4c892a/content/browser/renderer_host/media/service_video_capture_device_launcher.h
[modify] https://crrev.com/ee5b64225752798c28457523786bb910eb4c892a/content/browser/renderer_host/media/service_video_capture_device_launcher_unittest.cc
[modify] https://crrev.com/ee5b64225752798c28457523786bb910eb4c892a/content/browser/renderer_host/media/service_video_capture_provider.cc
[modify] https://crrev.com/ee5b64225752798c28457523786bb910eb4c892a/content/browser/renderer_host/media/service_video_capture_provider.h
[modify] https://crrev.com/ee5b64225752798c28457523786bb910eb4c892a/content/browser/renderer_host/media/service_video_capture_provider_unittest.cc
[add] https://crrev.com/ee5b64225752798c28457523786bb910eb4c892a/content/browser/renderer_host/media/video_capture_factory_delegate.cc
[add] https://crrev.com/ee5b64225752798c28457523786bb910eb4c892a/content/browser/renderer_host/media/video_capture_factory_delegate.h

Comment 2 by chfremer@chromium.org, Sep 15 2017

Status: Fixed (was: Started)
►

Sign in to add a comment