New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 755293 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Apr 2018
Cc:
█ meade@chromium.org
e...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

css1/basic/comments.html and 867 other tests fail with latest freetype

Project Member Reported by brucedaw...@chromium.org, Aug 14 2017 
The following layout tests are failing on linux_chromium_rel_ng:

Unexpected Failures:
* css1/basic/comments.html
* css1/basic/containment.html
* css1/basic/contextual_selectors.html
* css1/basic/grouping.html
* css1/basic/id_as_selector.html
* css1/basic/inheritance.html
* css1/box_properties/border.html
* css1/box_properties/border_bottom.html
* css1/box_properties/border_bottom_inline.html
* css1/box_properties/border_bottom_width.html
* css1/box_properties/border_bottom_width_inline.html
* css1/box_properties/border_color.html
* css1/box_properties/border_color_inline.html
* css1/box_properties/border_inline.html
* css1/box_properties/border_left.html
* css1/box_properties/border_left_inline.html
* css1/box_properties/border_left_width.html
* css1/box_properties/border_left_width_inline.html
* css1/box_properties/border_right.html
* css1/box_properties/border_right_inline.html
* css1/box_properties/border_right_width.html
* css1/box_properties/border_right_width_inline.html
* css1/box_properties/border_style.html
* css1/box_properties/border_style_inline.html
* css1/box_properties/border_top.html
* css1/box_properties/border_top_inline.html
* css1/box_properties/border_top_width.html
* css1/box_properties/border_top_width_inline.html
* css1/box_properties/border_width.html
* css1/box_properties/border_width_inline.html
* ... 838 more ...

Caused by https://chromium-review.googlesource.com/c/611704. This change is a roll of freetype. The problem was discovered when doing a roll to the latest change but bisecting showed that these two changes are the culprits.

It is not clear whether this is a bug, an improvement, or "just different" results. And, it's not clear why the failure is isolated to one configuration on one platform. The failures reproduce easily on Linux. Examination of the differences shows that the mean difference is a small shifting left off '{' and '} characters.

Comment 1 by brucedaw...@chromium.org, Aug 14 2017 

I've attached typical output for the failures, for css1/box_properties/border.html.
border-expected.png
73.6 KB View Download
border-actual.png
73.8 KB View Download

Comment 2 by brucedaw...@chromium.org, Aug 14 2017

Labels: -OS-All

Comment 3 by rjwright@chromium.org, Aug 16 2017

Cc: meade@chromium.org
Status: WontFix (was: Untriaged)
This was filed almost two days ago and the builder seems to be working so I am marking this as wontfix.

Comment 4 by brucedaw...@chromium.org, Aug 16 2017

Status: Untriaged (was: WontFix)
Reopening...

The problem is that the layout tests reliably fail on the CQ when trying to land https://chromium-review.googlesource.com/c/611704, a FreeType DEPS roll. This is preventing this CL from being landed. That's why the builder seems to be working.

It's not clear to me whether we need to land the FreeType DEPS roll together with some expectations changes, or if there are changes to FreeType to be made. That is, how do we determine whether the new FreeType behavior is a bug or not?

Comment 5 by ericwilligers@chromium.org, Aug 18 2017

Components: -Blink>CSS Blink>Fonts
The CSS tests can all be rebased. If they were written today, we would use the Ahem font as that tends to be consistent across platforms. For some tests, we would assert computed style values instead of having expectation images.

Comment 6 by ericwilligers@chromium.org, Aug 23 2017

Cc: e...@chromium.org
I have attached the list of tests that have minor image diffs.

Comment 7 by ericwilligers@chromium.org, Aug 23 2017

freetype-roll-changes.txt
39.9 KB View Download

Comment 8 by e...@chromium.org, Aug 29 2017

Status: Available (was: Untriaged)

Comment 9 by bunge...@chromium.org, Apr 24 2018

Status: Fixed (was: Available)
It appears that the FreeType roll in question was landed with rebaselines with https://chromium-review.googlesource.com/c/chromium/src/+/628521 . As such it appears this is now fixed.
►

Sign in to add a comment