New issue
Advanced search Search tips

Issue 755280 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug
Team-Accessibility

Blocking:
issue 762575



Sign in to add a comment

[A11y Assessment - File Manager] Search field issues

Project Member Reported by lpalmaro@chromium.org, Aug 14 2017

Issue description

OS: Chrome
Version: 61.0.3163.38

1. Enable ChromeVox with Ctrl Alt Z
2. Press Alt Shift M to open the files manager
3. Press Search + Right to navigate through item by item on the screen using ChromeVox 

Two issues when you get to the search field in the files manager.

1. If I press Search + Right to get to the search button, I literally have to press it 4 times and I hear:
"Search" then press Search + right again to move forward and then hear 
"Search". press Search + right again, then hear
"search", then press Search + right again and hear "Search" again. It takes 4 keystrokes to get through this. This is partially happening because the first time you get to the icon and hear "search", it's because you then need to move forward again in oder to expand it. No matter what, we need to reduce the redundancy here. It should only take one instance of pressing Search + Right to get to the search field, and then you should hear that it's an editable field. From there, you should be able to press Enter to activate the search, or press Search + Right and move to the next item. 

The second issue is that when you type text into the search field, you can't use the keyboard to get to the X clear input button. This button is invisible to screen reader or keyboard only users, and needs to be accessible. 

 
Cc: yamaguchi@chromium.org fukino@chromium.org
Components: Platform>Apps>FileManager
Blockedon: 762575
Blockedon: -762575
Blocking: 762575
Note: We might want to address  crbug.com/762714  while we are cleaning this up.
I confirmed this happens, but only 2 times when using Search+Right key.

1. "Search button" at the "button to expand the search text input box"
2. "Search Edit text, search entry"
After #2, it goes to "Switch to thumbnail view Button.

Thanks! Friendly ping as we'd like to include this as part of our PE sweep. 

Comment 8 by sashab@chromium.org, Feb 22 2018

Labels: CrOS-FilesApp-Accessibility

Comment 9 by sashab@chromium.org, Feb 28 2018

Labels: -CrOS-FilesApp-Accessibility CrOSFilesCategory-Accessibility
I'm triaging a11y bugs. 

I have reproduced this bug. I'm not fixing this yet, I'll came back to it later.

I can confirm the same behavior as yamaguchi@ reported on comment #6.
Cc: weifangsun@chromium.org lucmult@chromium.org
Owner: ----
Status: Available (was: Assigned)
Cc: -lucmult@chromium.org
Labels: M-68
Owner: lucmult@chromium.org
Status: Assigned (was: Available)
Status: Started (was: Assigned)
Project Member

Comment 14 by bugdroid1@chromium.org, Apr 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/10d21d2ed0b2e751e4f5a21549da0eb24f253f7d

commit 10d21d2ed0b2e751e4f5a21549da0eb24f253f7d
Author: Luciano Pacheco <lucmult@chromium.org>
Date: Thu Apr 19 01:20:40 2018

Fix chromevox focus on search field when hidden

Add HTML5 hidden attribute to search input field to avoid Chromevox (
screen reader) to put the focus on the input field that isn't displayed.

Initialize the input with hidden attribute and set it to false when the
search button is clicked or Ctrl+F is pressed. Add the hidden attribute
back when input field loses the focus and has no content.

TEST=Manually on the device with Chromevox.

Bug:  755280 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I9f237294192baaf23bdb8eb7ee3784c7c9da5533
Reviewed-on: https://chromium-review.googlesource.com/1013758
Reviewed-by: Sasha Morrissey <sashab@chromium.org>
Commit-Queue: Luciano Pacheco (SYD) <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551908}
[modify] https://crrev.com/10d21d2ed0b2e751e4f5a21549da0eb24f253f7d/ui/file_manager/file_manager/foreground/js/file_manager_commands.js
[modify] https://crrev.com/10d21d2ed0b2e751e4f5a21549da0eb24f253f7d/ui/file_manager/file_manager/foreground/js/ui/search_box.js
[modify] https://crrev.com/10d21d2ed0b2e751e4f5a21549da0eb24f253f7d/ui/file_manager/file_manager/main.html

Status: Fixed (was: Started)
Issue should be fixed with the CL merged above.

Sign in to add a comment