Issue metadata
Sign in to add a comment
|
Overflow clip paint property and pixel snapping |
||||||||||||||||||||||
Issue descriptionWe currently do not pixel snap overflow clip paint property nodes: https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp?q=paintpropertytreeb&sq=package:chromium&l=838 This change was made in: Don't pixel-snap overflow clips in clip paint property nodes. https://chromium.googlesource.com/chromium/src/+/19b6d116165378bc06ae204d74b5b1da58caa9ab In my patch to implement composed scrolling in SPV2, using un-snapped composited clip bounds causes the scrolling layer to spill out over the contents in compositing/overflow/fractional-sized-scrolling-layer.html: https://chromium-review.googlesource.com/c/609317 Some options: 1) We could pixel snap when converting the blink clip paint property node to the cc paint property node. 2) During property tree building we will likely know whether a scroll node will be composited. We could only snap in these cases. I don't really like any of these options. Do folks have opinions about how to handle this?
,
Aug 22 2017
The NextAction date has arrived: 2017-08-22
,
Aug 26 2017
Rough plan: 1) Pixel snap overflow clip rect in PaintPropertyTreeBuilder. 2) Remove subpixel accumulation from PaintLayerClipper
,
Mar 19 2018
compositing/overflow/fractional-sized-scrolling-layer.html passed as of today (2018-03-19). Probably related to vmpstr's recent change around clip snapping.
,
Yesterday
(25 hours ago)
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by pdr@chromium.org
, Aug 15 2017Owner: pdr@chromium.org
Status: Assigned (was: Available)