PDFExtensionTest.RedirectsFailInPlugin (browser_tests) fails with --mus |
||||||||||
Issue descriptionI'm not entirely sure what is causing the failure. Differences I've noticed: . BrowserPluginManager::DidCommitCompositorFrame is not called as often. . The IPC BrowserPluginMsg_SetChildFrameSurface is never sent. I'm not sure if either if these really matter though, and it's entirely possible the problem lies some where else. That said, I'm guessing it's the BrowserPluginMsg_SetChildFrameSurface that is important here and needed to wire up some stuff. In particular it looks like that is what ultimately triggers creating ChildFrameCompositingHelper, which seems to install a WebLayout and update visibility.
,
Aug 15 2017
I don't think the PDF viewer works with --mus.
,
Aug 15 2017
That could certainly be the reason for the failure. What needs to be done to get PDF working with --mus?
,
Aug 15 2017
I filed issue 755440 for getting pdf to work with --mus/--mash.
,
Aug 15 2017
The problem seems to be more about embedding oopif/<webview> into a web-page. Probably the same issue breaking the login page ( issue 732424 ).
,
Aug 15 2017
,
Aug 23 2017
,
Aug 29 2017
I've recently learned that OOPIF/webview work a bit different from the PDF viewer, just an FYI. PDF viewer uses RenderWidgetHostViewGuest and doesn't use CrossProcessFrameConnector. This is apparently going to be unified sometime "soon".
,
Oct 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/73f609d62096e6ba344d71226702ff69cd58da57 commit 73f609d62096e6ba344d71226702ff69cd58da57 Author: Scott Violet <sky@chromium.org> Date: Thu Oct 12 02:04:00 2017 chromeos: enable more browser_tests for mus These tests are passing and no longer need to be disabled. BUG= 754846 , 753593 , 759156 , 755272 Change-Id: I5bc6305d000d515688166575ad8ac7af6c7e8afd Reviewed-on: https://chromium-review.googlesource.com/714118 Reviewed-by: Michael Wasserman <msw@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#508221} [modify] https://crrev.com/73f609d62096e6ba344d71226702ff69cd58da57/testing/buildbot/filters/mus.browser_tests.filter
,
Oct 12 2017
This test now passes, perhaps do to getting OOPIF working.
,
Oct 20 2017
There are still references to this bug in testing/buildbot/filters/mus.browser_tests.filter and testing/buildbot/filters/mojo.fyi.mus.browser_tests.filter. Should: 1) the bug be reopened? 2) the comments be removed / updated?
,
Oct 20 2017
Not sure what happened there. Will take another look shortly.
,
Nov 6 2017
,
Nov 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/105a574c3f31ab29b2fbb3f66f6b2f8b28b2a8e9 commit 105a574c3f31ab29b2fbb3f66f6b2f8b28b2a8e9 Author: Scott Violet <sky@chromium.org> Date: Fri Nov 10 06:21:24 2017 chromeos: reenables pdf tests for mus_browser_tests These tests now pass since PDF were made to work (755440). BUG= 755272 TEST=test only change TBR=msw@chromium.org Change-Id: Id79e8aa6dbf810a5f6789943e5b6a2665e2dc3e4 Reviewed-on: https://chromium-review.googlesource.com/761956 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#515472} [modify] https://crrev.com/105a574c3f31ab29b2fbb3f66f6b2f8b28b2a8e9/testing/buildbot/filters/mojo.fyi.mus.browser_tests.filter
,
Nov 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7d42428d0212aa3a337168c95e0f4d0a6cd2e974 commit 7d42428d0212aa3a337168c95e0f4d0a6cd2e974 Author: Scott Violet <sky@chromium.org> Date: Mon Nov 13 22:44:31 2017 chromeos: update browser_tests --mus from fyi filter file The FYI bot ran without any failures in browser_tests for the weekend. BUG= 755272 ,755328 TEST=test only change Change-Id: I104e75be6c0f6edf767cb1e67eafb4514725d1c2 Reviewed-on: https://chromium-review.googlesource.com/767015 Reviewed-by: Michael Wasserman <msw@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#516085} [modify] https://crrev.com/7d42428d0212aa3a337168c95e0f4d0a6cd2e974/testing/buildbot/filters/mus.browser_tests.filter
,
Nov 13 2017
,
Jan 22 2018
,
Jan 23 2018
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by sky@chromium.org
, Aug 14 2017