New issue
Advanced search Search tips

Issue 755271 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug
Team-Accessibility

Blocking:
issue 762575



Sign in to add a comment

[A11y Assessment - File Manager] Change labels for list view / thumbnail view

Project Member Reported by lpalmaro@chromium.org, Aug 14 2017

Issue description

OS: Chrome
Version: 61.0.3163.38

1. Enable ChromeVox with Ctrl Alt Z
2. Press Alt Shift M to open the files manager
3. Press Search + Right to navigate through item by item on the screen using ChromeVox 


Currently, when you navigate to the List View or Grid View buttons to change the view, the experience isn't intuitive. The labels with ChromeVox on are "list view" when you reach the button to switch to list view, and "grid view" when you get to the button to switch to grid view. We should change these labels so that ChromeVox reads "switch to list view, button" and "switch to grid view, button", otherwise it's confusing which one is actually showing. 
 
Summary: [A11y Assessment - File Manager] Change labels for list view / thumbnail view (was: [A11y Assessment - File Manager] Change labels for list view / grid view )
Sorry, when I said grid, I meant thumbnail! :) 
Cc: yamaguchi@chromium.org fukino@chromium.org
Components: Platform>Apps>FileManager
Blockedon: 762575
Blockedon: -762575
Blocking: 762575
Cc: weifangsun@chromium.org
Owner: yamaguchi@chromium.org
Status: Started (was: Assigned)
I think there's the same problem when the aria-label is displayed by the visual agent (e.g. the tooltip that appears upon mouse hover).
So I think we can update the aria-label to the same ones.
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f2527f08d32aa5f9f13d37bdac85b416199fde61

commit f2527f08d32aa5f9f13d37bdac85b416199fde61
Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Date: Tue Sep 26 11:17:01 2017

Make labels of list / thumbnail view button more descriptive.

The button currently says the mode after view change, like "thumbnail
view". It is not clear if it's current mode or the other mode.
This was especially confusing when using screenreaders.

Bug:  755271 
Change-Id: Ie305971a32224d6ea715df5ab0fc1e0dd6e2aa91
Reviewed-on: https://chromium-review.googlesource.com/684096
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504335}
[modify] https://crrev.com/f2527f08d32aa5f9f13d37bdac85b416199fde61/chrome/app/chromeos_strings.grdp

Status: Fixed (was: Started)
This should have been resolved by the change in Comment #7.
Sorry I missed to update the issue status.

Comment 9 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 10 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment