New issue
Advanced search Search tips

Issue 755254 link

Starred by 1 user
Status: Fixed
Owner:
estevenson@chromium.org
Closed: Aug 2017
Cc:
waff...@chromium.org
estevenson@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Static initializer regression in resource_sizes (MonochromePublic.apk) at 494091:494091

Project Member Reported by estevenson@chromium.org, Aug 14 2017 
Caused by “Upload component versions to Crash and UMA.”

Commit: 404c74d7436c836356f0803afad8c9c63fa3c0a1

Link to size graph: https://chromeperf.appspot.com/report?sid=2e1421013ce75306cdc0974cbd058b84083ef684dabed256879bacb31613b326&num_points=10&rev=494091

Policy is to revert the CL that added static initializers and reland it with the fix.

You can verify locally that no static initializers are added by running the following from within an Android checkout: tools/binary_size/diagnose_bloat.py HEAD -v

Common fixes include:

Add constexpr,
Use LazyInstance<>,
Use a getter to return a local static variable.
Thanks!
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Aug 14 2017 

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=755254

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=c22e3a19a0f4214152786600713432669f6d32efb0274ee94018f6b0a2529047


Bot(s) for this bug's original alert(s):

Android Builder

Comment 2 by estevenson@chromium.org, Aug 14 2017

Cc: waff...@chromium.org
Owner: estevenson@chromium.org
Status: Assigned (was: Untriaged)
Created revert here: https://chromium-review.googlesource.com/c/598649.

Comment 3 by estevenson@chromium.org, Aug 14 2017

Status: Fixed (was: Assigned)
Err, here: https://chromium-review.googlesource.com/c/614241.
►

Sign in to add a comment