The hover not working is due to ui-scale not being supported yet, I think. /cc+ kylechar@ riajiang@

That shouldn't affect ctrl-t ctrl-n though. That seems weird.

I forgot to put in description: with --mus

Ctrl+Shift+Plus and Ctrl+Shift+Minus were working in mus last week. I just sync'd back one week to 01cf6fd553bcc6d5a9ca6763eed42fbca5ecc494 and it works there. I can bisect to try and find the culprit.

sadrul: The breakage happened in 04d5dd4d7a57ba5ffe29ca76736c8e15ca907e4c.

I would assume it's now broken because the CompositorFrame size changes but the aura window size doesn't change when changing the UI scale factor?

Fix (for visuals only) up for review https://chromium-review.googlesource.com/c/614700

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e0466cee3aa3f9f937fe0e515899ae808929ffb3

commit e0466cee3aa3f9f937fe0e515899ae808929ffb3
Author: Sadrul Habib Chowdhury <sadrul@chromium.org>
Date: Tue Aug 15 16:28:10 2017

compositor: Avoid updating cc if size does not change.

Setting the size in LayerTreeHost invalidates the LocalSurfaceId. So it
would be necessary to set it again later. However, if the size actually
did not change, then ui does not receive a new LocalSurfaceId from the
server, thus breaking the compositor (because commits are deferred until
a valid LocalSurfaceId is set).

BUG= 755238 

Change-Id: Ifc44596b8ce6a176e9221713727950ead34d3542
Reviewed-on: https://chromium-review.googlesource.com/614700
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494403}
[modify] https://crrev.com/e0466cee3aa3f9f937fe0e515899ae808929ffb3/ui/compositor/compositor.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4b6ff31143a6fa673475af22b2d3ed03e59b107

commit f4b6ff31143a6fa673475af22b2d3ed03e59b107
Author: Sadrul Chowdhury <sadrul@chromium.org>
Date: Wed Aug 16 23:53:16 2017

Revert "compositor: Avoid updating cc if size does not change."

This reverts commit e0466cee3aa3f9f937fe0e515899ae808929ffb3.

Reason for revert: Causes regressions ( crbug.com/755862  for example)

Original change's description:
> compositor: Avoid updating cc if size does not change.
> 
> Setting the size in LayerTreeHost invalidates the LocalSurfaceId. So it
> would be necessary to set it again later. However, if the size actually
> did not change, then ui does not receive a new LocalSurfaceId from the
> server, thus breaking the compositor (because commits are deferred until
> a valid LocalSurfaceId is set).
> 
> BUG= 755238 
> 
> Change-Id: Ifc44596b8ce6a176e9221713727950ead34d3542
> Reviewed-on: https://chromium-review.googlesource.com/614700
> Reviewed-by: Antoine Labour <piman@chromium.org>
> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#494403}

TBR=sadrul@chromium.org,piman@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  755238 ,  755862 
Change-Id: I2cd039a7c6ae784c0cdcee6c20f0e2bad1f18393
Reviewed-on: https://chromium-review.googlesource.com/617942
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495002}
[modify] https://crrev.com/f4b6ff31143a6fa673475af22b2d3ed03e59b107/ui/compositor/compositor.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/509649266c23e307a2e8285b155eb9b0228f7281

commit 509649266c23e307a2e8285b155eb9b0228f7281
Author: Sadrul Habib Chowdhury <sadrul@chromium.org>
Date: Thu Aug 17 04:59:56 2017

Revert "compositor: Avoid updating cc if size does not change."

This reverts commit e0466cee3aa3f9f937fe0e515899ae808929ffb3.

Reason for revert: Causes regressions ( crbug.com/755862  for example)

Original change's description:
> compositor: Avoid updating cc if size does not change.
>
> Setting the size in LayerTreeHost invalidates the LocalSurfaceId. So it
> would be necessary to set it again later. However, if the size actually
> did not change, then ui does not receive a new LocalSurfaceId from the
> server, thus breaking the compositor (because commits are deferred until
> a valid LocalSurfaceId is set).
>
> BUG= 755238 
>
> Change-Id: Ifc44596b8ce6a176e9221713727950ead34d3542
> Reviewed-on: https://chromium-review.googlesource.com/614700
> Reviewed-by: Antoine Labour <piman@chromium.org>
> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#494403}

TBR=piman@chromium.org, sadrul@chromium.org


(cherry picked from commit f4b6ff31143a6fa673475af22b2d3ed03e59b107)

Bug:  755238 ,  755862 
Change-Id: I2cd039a7c6ae784c0cdcee6c20f0e2bad1f18393
Reviewed-on: https://chromium-review.googlesource.com/617942
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#495002}
Reviewed-on: https://chromium-review.googlesource.com/617886
Cr-Commit-Position: refs/branch-heads/3187@{#5}
Cr-Branched-From: 1066a02fc3eda664375a59a5962ccffa0e28c81f-refs/heads/master@{#494644}
[modify] https://crrev.com/509649266c23e307a2e8285b155eb9b0228f7281/ui/compositor/compositor.cc

Migrating Proj-Mustash-Mus to components Internals>Services>WindowService and Internals>Services>Ash

Scaling works in mash, and we don't have "mus" anymore.