file:/// browsing no longer has [parent directory]
Reported by
vanantwe...@gmail.com,
Aug 14 2017
|
|||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.90 Safari/537.36 Example URL: file:///C:/Program%20Files/ Steps to reproduce the problem: Go to file:///C:/Program%20Files/ What is the expected behavior? What went wrong? No [parent directory] available Does it occur on multiple sites: Yes Is it a problem with a plugin? No Did this work before? N/A Does this work in other browsers? Yes Chrome version: 60.0.3112.90 Channel: stable OS Version: 10.0 Flash Version: N/A Reported on the help forum: https://productforums.google.com/forum/#!topic/chrome/_FqQFTIbJRs Used to exist before: https://dt.azadicdn.com/wp-content/uploads/2014/08/View-local-images-in-Chrome-b.png?200
,
Aug 15 2017
Will take a look.
,
Aug 16 2017
tzik: This may affect the code that calls GetDirectoryListingEntry() in storage/browser/fileapi/file_system_dir_url_request_job.cc as well. That looks related to bug 89134 , but I have no idea where the UI to access that code is.
,
Aug 16 2017
https://chromium-review.googlesource.com/c/616351 BTW, FTP is probably not the right bug component, but I'm not sure what's a better component. Just going to leave it.
,
Aug 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0f07813faaf16639f6ad4aaded973b11787015b8 commit 0f07813faaf16639f6ad4aaded973b11787015b8 Author: Lei Zhang <thestig@chromium.org> Date: Thu Aug 17 16:24:45 2017 Fix missing parent dir link when browsing file:// URLs. This regressed in r466103 when the FTP directory listing code changed. Some of that code is also used for file:// directory listings in URLRequestFileDirJob, but URLRequestFileDirJob did not get updated to match the changes in r466103. Make up for that now, and add more rigorous unit tests for URLRequestFileDirJob. BUG= 755236 Change-Id: I7809dcd5ab03937c0e00933dc69add9f22915c49 Reviewed-on: https://chromium-review.googlesource.com/616351 Reviewed-by: Camille Lamy <clamy@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#495189} [modify] https://crrev.com/0f07813faaf16639f6ad4aaded973b11787015b8/content/child/ftp_directory_listing_response_delegate.cc [modify] https://crrev.com/0f07813faaf16639f6ad4aaded973b11787015b8/net/base/directory_listing.cc [modify] https://crrev.com/0f07813faaf16639f6ad4aaded973b11787015b8/net/base/directory_listing.h [modify] https://crrev.com/0f07813faaf16639f6ad4aaded973b11787015b8/net/url_request/url_request_file_dir_job.cc [modify] https://crrev.com/0f07813faaf16639f6ad4aaded973b11787015b8/net/url_request/url_request_file_dir_job.h [modify] https://crrev.com/0f07813faaf16639f6ad4aaded973b11787015b8/net/url_request/url_request_file_dir_job_unittest.cc
,
Aug 17 2017
Fix will be in 62.0.3189.0 and newer. We will look into merging the fix to M60 and M61 after verifying the fix on Canary channel.
,
Aug 17 2017
,
Aug 17 2017
,
Aug 21 2017
Verified on Canary channel. Let's first do a merge to Beta channel.
,
Aug 21 2017
This bug requires manual review: M61 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 21 2017
Before we approve merge to M61, please answer followings: * Is this M61 regression? Is it critical? (This was regressed in M60) * Is the change well baked in Canary, having enough automation tests coverage and safe to merge to M61? (Per comment #9 already verified in Canary) * Any other important details to justify the merge. Please note We're only few weeks away from M61 Stable promotion, so merge bar is very high.
,
Aug 21 2017
This was working in M59. It's broken in M60 and M61, and earlier M62 builds. Because it regressed, I would like to get the fix out sooner than later. The change is baked in Canary. It has unit test coverage now.
,
Aug 21 2017
Rejecting merge to M61 per chat with thestig@ as this is not M61 regression (exists on M60) and we're ONLY taking critical merges in for M61. Note: Fix will be in 62.0.3189.0 and newer. Thank you. |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by manoranj...@chromium.org
, Aug 14 2017Labels: -Type-Bug M-60 OS-Linux OS-Mac Type-Bug-Regression
Owner: thestig@chromium.org
Status: Assigned (was: Unconfirmed)