Pods are misplaced at login screen after Add person screen is closed |
||||||
Issue descriptionChrome Version: 62.0.3186.0 OS: Chrome What steps will reproduce the problem? (1) Open Add person screen first, and then open virtual keyboard. (2) Scroll up the screen until the Back button is visible. Click it. (3) The pods are mispalced. (4) However, if you do not scroll the Add person screen upward, but use Esc to close it instead, there's no issue. (5) The same is for any other screens (network error etc.)
,
Aug 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d303741906aad6c1ac59317153d4140836d3a2d1 commit d303741906aad6c1ac59317153d4140836d3a2d1 Author: Wenzhao Zang <wzang@chromium.org> Date: Mon Aug 14 23:31:13 2017 Make pod placement work with a previously scrollable container In the new UI the account picker doesn't need to be scrollable, but its container is shared with other screens such as Add person which enables scrolling, so during pod placement we should explicitly disable scrolling and also check the scrollTop value in case the screen has been scrolled before. Bug: 755228 Change-Id: I3f531ae405629bb4edbe014baba85213cd847633 Reviewed-on: https://chromium-review.googlesource.com/614118 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#494245} [modify] https://crrev.com/d303741906aad6c1ac59317153d4140836d3a2d1/ui/login/account_picker/md_screen_account_picker.js [modify] https://crrev.com/d303741906aad6c1ac59317153d4140836d3a2d1/ui/login/account_picker/md_user_pod_row.js [modify] https://crrev.com/d303741906aad6c1ac59317153d4140836d3a2d1/ui/login/md_screen_container.css
,
Aug 14 2017
,
Aug 14 2017
This issue also exists in M61.
,
Aug 15 2017
Approving merge to M61 Chrome OS.
,
Aug 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bf592adbe1bee416d98485fb16b94ba4da086658 commit bf592adbe1bee416d98485fb16b94ba4da086658 Author: Wenzhao Zang <wzang@chromium.org> Date: Tue Aug 15 01:52:26 2017 Make pod placement work with a previously scrollable container In the new UI the account picker doesn't need to be scrollable, but its container is shared with other screens such as Add person which enables scrolling, so during pod placement we should explicitly disable scrolling and also check the scrollTop value in case the screen has been scrolled before. TBR=wzang@chromium.org (cherry picked from commit d303741906aad6c1ac59317153d4140836d3a2d1) Bug: 755228 Change-Id: I3f531ae405629bb4edbe014baba85213cd847633 Reviewed-on: https://chromium-review.googlesource.com/614118 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#494245} Reviewed-on: https://chromium-review.googlesource.com/615084 Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#567} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/bf592adbe1bee416d98485fb16b94ba4da086658/ui/login/account_picker/md_screen_account_picker.js [modify] https://crrev.com/bf592adbe1bee416d98485fb16b94ba4da086658/ui/login/account_picker/md_user_pod_row.js [modify] https://crrev.com/bf592adbe1bee416d98485fb16b94ba4da086658/ui/login/md_screen_container.css
,
Aug 15 2017
,
Jan 22 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by wzang@chromium.org
, Aug 14 2017266 KB
266 KB View Download