New issue
Advanced search Search tips

Issue 755224 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 742470
Owner:
Closed: Aug 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Power improvement on load_media_google_images in range 486805-486934

Project Member Reported by charliea@chromium.org, Aug 14 2017

Issue description

I'm going to launch a bisect to try to identify it, but am using this bug to track it.
 
Cc: sdy@chromium.org
Bisect is having some trouble posting to this bug (I found it through the dashboard alerting system), but the improvement appears to be caused by https://chromium-review.googlesource.com/571420

+sdy FYI

(for bisect problem see https://github.com/catapult-project/catapult/issues/3778)
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Aug 16 2017

Owner: sdy@chromium.org

=== Auto-CCing suspected CL author sdy@chromium.org ===

Hi sdy@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Sidney San Martín
  Commit : ec030bde9b5ebbd500fe769af1ac6a47e6baa5c0
  Date   : Fri Jul 14 19:20:53 2017
  Subject: Require 10.12 for ShouldUseFullSizeContentView().

Bisect Details
  Configuration: mac_pro_perf_bisect
  Benchmark    : system_health.common_desktop
  Metric       : load:energy_sum/load_media/load_media_google_images
  Change       : 7.85% | 18.0472445686 -> 16.629661807

Revision             Result                   N
chromium@486805      18.0472 +- 4.5125        14      good
chromium@486822      18.2721 +- 0.638956      6       good
chromium@486830      18.3499 +- 0.596026      6       good
chromium@486834      18.1773 +- 1.66814       9       good
chromium@486836      18.1925 +- 0.628379      6       good
chromium@486837      18.2586 +- 0.756454      6       good
chromium@486838      16.6704 +- 1.26164       6       bad       <--
chromium@486870      16.7346 +- 0.77475       6       bad
chromium@486934      16.6297 +- 3.82732       14      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=load.media.google.images system_health.common_desktop

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8971262121741666416


For feedback, file a bug with component Speed>Bisection

Comment 4 by sdy@chromium.org, Aug 18 2017

Mergedinto: 742470
Status: Duplicate (was: Assigned)
I think this is the same improvement seen in  issue 742470 . Sadly nothing super interesting!

Sign in to add a comment