New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 755214 link

Starred by 1 user
Status: Duplicate
Merged: issue 754025
Owner:
█ yunlian@chromium.org
Last visit > 30 days ago
Closed: Aug 2017
Cc:
derat@chromium.org
isherman@chromium.org
thakis@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

chromeos-chrome build fails with unrecognized -nostdlib++ flags

Project Member Reported by dongseon...@intel.com, Aug 14 2017 
The chromeos-chrome package just failed to build amd64-generic on my local machine

the failure message:
chromeos-chrome-62.0.3176.0_rc-r1: [27/26273] LINK host/minidump_stackwalk
chromeos-chrome-62.0.3176.0_rc-r1: FAILED: host/minidump_stackwalk 
chromeos-chrome-62.0.3176.0_rc-r1: python "../../../../../../../home/dshwang/chrome_root/src/build/toolchain/gcc_link_wrapper.py" --output="host/minidump_stackwalk" -- x86_64-pc-linux-gnu-g++ -Wl,--fatal-warnings -fPIC -Wl,-z,noexecstack -Wl,-z,now -Wl,-z,relro -Wl,-z,defs -Wl,--no-as-needed -lpthread -Wl,--as-needed -fuse-ld=gold -B../../../../../../../home/dshwang/chrome_root/src/third_party/binutils/Linux_x64/Release/bin -m64 -Wl,-O1 -Wl,--gc-sections -Wl,--gdb-index -nostdlib++ -Wl,-rpath-link=host -Wl,--disable-new-dtags -o "host/minidump_stackwalk" -Wl,--start-group @"host/minidump_stackwalk.rsp"  -Wl,--end-group   -ldl -lpthread -lrt 
chromeos-chrome-62.0.3176.0_rc-r1: x86_64-pc-linux-gnu-g++.real: error: unrecognized command line option '-nostdlib++'
chromeos-chrome-62.0.3176.0_rc-r1:

Comment 1 by yunlian@chromium.org, Aug 14 2017 

This has been fixed by https://chromium-review.googlesource.com/c/609461
Can you check the latest chromiumos-sdk?

Comment 2 by manojgupta@chromium.org, Aug 14 2017 

Are you trying to build a new version of chrome? This error was seen only in not-yet uprev chrome versions.

Meanwhile, you can make a local change as this CL to fix this (https://chromium-review.googlesource.com/c/610520/2/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild )

Comment 3 by llozano@chromium.org, Aug 14 2017

Owner: yunlian@chromium.org
Status: Assigned (was: Untriaged)

Comment 4 by dongseon...@intel.com, Aug 14 2017 

Yes, it looks like duplicated to  issue 754025 

BTW, the following chromium change resolves this issue, while it looks not right solution.

> git diff
diff --git a/build/config/posix/BUILD.gn b/build/config/posix/BUILD.gn
index 6609290..aa33645 100644
--- a/build/config/posix/BUILD.gn
+++ b/build/config/posix/BUILD.gn
@@ -44,7 +44,6 @@ config("runtime_library") {
       cflags += [ "-fno-builtin-abs" ]
     }
     cflags_cc += [
-      "-nostdinc++",
       "-isystem" + rebase_path("$libcxx_prefix/include", root_build_dir),
       "-isystem" + rebase_path("$libcxxabi_prefix/include", root_build_dir),
     ]
@@ -56,9 +55,6 @@ config("runtime_library") {
       cflags_cc += [ "-isystem" +
                      rebase_path("$libunwind_prefix/include", root_build_dir) ]
     }
-
-    # Make sure we don't link against libc++ or libstdc++.
-    ldflags += [ "-nostdlib++" ]
   }
 
   if (!is_mac && !is_ios && sysroot != "") {

Comment 5 by yunlian@chromium.org, Aug 14 2017 

You can workaround this by using the change in #4.

As Manoj said, you can cherry pick the change
https://chromium-review.googlesource.com/c/610520
To your current active chromeos-chrome ebuild file.
It is chromeos-chrome-62.0.3176.0_rc-r1.ebuild
in this case.

Comment 6 by thakis@chromium.org, Aug 14 2017

Mergedinto: 754025
Status: Duplicate (was: Assigned)
►

Sign in to add a comment