New issue
Advanced search Search tips

Issue 755188 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: 1
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

[Mac] Toolbar damaged when window dragged out

Project Member Reported by a...@chromium.org, Aug 14 2017

Issue description

In canary, 62.0.3185.0

To repro:

Click the NTB to get a new tab. Drag it out.
 
Screen Shot 2017-08-14 at 1.13.56 PM.png
1.4 MB View Download
Screen Shot 2017-08-14 at 1.14.31 PM.png
98.9 KB View Download

Comment 1 by a...@chromium.org, Aug 14 2017

This is 10.11.6.

Comment 2 by a...@chromium.org, Aug 14 2017

You are probably looking for a change made after 492966 (known good), but no later than 492974 (first known bad).

Almost certainly https://chromium.googlesource.com/chromium/src/+/1f71c6ec3d33ac53f8e2474fbfd9e6396f731008 .

Comment 4 by a...@chromium.org, Aug 14 2017

Labels: -Pri-3 Pri-1

Comment 5 by a...@chromium.org, Aug 14 2017

Labels: OS-Mac

Comment 6 by sdy@chromium.org, Aug 14 2017

Components: UI>Browser
EstimatedDays: 1
Labels: -Type-Bug Type-Bug-Regression
Status: Started (was: Untriaged)
CL: https://chromium-review.googlesource.com/614087
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec48b797b4081fac96bc33a4f0bfd281bfb3c682

commit ec48b797b4081fac96bc33a4f0bfd281bfb3c682
Author: Sidney San Martín <sdy@chromium.org>
Date: Tue Aug 15 00:57:05 2017

Insert the content view above other views when tearing down an overlay window.

This fixes an issue where the content ended up under the tab strip
background view after dragging a tab out into a new window.

Bug:  755188 
Change-Id: I24f0da5a10b558ce426e1e080722887c44a37632
Reviewed-on: https://chromium-review.googlesource.com/614087
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494277}
[modify] https://crrev.com/ec48b797b4081fac96bc33a4f0bfd281bfb3c682/chrome/browser/ui/cocoa/tabs/tab_window_controller.mm

Comment 8 by sdy@chromium.org, Aug 22 2017

Status: Fixed (was: Started)
This was fixed by the above CL.

Sign in to add a comment