New issue
Advanced search Search tips

Issue 755185 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Aug 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Add unit tests for FlingVelocity value when dragging app list from shelf

Project Member Reported by minch@chromium.org, Aug 14 2017

Issue description

Comment 1 by minch@chromium.org, Aug 28 2017

Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a2a384f111b963d8e8211f7e52f382549b0cadc7

commit a2a384f111b963d8e8211f7e52f382549b0cadc7
Author: MinChen <minch@chromium.org>
Date: Tue Aug 29 22:45:44 2017

Swiping up on bottom shelf in laptop mode to open the fullscreen launcher.

Changes:
1. Remove the tablet mode restriction when swiping up on shelf to open the
fullscreen launcher.
2. Add EndDragFromShelf(int app_list_state) in AppList, which is used by
END gesture of the swipping. At the end of swiping it only need to set the
state of app list and update the drag state of the app list. It doesn't need
to update the position of the app list, which will be determined by the app
list state.
3. Move UpdateYPositionAndOpacity from Shell to AppList.
3. Update the logic of updating opacity at the end of dragging. Since the
animation of closing the app list. It should not restore the opacity of
app list items if it aims to close the app list.
4. Add class ShelfLayoutManagerFullscreenAppListTest.
Add FlingUpOnShelfForFullscreenAppList to test the drag ends with fling event.
Add ChangeShelfAlignmentDuringAppListDragging to test change shelf alignment
during drag.
Add SwipingUpOnShelfInLaptopModeForFullscreenAppList to test drag in laptop mode.
Move SwipingUpOnShelfInTabletModeForFullscreenAppList down to be together with
all the other fullscreen app list tests.

Spec:
https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZY5BZ8F2qhKy/files/MCGAAf1s-t7xYwIGiUbPa84BwMSJbxAVNpw

Video recorded:
Please take a look at https://bugs.chromium.org/p/chromium/issues/detail?id=754066

Test: ShelfLayoutManagerTest*
Bug: 754066, 747016 , 755185 
Change-Id: I063e23cf24a0f3c87c0c5dd090a601c2d7c10ab1
Reviewed-on: https://chromium-review.googlesource.com/637183
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: min c <minch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498265}
[modify] https://crrev.com/a2a384f111b963d8e8211f7e52f382549b0cadc7/ash/shelf/shelf_layout_manager.cc
[modify] https://crrev.com/a2a384f111b963d8e8211f7e52f382549b0cadc7/ash/shelf/shelf_layout_manager.h
[modify] https://crrev.com/a2a384f111b963d8e8211f7e52f382549b0cadc7/ash/shelf/shelf_layout_manager_unittest.cc
[modify] https://crrev.com/a2a384f111b963d8e8211f7e52f382549b0cadc7/ash/shell.cc
[modify] https://crrev.com/a2a384f111b963d8e8211f7e52f382549b0cadc7/ash/shell.h
[modify] https://crrev.com/a2a384f111b963d8e8211f7e52f382549b0cadc7/ash/shell/example_app_list_presenter.cc
[modify] https://crrev.com/a2a384f111b963d8e8211f7e52f382549b0cadc7/ash/shell/example_app_list_presenter.h
[modify] https://crrev.com/a2a384f111b963d8e8211f7e52f382549b0cadc7/chrome/browser/ui/ash/app_list/app_list_presenter_service.cc
[modify] https://crrev.com/a2a384f111b963d8e8211f7e52f382549b0cadc7/chrome/browser/ui/ash/app_list/app_list_presenter_service.h
[modify] https://crrev.com/a2a384f111b963d8e8211f7e52f382549b0cadc7/ui/app_list/presenter/app_list.cc
[modify] https://crrev.com/a2a384f111b963d8e8211f7e52f382549b0cadc7/ui/app_list/presenter/app_list.h
[modify] https://crrev.com/a2a384f111b963d8e8211f7e52f382549b0cadc7/ui/app_list/presenter/app_list_presenter.mojom
[modify] https://crrev.com/a2a384f111b963d8e8211f7e52f382549b0cadc7/ui/app_list/presenter/app_list_presenter_impl.cc
[modify] https://crrev.com/a2a384f111b963d8e8211f7e52f382549b0cadc7/ui/app_list/presenter/app_list_presenter_impl.h
[modify] https://crrev.com/a2a384f111b963d8e8211f7e52f382549b0cadc7/ui/app_list/presenter/test/test_app_list_presenter.cc
[modify] https://crrev.com/a2a384f111b963d8e8211f7e52f382549b0cadc7/ui/app_list/presenter/test/test_app_list_presenter.h
[modify] https://crrev.com/a2a384f111b963d8e8211f7e52f382549b0cadc7/ui/app_list/views/app_list_view.cc
[modify] https://crrev.com/a2a384f111b963d8e8211f7e52f382549b0cadc7/ui/app_list/views/app_list_view.h
[modify] https://crrev.com/a2a384f111b963d8e8211f7e52f382549b0cadc7/ui/app_list/views/apps_grid_view.cc
[modify] https://crrev.com/a2a384f111b963d8e8211f7e52f382549b0cadc7/ui/app_list/views/search_box_view.cc

Comment 3 by minch@chromium.org, Aug 29 2017

Cc: msw@chromium.org
Status: Fixed (was: Started)

Comment 4 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment