New issue
Advanced search Search tips

Issue 755180 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Move RenderWidgetHostViewChildFrame to renderer_host

Project Member Reported by kenrb@chromium.org, Aug 14 2017

Issue description

RenderWidgetHostViewChildFrame is currently content/browser/frame_host. It should instead be in content/browser/renderer_host with most of the rest of the RenderWidgetHostView implementations.

A delegation interface needs to be set up for it to be able to continue calling methods on CrossProcessFrameConnector.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/daef006b6ac4346e6fa7fb92a4a316a629913dba

commit daef006b6ac4346e6fa7fb92a4a316a629913dba
Author: Ken Buchanan <kenrb@chromium.org>
Date: Thu Aug 17 18:32:15 2017

Move RenderWidgetHostViewChildFrame to renderer_host

RenderWidgetHostViewChildFrame moves from frame_host to renderer_host
within content/browser/, and gets a delegate interface so that it can
continue to call methods on CrossProcessFrameConnector.

Bug:  755180 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: Icb70cf83842b9254963ba97b0e57483dde8b042e
Reviewed-on: https://chromium-review.googlesource.com/613940
Commit-Queue: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Charlie Reis (OOO Aug 17-24) <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495239}
[modify] https://crrev.com/daef006b6ac4346e6fa7fb92a4a316a629913dba/content/browser/BUILD.gn
[modify] https://crrev.com/daef006b6ac4346e6fa7fb92a4a316a629913dba/content/browser/accessibility/dump_accessibility_browsertest_base.cc
[modify] https://crrev.com/daef006b6ac4346e6fa7fb92a4a316a629913dba/content/browser/accessibility/site_per_process_accessibility_browsertest.cc
[modify] https://crrev.com/daef006b6ac4346e6fa7fb92a4a316a629913dba/content/browser/accessibility/touch_accessibility_aura_browsertest.cc
[modify] https://crrev.com/daef006b6ac4346e6fa7fb92a4a316a629913dba/content/browser/browser_plugin/browser_plugin_guest.cc
[modify] https://crrev.com/daef006b6ac4346e6fa7fb92a4a316a629913dba/content/browser/frame_host/cross_process_frame_connector.cc
[modify] https://crrev.com/daef006b6ac4346e6fa7fb92a4a316a629913dba/content/browser/frame_host/cross_process_frame_connector.h
[modify] https://crrev.com/daef006b6ac4346e6fa7fb92a4a316a629913dba/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/daef006b6ac4346e6fa7fb92a4a316a629913dba/content/browser/frame_host/render_frame_proxy_host.cc
[modify] https://crrev.com/daef006b6ac4346e6fa7fb92a4a316a629913dba/content/browser/frame_host/render_widget_host_view_guest.h
[modify] https://crrev.com/daef006b6ac4346e6fa7fb92a4a316a629913dba/content/browser/renderer_host/DEPS
[add] https://crrev.com/daef006b6ac4346e6fa7fb92a4a316a629913dba/content/browser/renderer_host/frame_connector_delegate.cc
[add] https://crrev.com/daef006b6ac4346e6fa7fb92a4a316a629913dba/content/browser/renderer_host/frame_connector_delegate.h
[modify] https://crrev.com/daef006b6ac4346e6fa7fb92a4a316a629913dba/content/browser/renderer_host/input/touch_selection_controller_client_aura_browsertest.cc
[modify] https://crrev.com/daef006b6ac4346e6fa7fb92a4a316a629913dba/content/browser/renderer_host/input/touch_selection_controller_client_child_frame.cc
[modify] https://crrev.com/daef006b6ac4346e6fa7fb92a4a316a629913dba/content/browser/renderer_host/render_widget_host_input_event_router.cc
[rename] https://crrev.com/daef006b6ac4346e6fa7fb92a4a316a629913dba/content/browser/renderer_host/render_widget_host_view_child_frame.cc
[rename] https://crrev.com/daef006b6ac4346e6fa7fb92a4a316a629913dba/content/browser/renderer_host/render_widget_host_view_child_frame.h
[rename] https://crrev.com/daef006b6ac4346e6fa7fb92a4a316a629913dba/content/browser/renderer_host/render_widget_host_view_child_frame_browsertest.cc
[rename] https://crrev.com/daef006b6ac4346e6fa7fb92a4a316a629913dba/content/browser/renderer_host/render_widget_host_view_child_frame_unittest.cc
[modify] https://crrev.com/daef006b6ac4346e6fa7fb92a4a316a629913dba/content/browser/site_per_process_browsertest.cc
[modify] https://crrev.com/daef006b6ac4346e6fa7fb92a4a316a629913dba/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/daef006b6ac4346e6fa7fb92a4a316a629913dba/content/browser/web_contents/web_contents_view_child_frame.cc
[modify] https://crrev.com/daef006b6ac4346e6fa7fb92a4a316a629913dba/content/public/test/browser_test_utils.cc
[modify] https://crrev.com/daef006b6ac4346e6fa7fb92a4a316a629913dba/content/test/BUILD.gn

Comment 2 by kenrb@chromium.org, Aug 17 2017

Status: Fixed (was: Started)

Sign in to add a comment