VR preview notice color should be customized for incognito |
|||||||||
Issue descriptionToT at August 14th. In order to make a simple merge back to M-61, the preview text color was not parameterized based on mode. During testing, I found that the warning is nearly invisible while incognito. We should specify an incognito color and use the color scheme for this text.
,
Aug 14 2017
,
Aug 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f0d3db51d2963d64647c3cdda75e59ec387f0f70 commit f0d3db51d2963d64647c3cdda75e59ec387f0f70 Author: Christopher Grant <cjgrant@chromium.org> Date: Mon Aug 14 21:10:00 2017 VR: Parameterize preview text for incognito mode The preview product text color should be tailored for incognito to make it properly visible. BUG= 755171 R=vollick Change-Id: Id907609fa78f5f92e61929d6cd719bc5df7c0f60 Reviewed-on: https://chromium-review.googlesource.com/614071 Reviewed-by: Ian Vollick <vollick@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#494189} [modify] https://crrev.com/f0d3db51d2963d64647c3cdda75e59ec387f0f70/chrome/browser/vr/color_scheme.cc [modify] https://crrev.com/f0d3db51d2963d64647c3cdda75e59ec387f0f70/chrome/browser/vr/color_scheme.h [modify] https://crrev.com/f0d3db51d2963d64647c3cdda75e59ec387f0f70/chrome/browser/vr/elements/text.cc
,
Aug 14 2017
,
Aug 14 2017
,
Aug 14 2017
This bug requires manual review: M61 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 15 2017
Merge approved for M61 branch 3163. Please merge ASAP as we cut this week's beta release at 5 PM PT today.
,
Aug 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c60f9ee1483a83c2d997a6af82d048efff5bb6bf commit c60f9ee1483a83c2d997a6af82d048efff5bb6bf Author: Ian Vollick <vollick@chromium.org> Date: Tue Aug 15 16:49:48 2017 VR: Parameterize preview text for incognito mode The preview product text color should be tailored for incognito to make it properly visible. This is merging cjgrant@'s change from https://chromium-review.googlesource.com/c/614071 Bug: 755171 Change-Id: I7136e2a61c0523a602a1450107b95833ec327bc1 Reviewed-on: https://chromium-review.googlesource.com/614086 Reviewed-by: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#571} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/c60f9ee1483a83c2d997a6af82d048efff5bb6bf/chrome/browser/vr/color_scheme.cc [modify] https://crrev.com/c60f9ee1483a83c2d997a6af82d048efff5bb6bf/chrome/browser/vr/color_scheme.h [modify] https://crrev.com/c60f9ee1483a83c2d997a6af82d048efff5bb6bf/chrome/browser/vr/elements/text.cc
,
Aug 15 2017
,
Sep 5 2017
verified in 61.0.3163.79 |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by cjgrant@chromium.org
, Aug 14 2017