Issue metadata
Sign in to add a comment
|
URL scheme should be emphasized while incognito |
||||||||||||||||||||||
Issue descriptionChrome Version: ToT as of August 14 / M-62. While developing the UI for the URL bar in VR, an in-depth conversation took place on scheme emphasis. During this discussion, pkasting@ pointed out that Clank's formatting of scheme is incorrect while incognito. See issue 735759 comment 14 here: https://bugs.chromium.org/p/chromium/issues/detail?id=735759#c14 Images of Clank's current scheme, and VR's final scheme, are attached. Peter asks that Clank change to emphasize the scheme as well as host.
,
Aug 14 2017
CC'ing fgorski@, as we've talked about Clank's URL bar implementation, and I'd like to flag this in the context of future rework.
,
Aug 14 2017
Ted, Would that be a good opportunity to move on with my summer project? Putting in the new rule for URL emphasis would be simple and well testable once decoupled.
,
Aug 14 2017
I "believe" this is already pretty well isolated from the rest of the omnibox code. https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chrome/browser/omnibox/OmniboxUrlEmphasizer.java and has tests: https://cs.chromium.org/chromium/src/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/OmniboxUrlEmphasizerTest.java We could certainly look at sharing the styling more with desktop though, but a fair amount of this differs due to how Android handles theme colors. But unifying the style segments across platforms seems like a good thing (even if that means the shared code has some concept of themes).
,
Aug 14 2017
Here's the code that does the strikethrough: https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chrome/browser/omnibox/OmniboxUrlEmphasizer.java?q=OmniboxUrlEmphasizer&sq=package:chromium&l=178
,
Aug 18 2017
,
Nov 10 2017
,
Feb 18 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by cjgrant@chromium.org
, Aug 14 2017