New issue
Advanced search Search tips

Issue 755158 link

Starred by 1 user
Status: Fixed
Owner:
xiaochu@chromium.org
Closed: Sep 2017
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

make cros_component_installer built for chrome os only

Project Member Reported by xiaochu@chromium.org, Aug 14 2017 
remove #ifdef and make the 2 files built on cros only.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76d7d0e9cd8bb2a9a24b778f42895ebb162580ea

commit 76d7d0e9cd8bb2a9a24b778f42895ebb162580ea
Author: Xiaochu Liu <xiaochu@chromium.org>
Date: Thu Sep 14 20:49:46 2017

Build cros_component_installer on chromeos only

No logic change at all; remove #ifdef s and move filename in BUILD
behind ischromeos flag and compile only for chrome os.

BUG= chromium:755158 
TEST=compile on chrome os and check its availability.

Change-Id: I5b6e88729d0571d5ffb43c26d5c4f2788a05f4c2
Reviewed-on: https://chromium-review.googlesource.com/667818
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Xiaochu Liu <xiaochu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502037}
[modify] https://crrev.com/76d7d0e9cd8bb2a9a24b778f42895ebb162580ea/chrome/browser/BUILD.gn
[modify] https://crrev.com/76d7d0e9cd8bb2a9a24b778f42895ebb162580ea/chrome/browser/component_updater/cros_component_installer.cc
[modify] https://crrev.com/76d7d0e9cd8bb2a9a24b778f42895ebb162580ea/chrome/browser/component_updater/cros_component_installer.h

Comment 2 by xiaochu@chromium.org, Sep 14 2017

Status: Fixed (was: Assigned)

Comment 3 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 4 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)
►

Sign in to add a comment