New issue
Advanced search Search tips

Issue 755155 link

Starred by 1 user
Status: WontFix
Owner: ----
Closed: Sep 24
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Extract code related to wpt manifest to wpt_manifest.py.

Project Member Reported by qyears...@chromium.org, Aug 14 2017 
Specifically, there is currently some duplicated code in port/base.py that involves reading and updating the wpt manifest, which logically probably belongs in wpt_manifest.py.

https://cs.chromium.org/search/?q=manifest.json+webkitpy
Project Member

Comment 1 by sheriffbot@chromium.org, Aug 14

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 2 by foolip@chromium.org, Sep 24

Status: WontFix (was: Untriaged)
There's still manifest-related code in port/base.py:
https://cs.chromium.org/chromium/src/third_party/blink/tools/blinkpy/web_tests/port/base.py?l=52&rcl=99774c50cd7c63b45b8c3d6abb750f4b8a33a7b0

However, it imports wpt_manifest.py and to my eye doesn't do anything too inappropriate that would be much more fitting in port/base.py.
►

Sign in to add a comment