Story disable seems to work incorrectly on Android One |
||||
Issue descriptionIn https://chromium-review.googlesource.com/c/612503, I disabled structured-clone-long-string-deserialize.html and structured-clone-long-string-serialize.html in the blink_perf.bindings benchmark on ALL_ANDROID. The CL landed August 11. This seems to have greened up the bots except for Android One, see this build from August 13: https://uberchromegw.corp.google.com/i/chromium.perf/builders/Android%20One%20Perf/builds/392 Unexpected Failures: * blink_perf.bindings/structured-clone-json-deserialize.html * blink_perf.bindings/structured-clone-json-serialize.html Randy, can you take a look?
,
Aug 14 2017
That disabling condition literally just tests that android is in the OS name.. it is being passed --browser=android-chromium as the browser name so it seems very strange that this isn't working. I'm wondering if I'll add some logging to investigate.
,
Aug 14 2017
Bah. bad in place edits. I'm wondering if should be ignored in that sentence.
,
Aug 14 2017
Ahhah. I have discovered what is going on. The name of the two tests that were disabled in blink_perf.bindings were: structured-clone-long-string-deserialize.html structured-clone-long-string-serialize.html The names of the two failing tests for a1 are: structured-clone-json-deserialize.html structured-clone-json-serialize.html Everything is working fine, just a case of mistaken identity. I'll get a CL out to disable these. Let me know if you think this analysis is wrong.
,
Aug 14 2017
,
Aug 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9e850c1815a77040039130efced673f7475ec00b commit 9e850c1815a77040039130efced673f7475ec00b Author: rnephew <rnephew@chromium.org> Date: Mon Aug 14 23:30:00 2017 [Telemetry] Disable failing blink_perf.bindings tests on Android One. Bug: 755137 ,733655 Change-Id: I348d96f240c640b7d5f74ba1dc19b2cdbe9e721b Reviewed-on: https://chromium-review.googlesource.com/614611 Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: rnephew <rnephew@chromium.org> Cr-Commit-Position: refs/heads/master@{#494243} [modify] https://crrev.com/9e850c1815a77040039130efced673f7475ec00b/tools/perf/benchmarks/blink_perf.py
,
Aug 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1ac9ff818032c4f06a3fcba7e0c826293abc9eca commit 1ac9ff818032c4f06a3fcba7e0c826293abc9eca Author: Ulan Degenbaev <ulan@chromium.org> Date: Thu Aug 17 20:53:00 2017 [Telemetry] Enable failing blink_perf.bindings tests on Android One. This reverts commit 9e850c1815a77040039130efced673f7475ec00b. Reason for revert: a fix landed in chromium. Original change's description: > [Telemetry] Disable failing blink_perf.bindings tests on Android One. > > Bug: 755137 ,733655 > Change-Id: I348d96f240c640b7d5f74ba1dc19b2cdbe9e721b > Reviewed-on: https://chromium-review.googlesource.com/614611 > Reviewed-by: Ned Nguyen <nednguyen@google.com> > Commit-Queue: rnephew <rnephew@chromium.org> > Cr-Commit-Position: refs/heads/master@{#494243} Bug: 755137 , 733655 Change-Id: I583325b8350e5ccdd7cced5edfd12635b7d38dca Reviewed-on: https://chromium-review.googlesource.com/619190 Reviewed-by: rnephew <rnephew@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#495314} [modify] https://crrev.com/1ac9ff818032c4f06a3fcba7e0c826293abc9eca/tools/perf/benchmarks/blink_perf.py
,
Jan 16
,
Jan 16
|
||||
►
Sign in to add a comment |
||||
Comment 1 by nedngu...@google.com
, Aug 14 2017