SafeBrowsingUIManagerTest.Whitelist* flakily leaks |
||||||||||
Issue descriptionVarious tests in SafeBrowsingUIManagerTest sometimes leak memory, causing failures on "Linux ASan LSan Tests (1)" and in the CQ. I've seen the following tests fail: .Whitelist .WhitelistIgnoresPath .WhitelistIgnoresSitesNotAdded .WhitelistRemembersThreatType First failure, from August 11: https://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/37927 List of builds from the ASan LSan bot: https://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29?numbuilds=200 CCing OWNERS, since I couldn't find a recent change that looks related.
,
Aug 14 2017
I'm disabling the leaky tests on LSan: https://chromium-review.googlesource.com/c/613165
,
Aug 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3d26e9293b5bc4503b8af4af335b5dce8ae70127 commit 3d26e9293b5bc4503b8af4af335b5dce8ae70127 Author: Marc Treib <treib@chromium.org> Date: Mon Aug 14 16:58:26 2017 Disable leaky SafeBrowsingUIManagerTest.Whitelist* on LSan TBR=jialiul@chromium.org Bug: 755118 Change-Id: Ia919fe8edd8effb3fff6d92905e326321af941ce Reviewed-on: https://chromium-review.googlesource.com/613165 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#494075} [modify] https://crrev.com/3d26e9293b5bc4503b8af4af335b5dce8ae70127/chrome/browser/safe_browsing/ui_manager_unittest.cc
,
Aug 14 2017
Taking out of the sheriff queue as the offending tests have been disabled.
,
Aug 14 2017
(To be clear these were disabled for leak detection, but they're still run for correctness.) The leaks all look related to SafeBrowsingDatabaseFactoryImpl::CreateSafeBrowsingDatabase() This is unlikely to cause progressive leaks within production code, but we should fix it and renable the test.
,
Aug 15 2017
,
Aug 18 2017
This only leaks in the that test, but the "leaking" code is run in other tests so it's probably an issue with this test fixture.
,
Aug 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/199c013b4cae899bcd7dd22f563fb8d399e8bdda commit 199c013b4cae899bcd7dd22f563fb8d399e8bdda Author: Evgenii Stepanov <eugenis@google.com> Date: Fri Aug 18 21:19:41 2017 Disable the rest of SafeBrowsingUIManagerTest under LSan. Flaky leak reports on this bot: https://build.chromium.org/p/chromium.fyi/builders/ClangToTLinuxASan%20tester BUG=755118 TBR=jialiul@chromium.org, treib@chromium.org Change-Id: I200d3e709a2a6ad601dd1b037cd24fb36919b8f4 Reviewed-on: https://chromium-review.googlesource.com/619855 Reviewed-by: Evgeniy Stepanov <eugenis@chromium.org> Cr-Commit-Position: refs/heads/master@{#495688} [modify] https://crrev.com/199c013b4cae899bcd7dd22f563fb8d399e8bdda/chrome/browser/safe_browsing/ui_manager_unittest.cc
,
Nov 10 2017
,
Jan 24 2018
,
Jan 24 2018
,
Feb 18 2018
,
Mar 20 2018
These tests have been disabled since aug, should they just get deleted if there isn't a fix?
,
Mar 30 2018
Theses tests are still run, for correctness. |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by treib@chromium.org
, Aug 14 2017