Collected cookies dialog has wrong position on MacViews
Reported by
jongkwon...@navercorp.com,
Aug 14 2017
|
||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3164.0 Safari/537.36 Steps to reproduce the problem: 1. build chromium with mac_views_browser=1 2. Site Info -> "Cookies: n from this site" link What is the expected behavior? Collected cookies dialog show up at the center of the browser. What went wrong? Collected cookies dialog show up at the bottom left of the browser and it has no shadow. Did this work before? N/A Chrome version: 62.0.3164.0 Channel: n/a OS Version: OS X 10.12.6 Flash Version:
,
Aug 16 2017
,
Aug 17 2017
It's a side-effect of https://crrev.com/68757f797cf6d990699503d1a47be59b42e109dc I'm preparing a patch.
,
Aug 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/283860a79ee8973745c227f82f8ff00a83573f5b commit 283860a79ee8973745c227f82f8ff00a83573f5b Author: jongkwon.lee <jongkwon.lee@navercorp.com> Date: Tue Aug 22 07:58:10 2017 Fix ReparentNativeView() for top level widgets ReparentNativeView() for top level widgets should be different to the one for control type widgets on Mac. Re-parent the NativeWindow of a widget if it is a top level widget, while re-parent the NativeView of a widget it it is a control widget. Bug: 755102 Change-Id: Id9de473765807a11c787e4e51994b6cb5c13ddee Reviewed-on: https://chromium-review.googlesource.com/620294 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#496243} [modify] https://crrev.com/283860a79ee8973745c227f82f8ff00a83573f5b/ui/views/cocoa/bridged_native_widget.h [modify] https://crrev.com/283860a79ee8973745c227f82f8ff00a83573f5b/ui/views/cocoa/bridged_native_widget.mm [modify] https://crrev.com/283860a79ee8973745c227f82f8ff00a83573f5b/ui/views/widget/native_widget_mac.mm [modify] https://crrev.com/283860a79ee8973745c227f82f8ff00a83573f5b/ui/views/widget/native_widget_mac_unittest.mm
,
Aug 23 2017
Thanks for the fix! |
||
►
Sign in to add a comment |
||
Comment 1 by sdy@chromium.org
, Aug 14 2017Labels: Proj-MacViews MacViews-Browser