Regression: Blue status load bar should appear and the page should load in no time |
|||||||||
Issue descriptionChrome Version: 62.0.3185.0 OS:Ubuntu 14.04 Windows What steps will reproduce the problem? (1)Launch chrome>> Add new person (2)Navigate to http://cb.vu/unixtoolbox.pdf Expected Blue status load bar should appear as soon as you hit the link and it should not take time to load the page Actual Blue status load bar does not appear as soon as you hit the link and it takes few seconds to load the page This is a Regression issue broken in M-62
,
Aug 14 2017
,
Aug 14 2017
Able to reproduce this issue on Ubuntu 14.04 using chrome latest dev #62.0.3185.0.
,
Aug 14 2017
Below is the Manual Bisect info Good Build: 62.0.3167.0 Bad Build: 62.0.3168.0
,
Aug 14 2017
,
Aug 14 2017
Using the per-revision bisect providing the bisect results, You are probably looking for a change made after 489754 (known good), but no later than 489755 CHANGELOG URL: ============ https://chromium.googlesource.com/chromium/src/+log/46a392696be217f10cbe1864f3173df5651bc301..9a6d1487991b9824b499aff0ce1c9b68834a14cd From the CL above, assigning the issue to the concern owner Unable to add the Author as Owner, hence assigning this issue to Reviewer. @dsinclair: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner. Thanks!!
,
Aug 14 2017
Able to reproduce this issue on Mac OS 10.12.6 using chrome latest #62.0.3185.0. Adding RB-Stable since this is a recent regression, please feel free to edit if this is not the case. Thanks!
,
Aug 14 2017
Submitted a revert cl: https://chromium-review.googlesource.com/c/614590
,
Aug 15 2017
The revert was landed last night so this should now be fixed. (Landed as 07a72bda87d95cfaa4ba13e362195c76b831e1f2)
,
Sep 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/af1b4342b81d3058d635920ec49219028b3fa220 commit af1b4342b81d3058d635920ec49219028b3fa220 Author: Artem Strygin <art-snake@yandex-team.ru> Date: Tue Sep 12 18:48:24 2017 Reland of Improve linearized pdf load/show time." Use received bytes count as the value for progress, not chunks count. Reason for reland: The fix of revert reason has been added. Bug: 755061 Original change's description: > Revert "Reland of Improve linearized pdf load/show time." > > This reverts commit 9a6d1487991b9824b499aff0ce1c9b68834a14cd. > > Reason for revert: https://crbug.com/755061 . This appears to be > causing a serious regression in loading. The loading bar does not > appear as expected and appears all at once at the end as the screen > displays. There is 5-6seconds of nothing happening which makes it look > like the browser has stopped working. > > > Original change's description: > > Reland of Improve linearized pdf load/show time. > > > > XFA forms loading has been fixed. > > Now for document with single non XFA page, the form load first. > > This is necessary for correct loading pages, because in XFA document > > the page count and them contents may be changed after loading form. > > > > See > > https://codereview.chromium.org/2558573002/ > > > > For test this: > > build chromium pdf with XFA support > > and open any document from > > https://www.idrsolutions.com/jpdfforms/xfa-html5-example-conversions/ > > > > Original CL: > > https://codereview.chromium.org/2455403002/ > > > > Original description: > > Improve linearized pdf load/show time. > > Reduce Pdf Plugin's count of reconnects. > > Add tests for PDFPlugin DocumentLoader. > > > > DocumentLoader was splitted into separate components, and missing tests was added for them. > > > > The main ideas in this CL are: > > > > 1) Do not reset browser initiated connection at start (includes case when we can use range requests), if we request data near current downloading position. > > 2) Request as much data as we can on each request, and continue loading data using current range request. (like tape rewind) > > 3) Isolate RangeRequest logic into DocumentLoader. Method OnPendingRequestComplete is called, when we receive requested data (main connection, or Range connection). (like tape playing without rewing). > > 4) Fill this logic by tests. > > > > Example URL: > > http://www.major-landrover.ru/upload/attachments/f/9/f96aab07dab04ae89c8a509ec1ef2b31.pdf > > Comparison of changes: > > https://drive.google.com/file/d/0BzWfMBOuik2QNGg0SG93Y3lpUlE/view?usp=sharing > > > > Change-Id: I97bb25d2e82bcb4ba2e060af8128f49b9c0680d9 > > Reviewed-on: https://chromium-review.googlesource.com/581292 > > Reviewed-by: Robert Sesek <rsesek@chromium.org> > > Reviewed-by: Dan Sinclair <dsinclair@chromium.org> > > Commit-Queue: Art Snake <art-snake@yandex-team.ru> > > Cr-Commit-Position: refs/heads/master@{#489755} > > TBR=rsesek@chromium.org Change-Id: I78e10565f639c26faae29b3cf854419208af8665 Reviewed-on: https://chromium-review.googlesource.com/615302 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by: (000 09-08 - 09-18) dsinclair <dsinclair@chromium.org> Cr-Commit-Position: refs/heads/master@{#501344} [modify] https://crrev.com/af1b4342b81d3058d635920ec49219028b3fa220/pdf/BUILD.gn [modify] https://crrev.com/af1b4342b81d3058d635920ec49219028b3fa220/pdf/DEPS [delete] https://crrev.com/fdaaebe87184d49b49de78b006ea79ef49f14afd/pdf/chunk_stream.cc [modify] https://crrev.com/af1b4342b81d3058d635920ec49219028b3fa220/pdf/chunk_stream.h [modify] https://crrev.com/af1b4342b81d3058d635920ec49219028b3fa220/pdf/chunk_stream_unittest.cc [modify] https://crrev.com/af1b4342b81d3058d635920ec49219028b3fa220/pdf/document_loader.cc [modify] https://crrev.com/af1b4342b81d3058d635920ec49219028b3fa220/pdf/document_loader.h [add] https://crrev.com/af1b4342b81d3058d635920ec49219028b3fa220/pdf/document_loader_unittest.cc [modify] https://crrev.com/af1b4342b81d3058d635920ec49219028b3fa220/pdf/out_of_process_instance.cc [modify] https://crrev.com/af1b4342b81d3058d635920ec49219028b3fa220/pdf/out_of_process_instance.h [modify] https://crrev.com/af1b4342b81d3058d635920ec49219028b3fa220/pdf/pdf_engine.h [modify] https://crrev.com/af1b4342b81d3058d635920ec49219028b3fa220/pdf/pdfium/pdfium_engine.cc [modify] https://crrev.com/af1b4342b81d3058d635920ec49219028b3fa220/pdf/pdfium/pdfium_engine.h [modify] https://crrev.com/af1b4342b81d3058d635920ec49219028b3fa220/pdf/preview_mode_client.cc [modify] https://crrev.com/af1b4342b81d3058d635920ec49219028b3fa220/pdf/preview_mode_client.h [add] https://crrev.com/af1b4342b81d3058d635920ec49219028b3fa220/pdf/range_set.cc [add] https://crrev.com/af1b4342b81d3058d635920ec49219028b3fa220/pdf/range_set.h [add] https://crrev.com/af1b4342b81d3058d635920ec49219028b3fa220/pdf/range_set_unittest.cc [add] https://crrev.com/af1b4342b81d3058d635920ec49219028b3fa220/pdf/timer.cc [add] https://crrev.com/af1b4342b81d3058d635920ec49219028b3fa220/pdf/timer.h [add] https://crrev.com/af1b4342b81d3058d635920ec49219028b3fa220/pdf/url_loader_wrapper.h [add] https://crrev.com/af1b4342b81d3058d635920ec49219028b3fa220/pdf/url_loader_wrapper_impl.cc [add] https://crrev.com/af1b4342b81d3058d635920ec49219028b3fa220/pdf/url_loader_wrapper_impl.h |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by divya.pa...@techmahindra.com
, Aug 14 20171.3 MB
1.3 MB View Download