New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 755024 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug



Sign in to add a comment

CHECK failure: !exception.IsEmpty() in V8ScriptRunner.cpp

Project Member Reported by ClusterFuzz, Aug 13 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5095620397498368

Fuzzer: inferno_twister_c
Job Type: linux_asan_content_shell_drt
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  !exception.IsEmpty() in V8ScriptRunner.cpp
  blink::V8ScriptRunner::ThrowException
  blink::V8ScriptRunner::ReportExceptionForModule
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_content_shell_drt&range=482161:482264

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5095620397498368

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Aug 13 2017

Labels: OS-Windows
Cc: msrchandra@chromium.org
Components: Blink>Bindings
Labels: Test-Predator-Wrong-CLs M-61
Owner: kouhei@chromium.org
Status: Assigned (was: Untriaged)
Predator and CL could not provide any possible suspects.
Using Code Search for the file, "V8ScriptRunner.cpp" assigning to concern owner.

Suspecting Commit#
https://chromium.googlesource.com/chromium/src/+/73bb506d40e7618c72d23bb949fc37928ea68f21

@kouhei -- Could you please look into the issue, kindly re-assign if this is not related to your changes.
Thank You.

Comment 3 by kouhei@chromium.org, Aug 14 2017

Components: Blink>HTML>Script
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/62653ce9524ad66e965a2011b6306319fa72ef9a

commit 62653ce9524ad66e965a2011b6306319fa72ef9a
Author: Kouhei Ueno <kouhei@chromium.org>
Date: Thu Aug 17 00:04:41 2017

[ES6 modules] Add missing TraceWrapper graph for ScriptRunner

Before this CL, ScriptRunner was not TraceWrappered, thus ScriptLoaders held by ScriptRunner was not wrapper traced.
This CL makes ScriptRunner a TraceWrapperBase, and ensure ScriptLoaders held are wrapper traced.

Bug:  755024 
Change-Id: I3aaccb92afada28951380eea69003ba85579fe9e
Reviewed-on: https://chromium-review.googlesource.com/616524
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495005}
[modify] https://crrev.com/62653ce9524ad66e965a2011b6306319fa72ef9a/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/62653ce9524ad66e965a2011b6306319fa72ef9a/third_party/WebKit/Source/core/dom/Document.h
[modify] https://crrev.com/62653ce9524ad66e965a2011b6306319fa72ef9a/third_party/WebKit/Source/core/dom/ModuleScript.h
[modify] https://crrev.com/62653ce9524ad66e965a2011b6306319fa72ef9a/third_party/WebKit/Source/core/dom/ScriptRunner.cpp
[modify] https://crrev.com/62653ce9524ad66e965a2011b6306319fa72ef9a/third_party/WebKit/Source/core/dom/ScriptRunner.h

Project Member

Comment 5 by ClusterFuzz, Aug 17 2017

ClusterFuzz has detected this issue as fixed in range 494974:495051.

Detailed report: https://clusterfuzz.com/testcase?key=5095620397498368

Fuzzer: inferno_twister_c
Job Type: linux_asan_content_shell_drt
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  !exception.IsEmpty() in V8ScriptRunner.cpp
  blink::V8ScriptRunner::ThrowException
  blink::V8ScriptRunner::ReportExceptionForModule
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_content_shell_drt&range=482161:482264
Fixed: https://clusterfuzz.com/revisions?job=linux_asan_content_shell_drt&range=494974:495051

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5095620397498368

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 6 by ClusterFuzz, Aug 17 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5095620397498368 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Comment 7 by kouhei@chromium.org, Aug 21 2017

Status: Fixed (was: Verified)

Comment 8 by kouhei@chromium.org, Aug 21 2017

Labels: Merge-Request-61
Status: Available (was: Fixed)
Project Member

Comment 9 by sheriffbot@chromium.org, Aug 21 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: M61 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: hablich@chromium.org
+hablich@ for M61 merge review.
I might need to create a different patch for M61, as the WrapperTrace infrastructure has changed since M61. It will basically introduce the same ref graph, but automatic rebase will not work.
@govind: This is a Blink not a V8 patch. 

yeah, sorry.

kouhei@, per comment #11, you're planning to create a different patch for M61. Please update this bug once change is ready, baked/verified in Canary and safe to merge to M61. 

Please note We're only few weeks away from M61 Stable promotion, so merge bar is very high. We're only taking critical merges in.
If crash rate isn't super high, I think it makes sense to pass M61.
The M62 change is baked, but as described in c#11, we need to create completely different change for M61 fix, as the affected code diverged.
Cc: pbomm...@chromium.org
Based on the clusterfuzz report I checked the crash server and found that there is just 1 crash on Desktop Stable i.e., 60.0.3112.90, Please find details here : https://goto.google.com/uvyzc


Note : I am not 100% sure if this is just one magic stack where this crash would be seen. 
Would you mind checking on M61, as the bug was introduced in M61?
I tried to identify all the crashes which has the magic stack as "blink::V8ScriptRunner::" below you can find the categorization of crashes on M61 and over all Chrome versions :

Crashes on 61 : https://goto.google.com/xuvql 

Crashes on historical Chrome versions : https://goto.google.com/upddx

Note : As mentioned in comment#16, I am still not 100% sure unless someone with more insights confirm that the data in Comment#16 and this comment looks relevant.



Labels: -Merge-Review-61 Merge-Rejected-61
Rejecting merge to M61 branch 3163 based on comment #19.
Status: Fixed (was: Available)
Fixed in M62+ and M61 merge rejected per c#20 -> marking bug as fixed

Sign in to add a comment