Use UIElement* as an input argument instead of node_id in UIDevToolsCSSAgent methods. |
|||
Issue descriptionIn UIDevToolsCSSAgent, functions OnNodeBoundsChanged(), GetPropertiesForNodeId(), SetPropertiesForNodeId(), and BuildCSSStyle() can take direct input as UIElement* instead of converting node_id back to UIElement*.
,
Aug 13 2017
,
Aug 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/740ecd455530031858f6af6443da0e59793d8723 commit 740ecd455530031858f6af6443da0e59793d8723 Author: Thanh Pham <thanhph@chromium.org> Date: Mon Aug 14 20:28:54 2017 Use UIElement* as an input argument instead of node_id in UIDevToolsCSSAgent methods. In UIDevToolsCSSAgent, functions OnNodeBoundsChanged(), GetPropertiesForNodeId(), SetPropertiesForNodeId(), and BuildCSSStyle() can take direct input as UIElement* instead of converting node_id back to UIElement*. Bug: 755019 Change-Id: Ib084e433b64766962eabe4c9b5d6b77a7c7c8fb3 Reviewed-on: https://chromium-review.googlesource.com/612846 Commit-Queue: Thanh Pham <thanhph@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#494168} [modify] https://crrev.com/740ecd455530031858f6af6443da0e59793d8723/components/ui_devtools/views/ui_devtools_css_agent.cc [modify] https://crrev.com/740ecd455530031858f6af6443da0e59793d8723/components/ui_devtools/views/ui_devtools_css_agent.h [modify] https://crrev.com/740ecd455530031858f6af6443da0e59793d8723/components/ui_devtools/views/ui_devtools_dom_agent.cc [modify] https://crrev.com/740ecd455530031858f6af6443da0e59793d8723/components/ui_devtools/views/ui_devtools_dom_agent.h
,
Aug 14 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 Deleted