New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 755019 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Use UIElement* as an input argument instead of node_id in UIDevToolsCSSAgent methods.

Project Member Reported by thanhph@chromium.org, Aug 13 2017

Issue description

In UIDevToolsCSSAgent, functions OnNodeBoundsChanged(), GetPropertiesForNodeId(), SetPropertiesForNodeId(), and BuildCSSStyle() can take direct input as UIElement* instead of converting node_id back to UIElement*. 
 

Comment 1 Deleted

Comment 2 Deleted

Status: Started (was: Available)

Comment 4 Deleted

Comment 5 Deleted

Project Member

Comment 6 by bugdroid1@chromium.org, Aug 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/740ecd455530031858f6af6443da0e59793d8723

commit 740ecd455530031858f6af6443da0e59793d8723
Author: Thanh Pham <thanhph@chromium.org>
Date: Mon Aug 14 20:28:54 2017

Use UIElement* as an input argument instead of node_id in
UIDevToolsCSSAgent methods.

In UIDevToolsCSSAgent, functions OnNodeBoundsChanged(),
GetPropertiesForNodeId(), SetPropertiesForNodeId(), and BuildCSSStyle()
can take direct input as UIElement* instead of converting node_id back
to UIElement*.

Bug:  755019 
Change-Id: Ib084e433b64766962eabe4c9b5d6b77a7c7c8fb3
Reviewed-on: https://chromium-review.googlesource.com/612846
Commit-Queue: Thanh Pham <thanhph@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494168}
[modify] https://crrev.com/740ecd455530031858f6af6443da0e59793d8723/components/ui_devtools/views/ui_devtools_css_agent.cc
[modify] https://crrev.com/740ecd455530031858f6af6443da0e59793d8723/components/ui_devtools/views/ui_devtools_css_agent.h
[modify] https://crrev.com/740ecd455530031858f6af6443da0e59793d8723/components/ui_devtools/views/ui_devtools_dom_agent.cc
[modify] https://crrev.com/740ecd455530031858f6af6443da0e59793d8723/components/ui_devtools/views/ui_devtools_dom_agent.h

Status: Fixed (was: Started)

Sign in to add a comment