New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 754986 link

Starred by 3 users
Status: Fixed
Owner:
█ hubbe@chromium.org
Last visit > 30 days ago
Closed: Sep 21
Cc:
m...@chromium.org
ccameron@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Duplicate ColorSpace properties in media::VideoFrame

Project Member Reported by m...@chromium.org, Aug 12 2017 
Commits f864d5f2f4859 and af57af3079ddb added two methods to media::VideoFrame: A ColorSpace() and a set_color_space() method. However, this metadata was already provided in VideoFrameMetadata (under the COLOR_SPACE key), and has many referents.

We need to remove one of the duplicates, and update client code. If the color space is a mandatory attribute of VideoFrames, then it should probably be a property in the VideoFrame class. If it is optional (or only mandatory in some situations), then it should probably be in VideoFrameMetadata.

In addition, this new property should be reflected in the mojo struct traits for VideoFrame (src/media/mojo/interfaces/video_frame_struct_traits.*), if the decision is to put it in the VideoFrame class.

Comment 1 by m...@chromium.org, Aug 12 2017

Cc: m...@chromium.org

Comment 2 by ccameron@chromium.org, Aug 13 2017 

The plans is to get rid of media::VideoFrameMetadata::COLOR_SPACE and always use VideoFrame::ColorSpace().

A slight subtlety that I want to clarify here: A color space is not always specified by the video stream, and in these cases we leave the VideoFrame::ColorSpace as the default-ctor (invalid) color space (see [A], [B], [C]).

We should decide what to do about this situation. IMO we should assign a default color space to the VideoFrame at this point so that all consumers will behave the same way (so that there is no undefined behavior).

At the moment there is a TODO in [A] but not for [B] and [C].

See also comment at [D] and too-soon-for-its-time-patch at [E].

[A] https://cs.chromium.org/chromium/src/media/filters/vpx_video_decoder.cc?rcl=cb78bb60019357234b307b84f4e5bdbe45892557&l=791
[B] https://cs.chromium.org/chromium/src/media/filters/ffmpeg_video_decoder.cc?rcl=cb78bb60019357234b307b84f4e5bdbe45892557&l=187
[C] https://cs.chromium.org/chromium/src/media/filters/decrypting_video_decoder.cc?rcl=cb78bb60019357234b307b84f4e5bdbe45892557&l=282
[D] https://cs.chromium.org/chromium/src/components/viz/service/display/gl_renderer.cc?rcl=cb78bb60019357234b307b84f4e5bdbe45892557&l=2121
[E] https://codereview.chromium.org/2773103002/
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 17 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6671625ce92c8cdfe546cf2162f18c43a44fd95a

commit 6671625ce92c8cdfe546cf2162f18c43a44fd95a
Author: Fredrik Hubinette <hubbe@google.com>
Date: Wed Jan 17 03:37:20 2018

update video decoder shim to gfx::ColorSpace

Bug:  754986 
Change-Id: I73ad36dff7cb8387517524e6498675de98652da5
Reviewed-on: https://chromium-review.googlesource.com/865455
Reviewed-by: ccameron <ccameron@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Commit-Queue: Fredrik Hubinette <hubbe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529577}
[modify] https://crrev.com/6671625ce92c8cdfe546cf2162f18c43a44fd95a/content/renderer/pepper/video_decoder_shim.cc
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 30 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/22d144fd9c67945e326c756aa6ff06f77b66c9c6

commit 22d144fd9c67945e326c756aa6ff06f77b66c9c6
Author: Fredrik Hubinette <hubbe@google.com>
Date: Tue Jan 30 19:22:42 2018

re-encode and tag counting.mp4 with colorspace information.

Bug:  754986 
Change-Id: Id9b981552b78c59629d2b720717c1ec6e8e4b8a4
Reviewed-on: https://chromium-review.googlesource.com/891650
Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: Fredrik Hubinette <hubbe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532986}
[modify] https://crrev.com/22d144fd9c67945e326c756aa6ff06f77b66c9c6/third_party/WebKit/LayoutTests/media/content/counting.mp4
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 31 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/164d44a593df3f7edffcfe8bcf54dcf93ca6d266

commit 164d44a593df3f7edffcfe8bcf54dcf93ca6d266
Author: Robert Liao <robliao@chromium.org>
Date: Wed Jan 31 19:10:14 2018

Revert "update video decoder shim to gfx::ColorSpace"

This reverts commit 6671625ce92c8cdfe546cf2162f18c43a44fd95a.

Reason for revert: This breaks Chrome Remote Desktop as determined by a per-revision bisect ( http://crbug.com/804433 ).

Original change's description:
> update video decoder shim to gfx::ColorSpace
>
> Bug:  754986 
> Change-Id: I73ad36dff7cb8387517524e6498675de98652da5
> Reviewed-on: https://chromium-review.googlesource.com/865455
> Reviewed-by: ccameron <ccameron@chromium.org>
> Reviewed-by: Bill Budge <bbudge@chromium.org>
> Commit-Queue: Fredrik Hubinette <hubbe@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#529577}

TBR=bbudge@chromium.org,ccameron@chromium.org,hubbe@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  754986 ,  804433 
Change-Id: I95886998fea6cf1c2b1a9c3380a5fef00be898f3
Reviewed-on: https://chromium-review.googlesource.com/895863
Commit-Queue: Robert Liao <robliao@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533350}
[modify] https://crrev.com/164d44a593df3f7edffcfe8bcf54dcf93ca6d266/content/renderer/pepper/video_decoder_shim.cc
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 9 2018

Labels: merge-merged-3325
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/52e9cce253e70aa687979052f18223a9990d25aa

commit 52e9cce253e70aa687979052f18223a9990d25aa
Author: Robert Liao <robliao@chromium.org>
Date: Fri Feb 09 22:08:26 2018

Revert "update video decoder shim to gfx::ColorSpace"

This reverts commit 6671625ce92c8cdfe546cf2162f18c43a44fd95a.

Reason for revert: This breaks Chrome Remote Desktop as determined by a per-revision bisect ( http://crbug.com/804433 ).

Original change's description:
> update video decoder shim to gfx::ColorSpace
>
> Bug:  754986 
> Change-Id: I73ad36dff7cb8387517524e6498675de98652da5
> Reviewed-on: https://chromium-review.googlesource.com/865455
> Reviewed-by: ccameron <ccameron@chromium.org>
> Reviewed-by: Bill Budge <bbudge@chromium.org>
> Commit-Queue: Fredrik Hubinette <hubbe@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#529577}

TBR=bbudge@chromium.org,ccameron@chromium.org,hubbe@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  754986 ,  804433 
Change-Id: I95886998fea6cf1c2b1a9c3380a5fef00be898f3
Reviewed-on: https://chromium-review.googlesource.com/895863
Commit-Queue: Robert Liao <robliao@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#533350}(cherry picked from commit 164d44a593df3f7edffcfe8bcf54dcf93ca6d266)
Reviewed-on: https://chromium-review.googlesource.com/911850
Cr-Commit-Position: refs/branch-heads/3325@{#415}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/52e9cce253e70aa687979052f18223a9990d25aa/content/renderer/pepper/video_decoder_shim.cc
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5

commit f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5
Author: Fredrik Hubinette <hubbe@google.com>
Date: Fri Mar 23 22:51:16 2018

VP8 color space fix

VP8 has no color space information apart from full range / limited range.
However, because of a comment in the VP8 spec that says that vp8 content
is "like bt601", ffmpeg sets the matrix to SMPTE470BG. When we assign the
color space to the video frame we default the other parameters to BT709,
leading to a color space like:

  { primaries=BT709, transfer=BT709, matrix=SMPTE470BG, range=Limited }

This mix of color spaces is is clearly wrong. This fix works around the
ffmpeg behavior and leaves the color space completely unset when this
happens. Unset color spaces defaults to BT709 later on, which is probably
what we weant.

Full-range content gets a JPEG color space.

Bug:  754986 
Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I04694e949d211b134312ade01555fa1954a82bad
Reviewed-on: https://chromium-review.googlesource.com/912436
Commit-Queue: Fredrik Hubinette <hubbe@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545603}
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/media/filters/ffmpeg_video_decoder.cc
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/cf1b5ae213001436b8dd0923e6b8d5358babba33/third_party/WebKit/LayoutTests/compositing/video/video-reflection-expected.png
[delete] https://crrev.com/cf1b5ae213001436b8dd0923e6b8d5358babba33/third_party/WebKit/LayoutTests/hdr/color-profile-video-expected.png
[delete] https://crrev.com/cf1b5ae213001436b8dd0923e6b8d5358babba33/third_party/WebKit/LayoutTests/hdr/video-canvas-alpha-expected.png
[delete] https://crrev.com/cf1b5ae213001436b8dd0923e6b8d5358babba33/third_party/WebKit/LayoutTests/media/color-profile-video-expected.png
[delete] https://crrev.com/cf1b5ae213001436b8dd0923e6b8d5358babba33/third_party/WebKit/LayoutTests/media/color-profile-video-seek-expected.png
[delete] https://crrev.com/cf1b5ae213001436b8dd0923e6b8d5358babba33/third_party/WebKit/LayoutTests/media/color-profile-video-seek-filter-expected.png
[delete] https://crrev.com/cf1b5ae213001436b8dd0923e6b8d5358babba33/third_party/WebKit/LayoutTests/media/color-profile-video-seek-object-fit-expected.png
[delete] https://crrev.com/cf1b5ae213001436b8dd0923e6b8d5358babba33/third_party/WebKit/LayoutTests/media/video-canvas-alpha-expected.png
[delete] https://crrev.com/cf1b5ae213001436b8dd0923e6b8d5358babba33/third_party/WebKit/LayoutTests/media/video-remove-insert-repaints-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/linux/compositing/video-frame-size-change-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/linux/fast/borders/border-radius-mask-video-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/linux/fast/borders/border-radius-mask-video-ratio-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/linux/fast/borders/border-radius-mask-video-shadow-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/linux/hdr/video-canvas-alpha-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/linux/media/controls-after-reload-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/linux/media/controls-strict-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/linux/media/controls-styling-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/linux/media/controls-styling-strict-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/linux/media/controls-without-preload-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/linux/media/controls/video-controls-with-cast-rendering-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/linux/media/controls/video-overlay-cast-dark-rendering-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/linux/media/track/track-cue-rendering-horizontal-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/linux/media/track/track-cue-rendering-vertical-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/linux/media/video-aspect-ratio-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/linux/media/video-canvas-alpha-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/linux/media/video-controls-rendering-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/linux/media/video-display-toggle-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/linux/media/video-layer-crash-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/linux/media/video-replaces-poster-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/linux/media/video-transformed-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/linux/media/video-zoom-controls-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/linux/media/video-zoom-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/linux/virtual/android/fullscreen/full-screen-iframe-allowed-video-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/linux/virtual/android/fullscreen/video-controls-timeline-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/linux/virtual/android/fullscreen/video-scrolled-iframe-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spv175/compositing/video-frame-size-change-expected.png
[add] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spv175/fast/borders/border-radius-mask-video-expected.png
[add] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spv175/fast/borders/border-radius-mask-video-ratio-expected.png
[add] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spv175/fast/borders/border-radius-mask-video-shadow-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/video-controls-with-cast-rendering-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/video-overlay-cast-dark-rendering-expected.png
[add] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/mac-mac10.10/media/controls/lazy-loaded-style-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/mac-mac10.10/media/track/track-cue-rendering-vertical-expected.png
[add] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/new-remote-playback-pipeline/media/controls/lazy-loaded-style-expected.png
[copy] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/mac-mac10.11/media/controls/lazy-loaded-style-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/mac-mac10.11/media/track/track-cue-rendering-vertical-expected.png
[rename] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/new-remote-playback-pipeline/media/controls/lazy-loaded-style-expected.png
[add] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/controls/lazy-loaded-style-expected.png
[copy] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/controls/lazy-loaded-style-expected.txt
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/track/track-cue-rendering-horizontal-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/video-zoom-controls-expected.png
[add] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/new-remote-playback-pipeline/media/controls/lazy-loaded-style-expected.png
[rename] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/new-remote-playback-pipeline/media/controls/lazy-loaded-style-expected.txt
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/mac/compositing/video-frame-size-change-expected.png
[add] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/mac/compositing/video/video-reflection-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/mac/fast/borders/border-radius-mask-video-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/mac/fast/borders/border-radius-mask-video-ratio-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/mac/fast/borders/border-radius-mask-video-shadow-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/mac/hdr/color-profile-video-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/mac/hdr/video-canvas-alpha-expected.png
[add] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/mac/media/color-profile-video-expected.png
[add] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/mac/media/color-profile-video-seek-expected.png
[add] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/mac/media/color-profile-video-seek-filter-expected.png
[add] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/mac/media/color-profile-video-seek-object-fit-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/mac/media/controls-after-reload-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/mac/media/controls-strict-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/mac/media/controls-styling-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/mac/media/controls-styling-strict-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/mac/media/controls-without-preload-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/mac/media/controls/lazy-loaded-style-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/mac/media/controls/lazy-loaded-style-expected.txt
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/mac/media/controls/video-overlay-cast-dark-rendering-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/mac/media/track/track-cue-rendering-horizontal-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/mac/media/track/track-cue-rendering-vertical-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/mac/media/video-aspect-ratio-expected.png
[add] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/mac/media/video-canvas-alpha-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/mac/media/video-controls-rendering-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/mac/media/video-display-toggle-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/mac/media/video-layer-crash-expected.png
[add] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/mac/media/video-remove-insert-repaints-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/mac/media/video-replaces-poster-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/mac/media/video-transformed-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/mac/media/video-zoom-controls-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/mac/media/video-zoom-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/win/compositing/video-frame-size-change-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/win/compositing/video/video-reflection-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/win/fast/borders/border-radius-mask-video-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/win/fast/borders/border-radius-mask-video-ratio-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/win/fast/borders/border-radius-mask-video-shadow-expected.png
[add] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/win/hdr/color-profile-video-expected.png
[add] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/win/hdr/video-canvas-alpha-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/win/media/color-profile-video-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/win/media/color-profile-video-seek-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/win/media/color-profile-video-seek-filter-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/win/media/color-profile-video-seek-object-fit-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/win/media/controls-after-reload-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/win/media/controls-strict-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/win/media/controls-styling-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/win/media/controls-styling-strict-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/win/media/controls-without-preload-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/win/media/controls/lazy-loaded-style-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/win/media/controls/video-overlay-cast-dark-rendering-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/win/media/track/track-cue-rendering-horizontal-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/win/media/track/track-cue-rendering-vertical-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/win/media/video-aspect-ratio-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/win/media/video-canvas-alpha-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/win/media/video-controls-rendering-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/win/media/video-display-toggle-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/win/media/video-layer-crash-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/win/media/video-remove-insert-repaints-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/win/media/video-replaces-poster-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/win/media/video-transformed-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/win/media/video-zoom-controls-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/win/media/video-zoom-expected.png
[delete] https://crrev.com/cf1b5ae213001436b8dd0923e6b8d5358babba33/third_party/WebKit/LayoutTests/platform/win/virtual/new-remote-playback-pipeline/media/controls/lazy-loaded-style-expected.txt
[add] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/win7/media/color-profile-video-seek-filter-expected.png
[copy] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/win7/media/controls/lazy-loaded-style-expected.png
[modify] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/win7/media/track/track-cue-rendering-vertical-expected.png
[rename] https://crrev.com/f9064b1d8b6e1c8335da4635fff2f750b3b3d0d5/third_party/WebKit/LayoutTests/platform/win7/virtual/new-remote-playback-pipeline/media/controls/lazy-loaded-style-expected.png

Comment 8 by battre@chromium.org, Mar 26 2018 

This CL made a flaky media/video-transformed.html test even worse... As the test was bad before the CL I am not going to revert this one but ask you to take a look at it.
video-transformed-actual.png
59.1 KB View Download
video-transformed-expected.png
59.0 KB View Download
video-transformed-diff.png
67.0 KB View Download
Project Member

Comment 9 by bugdroid1@chromium.org, Mar 26 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/062b4653638fc64ae494e8a2b1e0c15e8a76d11c

commit 062b4653638fc64ae494e8a2b1e0c15e8a76d11c
Author: Dominic Battre <battre@chromium.org>
Date: Mon Mar 26 08:06:55 2018

Label media/video-transformed.html as flaky

See bug for details.

TBR=hubbe@chromium.org,dalecurtis@chromium.org
notry=true

Bug:  754986 
Change-Id: I33b05a30137c2c793d1704242dbb28d15c5aefe3
Reviewed-on: https://chromium-review.googlesource.com/979800
Reviewed-by: Dominic Battré <battre@chromium.org>
Commit-Queue: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545734}
[modify] https://crrev.com/062b4653638fc64ae494e8a2b1e0c15e8a76d11c/third_party/WebKit/LayoutTests/TestExpectations

Comment 10 by hubbe@chromium.org, Mar 26 2018 

I don't mind taking a look at this test, but I think it should have been a separate bug.
Project Member

Comment 11 by bugdroid1@chromium.org, Mar 27 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c4b965837127fe7d560a6b2d6291350c9888d8f

commit 4c4b965837127fe7d560a6b2d6291350c9888d8f
Author: Fredrik Hubinette <hubbe@google.com>
Date: Tue Mar 27 19:03:21 2018

Better VideoColorSpace -> ColorSpace conversion

Instead of defaulting everything to BT709, we look
at other fields to see if we can make a better guess.

Bug:  754986 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ie33df88aa50dd6629fa0721995aa33bcd1149d5e
Reviewed-on: https://chromium-review.googlesource.com/909336
Commit-Queue: Fredrik Hubinette <hubbe@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546192}
[modify] https://crrev.com/4c4b965837127fe7d560a6b2d6291350c9888d8f/media/base/video_color_space.cc
Project Member

Comment 12 by bugdroid1@chromium.org, Mar 30 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ec33b0423eea487835bdc9a1574a454ab4555ee

commit 8ec33b0423eea487835bdc9a1574a454ab4555ee
Author: Fredrik Hubinette <hubbe@google.com>
Date: Fri Mar 30 01:08:12 2018

update video decoder shim to gfx::ColorSpace

This is a re-land of 865455, which actually works.

TEST=ran video_decoder ppapi example

Bug:  754986 
Change-Id: Ibf0e20244173b8ade0c1fca134825b2cd2ace660
Reviewed-on: https://chromium-review.googlesource.com/902459
Commit-Queue: Fredrik Hubinette <hubbe@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547051}
[modify] https://crrev.com/8ec33b0423eea487835bdc9a1574a454ab4555ee/content/renderer/pepper/video_decoder_shim.cc
Project Member

Comment 13 by bugdroid1@chromium.org, Apr 5 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/81dae6b3d8825169ce471ed190d7761731a3dae0

commit 81dae6b3d8825169ce471ed190d7761731a3dae0
Author: Fredrik Hubinette <hubbe@google.com>
Date: Thu Apr 05 20:25:58 2018

Update canvas painter to use gfx::colorspace (sort of)

Adds conversion from gfx::ColorSpace to SkYUVColorSpace.

Bug:  754986 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I22260ea9542afc5306c82b7ec6d2e2d0cf4b7a0a
Reviewed-on: https://chromium-review.googlesource.com/869147
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: Fredrik Hubinette <hubbe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548540}
[modify] https://crrev.com/81dae6b3d8825169ce471ed190d7761731a3dae0/content/test/gpu/gpu_tests/pixel_expectations.py
[modify] https://crrev.com/81dae6b3d8825169ce471ed190d7761731a3dae0/content/test/gpu/gpu_tests/pixel_test_pages.py
[modify] https://crrev.com/81dae6b3d8825169ce471ed190d7761731a3dae0/media/filters/vpx_video_decoder.cc
[modify] https://crrev.com/81dae6b3d8825169ce471ed190d7761731a3dae0/media/renderers/paint_canvas_video_renderer.cc
[add] https://crrev.com/81dae6b3d8825169ce471ed190d7761731a3dae0/third_party/WebKit/LayoutTests/media/content/counting.webm
[modify] https://crrev.com/81dae6b3d8825169ce471ed190d7761731a3dae0/third_party/WebKit/LayoutTests/media/video-canvas.html
[modify] https://crrev.com/81dae6b3d8825169ce471ed190d7761731a3dae0/ui/gfx/color_space.cc
[modify] https://crrev.com/81dae6b3d8825169ce471ed190d7761731a3dae0/ui/gfx/color_space.h
Project Member

Comment 14 by bugdroid1@chromium.org, Apr 6 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/80f539eaff8b84940720bd1d7914de645f7f61b1

commit 80f539eaff8b84940720bd1d7914de645f7f61b1
Author: Fredrik Hubinette <hubbe@google.com>
Date: Fri Apr 06 03:25:22 2018

Deprecate media::ColorSpace and VideoFrameMetadata::COLOR_SPACE

Bug:  754986 
Change-Id: I66fafcea2b851e371473893bd23fe36b17354069
Reviewed-on: https://chromium-review.googlesource.com/999041
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Fredrik Hubinette <hubbe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548655}
[modify] https://crrev.com/80f539eaff8b84940720bd1d7914de645f7f61b1/media/base/video_frame_metadata.h
[modify] https://crrev.com/80f539eaff8b84940720bd1d7914de645f7f61b1/media/base/video_types.h
Project Member

Comment 15 by bugdroid1@chromium.org, Apr 6 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa0473b133768b9345178303d198a2012aa8c83b

commit fa0473b133768b9345178303d198a2012aa8c83b
Author: Corentin Wallez <cwallez@chromium.org>
Date: Fri Apr 06 17:04:49 2018

PixelTests: Expand temporary VP9 subbression to DC.

TBR=kbr@chromium.org
BUG= chromium:754986 

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I1f48e4fe4b6f7e7d904e154f2f81ff27bdae4e0e
Reviewed-on: https://chromium-review.googlesource.com/999732
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548823}
[modify] https://crrev.com/fa0473b133768b9345178303d198a2012aa8c83b/content/test/gpu/gpu_tests/pixel_expectations.py

Comment 16 by kbr@chromium.org, Apr 6 2018 

We should figure out why https://chromium-review.googlesource.com/999732 was necessary; namely, why it wasn't caught on the CQ. The Win GPU bots on the CQ are running Win10 now and should be going down the DirectComposition path.
Project Member

Comment 17 by bugdroid1@chromium.org, Apr 10 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0a8d41541fcf2dfa4d5ee9554733c9b85f246a10

commit 0a8d41541fcf2dfa4d5ee9554733c9b85f246a10
Author: Jamie Walch <jamiewalch@chromium.org>
Date: Tue Apr 10 20:33:05 2018

Revert "update video decoder shim to gfx::ColorSpace"

This reverts commit 8ec33b0423eea487835bdc9a1574a454ab4555ee.

Reason for revert: Breaks vp9 decode, as determined by bisect. See https://bugs.chromium.org/p/chromium/issues/detail?id=828656 for context.

Original change's description:
> update video decoder shim to gfx::ColorSpace
> 
> This is a re-land of 865455, which actually works.
> 
> TEST=ran video_decoder ppapi example
> 
> Bug:  754986 
> Change-Id: Ibf0e20244173b8ade0c1fca134825b2cd2ace660
> Reviewed-on: https://chromium-review.googlesource.com/902459
> Commit-Queue: Fredrik Hubinette <hubbe@chromium.org>
> Reviewed-by: ccameron <ccameron@chromium.org>
> Reviewed-by: Bill Budge <bbudge@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#547051}

TBR=bbudge@chromium.org,ccameron@chromium.org,hubbe@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  754986 
Change-Id: Ic6b672154942e210997c736fccf6a714e354889f
Reviewed-on: https://chromium-review.googlesource.com/1005734
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Commit-Queue: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549632}
[modify] https://crrev.com/0a8d41541fcf2dfa4d5ee9554733c9b85f246a10/content/renderer/pepper/video_decoder_shim.cc
Project Member

Comment 18 by bugdroid1@chromium.org, Apr 17 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/48c377dfbdf28c3e975fbf5814fd393806bfaff4

commit 48c377dfbdf28c3e975fbf5814fd393806bfaff4
Author: Fredrik Hubinette <hubbe@google.com>
Date: Tue Apr 17 22:51:51 2018

update directcomposition Pixel_Video_VP9 revision

Bug:  754986 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I234a2cc037b78b11d08660b641f5524ed8171a0b
Reviewed-on: https://chromium-review.googlesource.com/1014601
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551510}
[modify] https://crrev.com/48c377dfbdf28c3e975fbf5814fd393806bfaff4/content/test/gpu/gpu_tests/pixel_test_pages.py
Project Member

Comment 19 by bugdroid1@chromium.org, Apr 19 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f02c36c91e4f3842b0d5129fe5e0a75951ff1d9d

commit f02c36c91e4f3842b0d5129fe5e0a75951ff1d9d
Author: Fredrik Hubinette <hubbe@google.com>
Date: Thu Apr 19 21:39:37 2018

finish rebase Pixel_Video_VP9

Bug:  754986 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Icc92ef5e7f1c8fcd57dd9bdf252b8460871c6022
Reviewed-on: https://chromium-review.googlesource.com/1018240
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552168}
[modify] https://crrev.com/f02c36c91e4f3842b0d5129fe5e0a75951ff1d9d/content/test/gpu/gpu_tests/pixel_expectations.py
Project Member

Comment 20 by bugdroid1@chromium.org, Apr 27 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4e7d0b02070eff7055388cb1f061061134edf8b9

commit 4e7d0b02070eff7055388cb1f061061134edf8b9
Author: Fredrik Hubinette <hubbe@google.com>
Date: Fri Apr 27 09:52:50 2018

re-activate highsierra bypass

... for Pixel_Video_VP9

Bug:  754986 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I5fd7742ca773d8a5abbb8ad8326f559af246f19c
Reviewed-on: https://chromium-review.googlesource.com/1024497
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Fredrik Hubinette <hubbe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554347}
[modify] https://crrev.com/4e7d0b02070eff7055388cb1f061061134edf8b9/content/test/gpu/gpu_tests/pixel_expectations.py
Project Member

Comment 21 by bugdroid1@chromium.org, May 2 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/210f7ed9add7087876cf56825cb326df73a59b4b

commit 210f7ed9add7087876cf56825cb326df73a59b4b
Author: Fredrik Hubinette <hubbe@google.com>
Date: Wed May 02 23:17:58 2018

convert CopyRowsToRGB10Buffer to use gfx::ColorSpace

Also fixes the logic. Before it the code would default
to rec601, and because of a bug it would *always* use
the default.

Now it defaults to rec709, unless rec601 is specified.

Bug:  754986 
Change-Id: I94773a3bf0dfeae18e6a2ee8bc36ca884ba590b5
Reviewed-on: https://chromium-review.googlesource.com/998842
Commit-Queue: Fredrik Hubinette <hubbe@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555606}
[modify] https://crrev.com/210f7ed9add7087876cf56825cb326df73a59b4b/media/video/gpu_memory_buffer_video_frame_pool.cc
[modify] https://crrev.com/210f7ed9add7087876cf56825cb326df73a59b4b/media/video/gpu_memory_buffer_video_frame_pool_unittest.cc
[modify] https://crrev.com/210f7ed9add7087876cf56825cb326df73a59b4b/media/video/mock_gpu_video_accelerator_factories.cc
[modify] https://crrev.com/210f7ed9add7087876cf56825cb326df73a59b4b/media/video/mock_gpu_video_accelerator_factories.h
[modify] https://crrev.com/210f7ed9add7087876cf56825cb326df73a59b4b/ui/gfx/color_space.cc
[modify] https://crrev.com/210f7ed9add7087876cf56825cb326df73a59b4b/ui/gfx/color_space.h

Comment 22 by hubbe@chromium.org, Jun 19 2018 

note to self:

Make videoframe->set_color_space() also set the metadata, then all the places that set it explicitly can be removed.
Project Member

Comment 23 by bugdroid1@chromium.org, Aug 31 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05af136c89e4dede3b1458b964f7ec6b90d9fada

commit 05af136c89e4dede3b1458b964f7ec6b90d9fada
Author: Fredrik Hubinette <hubbe@google.com>
Date: Fri Aug 31 22:50:56 2018

stop using VideoFrameMetadata::COLOR_SPACE

.. in frame_sink_video_capturer_impl.cc

Bug:  754986 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I70b9cd3acf5dc7f40f4f3fc0a5a78a2cd9f63505
Reviewed-on: https://chromium-review.googlesource.com/1195043
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Xiangjun Zhang <xjz@chromium.org>
Commit-Queue: Fredrik Hubinette <hubbe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588196}
[modify] https://crrev.com/05af136c89e4dede3b1458b964f7ec6b90d9fada/components/mirroring/browser/single_client_video_capture_host_unittest.cc
[modify] https://crrev.com/05af136c89e4dede3b1458b964f7ec6b90d9fada/components/mirroring/service/fake_video_capture_host.cc
[modify] https://crrev.com/05af136c89e4dede3b1458b964f7ec6b90d9fada/components/mirroring/service/video_capture_client.cc
[modify] https://crrev.com/05af136c89e4dede3b1458b964f7ec6b90d9fada/components/mirroring/service/video_capture_client_unittest.cc
[modify] https://crrev.com/05af136c89e4dede3b1458b964f7ec6b90d9fada/components/viz/service/frame_sinks/video_capture/frame_sink_video_capturer_impl.cc
[modify] https://crrev.com/05af136c89e4dede3b1458b964f7ec6b90d9fada/components/viz/service/frame_sinks/video_capture/frame_sink_video_capturer_impl_unittest.cc
[modify] https://crrev.com/05af136c89e4dede3b1458b964f7ec6b90d9fada/content/browser/devtools/devtools_video_consumer.cc
[modify] https://crrev.com/05af136c89e4dede3b1458b964f7ec6b90d9fada/content/browser/devtools/devtools_video_consumer_unittest.cc
[modify] https://crrev.com/05af136c89e4dede3b1458b964f7ec6b90d9fada/content/browser/media/capture/fake_video_capture_stack.cc
[modify] https://crrev.com/05af136c89e4dede3b1458b964f7ec6b90d9fada/content/browser/media/capture/frame_sink_video_capture_device_unittest.cc
[modify] https://crrev.com/05af136c89e4dede3b1458b964f7ec6b90d9fada/media/capture/mojom/BUILD.gn
[modify] https://crrev.com/05af136c89e4dede3b1458b964f7ec6b90d9fada/media/capture/mojom/video_capture_types.mojom
[modify] https://crrev.com/05af136c89e4dede3b1458b964f7ec6b90d9fada/media/capture/video/video_capture_jpeg_decoder_impl.cc
Project Member

Comment 24 by bugdroid1@chromium.org, Sep 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2541ed66187369deb0ff14c372b900c6cb719a7b

commit 2541ed66187369deb0ff14c372b900c6cb719a7b
Author: Fredrik Hubinette <hubbe@google.com>
Date: Fri Sep 21 19:27:06 2018

get rid of VideoFrameMetadata::COLOR_SPACE

It's been deprecated for a while, this CL finally gets rid of it.

Bug:  754986 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Icc06af298f2e46252b2bc3e7ac73b25c66f3fd26
Reviewed-on: https://chromium-review.googlesource.com/1235209
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Fredrik Hubinette <hubbe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593297}
[modify] https://crrev.com/2541ed66187369deb0ff14c372b900c6cb719a7b/components/viz/service/display/renderer_pixeltest.cc
[modify] https://crrev.com/2541ed66187369deb0ff14c372b900c6cb719a7b/content/browser/media/capture/lame_window_capturer_chromeos.cc
[modify] https://crrev.com/2541ed66187369deb0ff14c372b900c6cb719a7b/media/base/video_frame.cc
[modify] https://crrev.com/2541ed66187369deb0ff14c372b900c6cb719a7b/media/base/video_frame_metadata.h
[modify] https://crrev.com/2541ed66187369deb0ff14c372b900c6cb719a7b/media/filters/decrypting_video_decoder.cc
[modify] https://crrev.com/2541ed66187369deb0ff14c372b900c6cb719a7b/media/filters/ffmpeg_video_decoder.cc
[modify] https://crrev.com/2541ed66187369deb0ff14c372b900c6cb719a7b/media/filters/vpx_video_decoder.cc

Comment 25 by hubbe@chromium.org, Sep 21

Status: Fixed (was: Assigned)
►

Sign in to add a comment