Issue metadata
Sign in to add a comment
|
CCT does not strikethrough scheme on broken https and sometimes is colored improperly |
||||||||||||||||||||||||
Issue descriptionChrome Version: 60.0.3112.97 OS: Android What steps will reproduce the problem? (1) Visit https://expired.badssl.com What is the expected result? The scheme is struck-through and not colored if there is a theme color. What happens instead? I saw two different things happen: once I saw the scheme struckthrough but colored red against a purple theme color (I think the scheme is not supposed to be colored when there is a dark theme color). After I refreshed, I can no longer reproduce that, and now I'm seeing the scheme consistently not struck-through (see screenshot).
,
Aug 21 2017
Taking a look.
,
Sep 7 2017
Assigning to Lei to take a look. Let's start from the strikethrough. Lei, in summary, the toolbar security state should be reflected here after the call to emphasizeUrl. See LocationBarLayout#updateSecurityIcon for the implementation. LocationBarLayout#shouldEmphasizeHttpsScheme is where the color emphasis logic is determined.
,
Sep 7 2017
,
Sep 7 2017
,
Sep 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f26dc9e577e66ad595b82e9fce4bec8861ef89cd commit f26dc9e577e66ad595b82e9fce4bec8861ef89cd Author: Lei Tian <ltian@google.com> Date: Tue Sep 26 20:15:28 2017 Fix CCT does not strikethrough scheme on broken https. When CCT opens url like https://expired.badssl.com, the strikethrough scheme sometimes does not display. This is because in CustomTabToolbar, updateSecurityIcon does not demphasize the url before emphasize it and this causes OmniboxUrlEmphasizer.hasEmphasisSpans() sometimes returns true and prevents the emphasis. To fix the problem, remove the hasEmphasisSpans check and always deEmphasizeUrl before emphasizeUrl the url. BUG= 754985 Change-Id: I16143c4237d71ce9d5b860597f523942d314ba25 Reviewed-on: https://chromium-review.googlesource.com/675769 Commit-Queue: Lei Tian <ltian@google.com> Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#504469} [modify] https://crrev.com/f26dc9e577e66ad595b82e9fce4bec8861ef89cd/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java [modify] https://crrev.com/f26dc9e577e66ad595b82e9fce4bec8861ef89cd/chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java [modify] https://crrev.com/f26dc9e577e66ad595b82e9fce4bec8861ef89cd/chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java
,
Sep 28 2017
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by est...@chromium.org
, Aug 12 2017155 KB
155 KB View Download