New Translate Infobar - Menu text truncated when too long. It should wrap to multi-line. |
|||||
Issue descriptionSteps to reproduce: 1. Launch the app (M60) 2. Enable the flag "New Translate Infobar" flag from about://flags page 3. Visit any page in a language other than the System language(s). (Example - Baidu.com,m.yahoo.com.cp) 4. Wait for page load to finish. 5. Tap on the menu (3 dots) button to show the menu. Observed behavior: Menu text is truncated because the text is longer than the menu width. (see attached screenshot) Expected behavior: Menu text should wrap to multi-line. Frequency: 100%
,
Aug 15 2017
This still looks rather spacious in my opinion. Rachelis@ - any thoughts on whether we can adjust the padding below 13dp?
,
Aug 17 2017
Thanks for looping me in Yana! Matching the main overflow menu overall is the right thing to do here, since we should keep our overflow menus consistent. +hannahs FYI I'm not really aware of what the actual specced sizing should be here in both cases (from the stickersheet, it looks like 48dp for each line-item). Hannah - would you mind taking a quick look to make sure this seems in order? (Documenting - There's no specced size in Bruno's spec or in Hwi's infobar spec) and m
,
Aug 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b3291682252d6fa56640e7350609d0a0c380090d commit b3291682252d6fa56640e7350609d0a0c380090d Author: Marti Wong <martiw@chromium.org> Date: Fri Aug 18 07:26:56 2017 New Translate Infobar - Make menu text wrap to multi-line. Currently, when menu text is longer than the menu, it will be truncated. This CL make the menu text wrap to multi-line. Screenshot: https://bugs.chromium.org/p/chromium/issues/attachment?aid=297675&inline=1 Bug: 754948 Change-Id: I939c96cc7265010cc54729e7a97966175ca93823 Reviewed-on: https://chromium-review.googlesource.com/611870 Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by: Matthew Jones <mdjones@chromium.org> Commit-Queue: Marti Wong <martiw@chromium.org> Cr-Commit-Position: refs/heads/master@{#495495} [modify] https://crrev.com/b3291682252d6fa56640e7350609d0a0c380090d/chrome/android/java/res/layout/translate_menu_item.xml [modify] https://crrev.com/b3291682252d6fa56640e7350609d0a0c380090d/chrome/android/java/res/layout/translate_menu_item_checked.xml [modify] https://crrev.com/b3291682252d6fa56640e7350609d0a0c380090d/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java [modify] https://crrev.com/b3291682252d6fa56640e7350609d0a0c380090d/chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateMenuHelper.java
,
Aug 18 2017
,
Aug 18 2017
Yes, this is based on the Material spec which sets the row height to 48dp (as it's the recommended touch target size).
,
Aug 22 2017
This issue is fixed as per the images in the comment #1 in current M62 - 62.0.3193.0. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by martiw@chromium.org
, Aug 15 2017126 KB
126 KB View Download