New issue
Advanced search Search tips

Issue 754900 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Aug 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocking:
issue 680790



Sign in to add a comment

getSafeBrowsingPrivacyPolicyUrl should include locale in the URL query

Project Member Reported by ntfschr@chromium.org, Aug 11 2017

Issue description

Help center links like the privacy-policy-url should include the locale via a query parameter (e.g. ?hl=en_US).

We're not doing this right now, but we can add this with google_util::AppendGoogleLocaleParam(). Both owners are OOO right now, but we can follow up on this later.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/edf8e4141ebc9ca04a311080f2c8b386d7f4df1a

commit edf8e4141ebc9ca04a311080f2c8b386d7f4df1a
Author: Nate Fischer <ntfschr@chromium.org>
Date: Sat Aug 26 01:52:58 2017

AW: append locale to Safe Browsing Privacy Policy URL

This is to stay consistent with Safe Browsing code which appends the
locale to the URL used for the default interstitial. This allows
applications an easy way to link users to the privacy policy in the
preferred locale.

Bug:  754900 
Test: run_webview_instrumentation_test_apk -f SafeBrowsingTest#testGetSafeBrowsingPrivacyPolicyUrl
Change-Id: I78cd8de3c17f8f19e3f88c9949bb5debb4285530
Reviewed-on: https://chromium-review.googlesource.com/636644
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497633}
[modify] https://crrev.com/edf8e4141ebc9ca04a311080f2c8b386d7f4df1a/android_webview/BUILD.gn
[modify] https://crrev.com/edf8e4141ebc9ca04a311080f2c8b386d7f4df1a/android_webview/DEPS
[modify] https://crrev.com/edf8e4141ebc9ca04a311080f2c8b386d7f4df1a/android_webview/browser/aw_contents_statics.cc
[modify] https://crrev.com/edf8e4141ebc9ca04a311080f2c8b386d7f4df1a/android_webview/javatests/src/org/chromium/android_webview/test/SafeBrowsingTest.java

Status: Fixed (was: Assigned)
Verification steps:

Follow the same steps as issue 754539. Try this in different locales and see that the URL changes. For example, the language should say "hl=en-US" in US English.

Comment 3 Deleted

Verification :
Change the device language to Italia
Try to later version of Supersafebrowsing.apk  from https://drive.google.com/corp/drive/u/2/folders/0B6dOsuQZDwrMOENJUzNET2t6WHc and tap the privacy policy link displays the appropriate language in the Url on Pixel C/ OPM1.170829.001 with 62.0.3199.3(Monochrome dev)
Labels: WebView-SafeBrowsing

Sign in to add a comment