New issue
Advanced search Search tips

Issue 754899 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Feb 2018
Cc:
m...@chromium.org
mustash-bugs@google.com
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocked on:
issue 754872


Sign in to add a comment

LoginFeedbackTest.Basic (browser_tests) with --mash fails because screen capture not implement yet

Project Member Reported by sky@chromium.org, Aug 11 2017 
This test ensures the feedback page is shown. The show doesn't happen until a screenshot is taken, which doesn't work yet because of 754872.

Comment 1 by sky@chromium.org, Aug 14 2017 

The following all fails as well, likely for the same reason:
TabCaptureApiPixelTest.EndToEndThroughWebRTC
TabCaptureApiPixelTest.EndToEndWithoutRemoting
TabCaptureApiPixelTest.OffscreenTabEndToEnd
TabCaptureApiPixelTest.OffscreenTabEvilTests

Comment 2 by sky@chromium.org, Aug 25 2017 

ChromeScreenshotGrabberBrowserTest.TakeScreenshot is another test that fails for the same reason.

Comment 3 by sky@chromium.org, Nov 6 2017

Blocking: -740655 731255

Comment 4 by jamescook@chromium.org, Nov 17 2017 

As expected, browser_tests --mash too

Comment 5 by sadrul@chromium.org, Dec 7 2017

Blocking: -731255
Summary: LoginFeedbackTest.Basic (browser_tests) with --mash fails because screen capture not implement yet (was: LoginFeedbackTest.Basic (browser_tests) with --mus fails because screen capture not implement yet)
This test now works OK with --mus, since viz is not on by default.

Comment 6 by m...@chromium.org, Feb 14 2018

Status: Fixed (was: Untriaged)
Resolving this, as  bug 806375  fixed the screenshot grabber,  bug 754872  has completed the tab capture VIZ impl, the test *does* now work with --mus. The VIZ-related issue with this test now falls under  bug 810389 .
►

Sign in to add a comment