New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 754895 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task

Blocked on:
issue 754889



Sign in to add a comment

Migrate UKM entries to use NavigationID based SourceIds

Project Member Reported by holte@chromium.org, Aug 11 2017

Issue description

We should get most metrics using the same ID to refer to navigations, and avoid recording URLs from multiple places.
 

Comment 1 by holte@chromium.org, Aug 11 2017

Blockedon: 754889
Partly blocked on easy access to NavigationId from more places. crbug/754889

Comment 2 by holte@chromium.org, Aug 15 2017

Owner: holte@chromium.org

Comment 4 by holte@chromium.org, Sep 1 2017

Components: Internals>Metrics>UKM
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0f467721dedbf23f30da83f3e6c70439b6b07e4

commit f0f467721dedbf23f30da83f3e6c70439b6b07e4
Author: Steven Holte <holte@google.com>
Date: Mon Dec 11 20:54:51 2017

Migrate Flash UKM to shared SourceId

Bug: 754895
Change-Id: I7b25e9759cc350b15581c1cf197ba1e534e11b55
Reviewed-on: https://chromium-review.googlesource.com/815765
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523201}
[modify] https://crrev.com/f0f467721dedbf23f30da83f3e6c70439b6b07e4/chrome/browser/plugins/plugin_info_host_impl.cc
[modify] https://crrev.com/f0f467721dedbf23f30da83f3e6c70439b6b07e4/chrome/browser/plugins/plugin_info_host_impl.h

Labels: Postmortem-Followup
Status: Assigned (was: Available)
Summarizing the remaining work to avoid usage of UpdateSourceURL:

Cases which should be simple migrations:
cc/trees/ukm_manager.cc
https://bugs.chromium.org/p/chromium/issues/detail?id=892361

third_party/blink/renderer/modules/vr/navigator_vr.cc
https://bugs.chromium.org/p/chromium/issues/detail?id=892358

third_party/blink/renderer/core/dom/document.cc
 - This should be redundant with data from DocumentCreated links.
   We should update analysis to use those links and remove this.

components/translate/core/browser/translate_ranker_impl.cc

Odd cases:
chrome/browser/media/media_engagement_session.cc
 - This uses SourceId for a "Media session" which has data for multiple
   navigations with the same origin, so we should replace this with some link to
   those navigations.

chrome/browser/notifications/platform_notification_service_impl.cc
 - These aren't always associated with a pageload in the same session,
   so they are a special case.
components/offline_pages/core/offline_pages_ukm_reporter.cc

Owner: nikunjb@chromium.org

Sign in to add a comment