New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 754894 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

CQ didn't pick up a try job for an unusually long time

Project Member Reported by dpranke@chromium.org, Aug 11 2017

Issue description

On https://chromium-review.googlesource.com/c/612211 , jam@ checked the CQ box at around 1:50pm, but for some reason the CQ didn't seem to start doing anything with it until shortly after reillyg@ checked the box as well at 3:31pm.

Normally we'd expect it to get picked up much quicker, right? I.e., people other than the owner should be able to +2 things and have them take effect?
 
I believe this was because I didn't CR+1 the change before jam@ CQ+2'd it but I don't really know how Gerrit works.
Cc: aga...@chromium.org
ah, that's possible, though one of the CQ folks or agable@ or iannucci@ can probably confirm.
Owner: tandrii@chromium.org
Status: Assigned (was: Untriaged)
This is a bug in either CQ or Gerrit. CQ shouldn't wait for you to CR+1, it should abort immediately. I'll look at logs and report back.
Status: WontFix (was: Assigned)
I've looked at the log of CQ and it appears to be a Gerrit flake because Gerrit didn't return 612211 change when queried for CLs with CQ vote >1 until second CQ+2 vote.

I'm adding ever more debug code to be absolutely certain if similar thing happens in the future. But for now, there is nothing CQ can do about this short of re-implementing Gerrit's search index. Hence, WontFix.

For those interested could star the Gerrit bug I've filed: https://b.corp.google.com/issues/64748828
correction for above: when queried with CQ vote > 0 , since CQ looks for both CQ+1 and CQ+2.
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 16 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal/+/e34d566c0a3c1efcc4f8024b0e6d7f3bcfc0e5a8

commit e34d566c0a3c1efcc4f8024b0e6d7f3bcfc0e5a8
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Wed Aug 16 15:28:20 2017

Sign in to add a comment