New code should prefer using code generated builders, as documented in services/metrics/ukm_api.md
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5045430ba72f46b3a6b27846ff9dca6922d1811d commit 5045430ba72f46b3a6b27846ff9dca6922d1811d Author: Steven Holte <holte@google.com> Date: Tue Aug 15 21:29:06 2017 Switch UKM memory metrics to codegen'd API. Bug: 754892 Change-Id: I9c1d6f049a15b6bef4aff92b59bc4467a2f748b5 Reviewed-on: https://chromium-review.googlesource.com/614566 Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#494554} [modify] https://crrev.com/5045430ba72f46b3a6b27846ff9dca6922d1811d/chrome/browser/metrics/process_memory_metrics_emitter.cc [modify] https://crrev.com/5045430ba72f46b3a6b27846ff9dca6922d1811d/chrome/browser/metrics/process_memory_metrics_emitter.h [modify] https://crrev.com/5045430ba72f46b3a6b27846ff9dca6922d1811d/tools/metrics/ukm/ukm.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dc5fa1e99b7b3f31e75336c05e2fa0aae3f6c49e commit dc5fa1e99b7b3f31e75336c05e2fa0aae3f6c49e Author: Steven Holte <holte@google.com> Date: Thu Aug 17 17:33:52 2017 PasswordForm UKM to builder API. Bug: 754892 Change-Id: I222084afcc25de3742114c38998d6988c5ab562a Reviewed-on: https://chromium-review.googlesource.com/614873 Reviewed-by: Dominic Battré <battre@chromium.org> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#495208} [modify] https://crrev.com/dc5fa1e99b7b3f31e75336c05e2fa0aae3f6c49e/chrome/browser/password_manager/save_password_infobar_delegate_android_unittest.cc [modify] https://crrev.com/dc5fa1e99b7b3f31e75336c05e2fa0aae3f6c49e/chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc [modify] https://crrev.com/dc5fa1e99b7b3f31e75336c05e2fa0aae3f6c49e/components/password_manager/core/browser/BUILD.gn [modify] https://crrev.com/dc5fa1e99b7b3f31e75336c05e2fa0aae3f6c49e/components/password_manager/core/browser/password_form_manager_unittest.cc [modify] https://crrev.com/dc5fa1e99b7b3f31e75336c05e2fa0aae3f6c49e/components/password_manager/core/browser/password_form_metrics_recorder.cc [modify] https://crrev.com/dc5fa1e99b7b3f31e75336c05e2fa0aae3f6c49e/components/password_manager/core/browser/password_form_metrics_recorder.h [modify] https://crrev.com/dc5fa1e99b7b3f31e75336c05e2fa0aae3f6c49e/components/password_manager/core/browser/password_form_metrics_recorder_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/48b7f8cae232bd87e953319e06a55bb29fcb2a91 commit 48b7f8cae232bd87e953319e06a55bb29fcb2a91 Author: Steven Holte <holte@google.com> Date: Wed Aug 23 23:53:09 2017 Migrate Autofill UKMs to codegen'd builder API. Bug: 754892 Change-Id: I1b40f304c041114ce7e44d5fff76775d09b114a2 Reviewed-on: https://chromium-review.googlesource.com/617996 Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#496875} [modify] https://crrev.com/48b7f8cae232bd87e953319e06a55bb29fcb2a91/components/autofill/core/browser/BUILD.gn [modify] https://crrev.com/48b7f8cae232bd87e953319e06a55bb29fcb2a91/components/autofill/core/browser/autofill_manager_unittest.cc [modify] https://crrev.com/48b7f8cae232bd87e953319e06a55bb29fcb2a91/components/autofill/core/browser/autofill_metrics.cc [modify] https://crrev.com/48b7f8cae232bd87e953319e06a55bb29fcb2a91/components/autofill/core/browser/autofill_metrics.h [modify] https://crrev.com/48b7f8cae232bd87e953319e06a55bb29fcb2a91/components/autofill/core/browser/autofill_metrics_unittest.cc [modify] https://crrev.com/48b7f8cae232bd87e953319e06a55bb29fcb2a91/tools/metrics/ukm/ukm.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f665076162316d3fc51d9082da81efb85131460e commit f665076162316d3fc51d9082da81efb85131460e Author: Steven Holte <holte@google.com> Date: Fri Aug 25 20:31:40 2017 Update example in MojoUkmRecorder to use codegen API. Bug: 754892 Change-Id: Ie3b1c50321fb86bafd7c3b02272bbfd90ba0f803 Reviewed-on: https://chromium-review.googlesource.com/633759 Reviewed-by: Brian White <bcwhite@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#497521} [modify] https://crrev.com/f665076162316d3fc51d9082da81efb85131460e/services/metrics/public/cpp/mojo_ukm_recorder.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b8ed47189611a124f6aea8293468313564a366cd commit b8ed47189611a124f6aea8293468313564a366cd Author: Steven Holte <holte@google.com> Date: Tue Sep 05 23:32:17 2017 Migrate JourneyLogger UKMs to codegen'd API Bug: 754892 Change-Id: I971f69cedf662024c0ec0392ea131d2e0ad4fbca Reviewed-on: https://chromium-review.googlesource.com/647066 Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by: Mathieu Perreault <mathp@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#499795} [modify] https://crrev.com/b8ed47189611a124f6aea8293468313564a366cd/components/payments/core/BUILD.gn [modify] https://crrev.com/b8ed47189611a124f6aea8293468313564a366cd/components/payments/core/journey_logger.cc [modify] https://crrev.com/b8ed47189611a124f6aea8293468313564a366cd/components/payments/core/journey_logger.h [modify] https://crrev.com/b8ed47189611a124f6aea8293468313564a366cd/components/payments/core/journey_logger_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c23c94ed704f1760a0549cadb63159680fcbeb29 commit c23c94ed704f1760a0549cadb63159680fcbeb29 Author: Steven Holte <holte@google.com> Date: Thu Sep 14 19:37:41 2017 Move translate to codegen'd UKM api Bug: 754892 Change-Id: I3e15114c30248bcf5842e9190a8945393e401fc2 Reviewed-on: https://chromium-review.googlesource.com/646702 Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by: Rachel Blum <groby@chromium.org> Cr-Commit-Position: refs/heads/master@{#502014} [modify] https://crrev.com/c23c94ed704f1760a0549cadb63159680fcbeb29/components/translate/core/browser/BUILD.gn [modify] https://crrev.com/c23c94ed704f1760a0549cadb63159680fcbeb29/components/translate/core/browser/translate_ranker_impl.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2d9d8fa7e3fa585afe2a4c76354066608f77946f commit 2d9d8fa7e3fa585afe2a4c76354066608f77946f Author: Steven Holte <holte@google.com> Date: Thu Oct 05 20:30:42 2017 Unfriend classes migrated to ukm_builders.h Bug: 754892 Change-Id: I3498e985e9382aa5149406fcad51a8314f42c43d Reviewed-on: https://chromium-review.googlesource.com/701257 Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#506843} [modify] https://crrev.com/2d9d8fa7e3fa585afe2a4c76354066608f77946f/services/metrics/public/cpp/ukm_recorder.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4f85f3c06ead8979651d0096b95d9bb8a16601bf commit 4f85f3c06ead8979651d0096b95d9bb8a16601bf Author: Steven Holte <holte@google.com> Date: Wed Apr 25 22:16:25 2018 Migrate PageLoadMetrics UKMs to ukm_builders.h Bug: 754892 Change-Id: I423630306e0a83cc02a78e4b0e1f99f908bfc24e Reviewed-on: https://chromium-review.googlesource.com/1022812 Reviewed-by: Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#553787} [modify] https://crrev.com/4f85f3c06ead8979651d0096b95d9bb8a16601bf/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc [modify] https://crrev.com/4f85f3c06ead8979651d0096b95d9bb8a16601bf/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.h [modify] https://crrev.com/4f85f3c06ead8979651d0096b95d9bb8a16601bf/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer_unittest.cc [modify] https://crrev.com/4f85f3c06ead8979651d0096b95d9bb8a16601bf/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc [modify] https://crrev.com/4f85f3c06ead8979651d0096b95d9bb8a16601bf/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h [modify] https://crrev.com/4f85f3c06ead8979651d0096b95d9bb8a16601bf/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer_unittest.cc [modify] https://crrev.com/4f85f3c06ead8979651d0096b95d9bb8a16601bf/chrome/browser/page_load_metrics/observers/local_network_requests_page_load_metrics_observer.cc [modify] https://crrev.com/4f85f3c06ead8979651d0096b95d9bb8a16601bf/chrome/browser/page_load_metrics/observers/local_network_requests_page_load_metrics_observer.h [modify] https://crrev.com/4f85f3c06ead8979651d0096b95d9bb8a16601bf/chrome/browser/page_load_metrics/observers/local_network_requests_page_load_metrics_observer_unittest.cc [modify] https://crrev.com/4f85f3c06ead8979651d0096b95d9bb8a16601bf/chrome/browser/page_load_metrics/observers/previews_ukm_observer.cc [modify] https://crrev.com/4f85f3c06ead8979651d0096b95d9bb8a16601bf/chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer.cc [modify] https://crrev.com/4f85f3c06ead8979651d0096b95d9bb8a16601bf/chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer.h [modify] https://crrev.com/4f85f3c06ead8979651d0096b95d9bb8a16601bf/chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer_unittest.cc [modify] https://crrev.com/4f85f3c06ead8979651d0096b95d9bb8a16601bf/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.cc [modify] https://crrev.com/4f85f3c06ead8979651d0096b95d9bb8a16601bf/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.h [modify] https://crrev.com/4f85f3c06ead8979651d0096b95d9bb8a16601bf/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer_unittest.cc [modify] https://crrev.com/4f85f3c06ead8979651d0096b95d9bb8a16601bf/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.cc [modify] https://crrev.com/4f85f3c06ead8979651d0096b95d9bb8a16601bf/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h [modify] https://crrev.com/4f85f3c06ead8979651d0096b95d9bb8a16601bf/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer_unittest.cc [modify] https://crrev.com/4f85f3c06ead8979651d0096b95d9bb8a16601bf/chrome/browser/page_load_metrics/observers/use_counter_page_load_metrics_observer.h [modify] https://crrev.com/4f85f3c06ead8979651d0096b95d9bb8a16601bf/chrome/browser/page_load_metrics/observers/use_counter_page_load_metrics_observer_unittest.cc [modify] https://crrev.com/4f85f3c06ead8979651d0096b95d9bb8a16601bf/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc [modify] https://crrev.com/4f85f3c06ead8979651d0096b95d9bb8a16601bf/services/metrics/public/cpp/ukm_recorder.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/da77a48bd4d609e0bd44645665d8d76d8c35f9a7 commit da77a48bd4d609e0bd44645665d8d76d8c35f9a7 Author: Steven Holte <holte@google.com> Date: Fri Apr 27 22:59:27 2018 Change UkmEntryBuilder to use the new semantics. This avoids the implicit recording on destruction and the need to have ukm_recorder to construct an entry, and no longer needs to be part of the UkmRecorder API. Since we now are DCHECK'ing against recording metrics not in ukm.xml we no longer need to have this API behind a friend whitelist. TBR=charleszhao,mlamouri,chrishtr Bug: 754892 Change-Id: I944ae698bd5ad4146411d5e11b945e21c1b52a98 Reviewed-on: https://chromium-review.googlesource.com/1027112 Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Reviewed-by: Timothy Dresser <tdresser@chromium.org> Reviewed-by: Filip Gorski <fgorski@chromium.org> Reviewed-by: Bryan McQuade <bmcquade@chromium.org> Cr-Commit-Position: refs/heads/master@{#554548} [modify] https://crrev.com/da77a48bd4d609e0bd44645665d8d76d8c35f9a7/components/assist_ranker/base_predictor.cc [modify] https://crrev.com/da77a48bd4d609e0bd44645665d8d76d8c35f9a7/components/ntp_snippets/contextual/contextual_suggestions_ukm_entry.cc [modify] https://crrev.com/da77a48bd4d609e0bd44645665d8d76d8c35f9a7/components/ukm/ukm_service_unittest.cc [modify] https://crrev.com/da77a48bd4d609e0bd44645665d8d76d8c35f9a7/services/metrics/public/cpp/ukm_entry_builder.cc [modify] https://crrev.com/da77a48bd4d609e0bd44645665d8d76d8c35f9a7/services/metrics/public/cpp/ukm_entry_builder.h [modify] https://crrev.com/da77a48bd4d609e0bd44645665d8d76d8c35f9a7/services/metrics/public/cpp/ukm_entry_builder_base.cc [modify] https://crrev.com/da77a48bd4d609e0bd44645665d8d76d8c35f9a7/services/metrics/public/cpp/ukm_entry_builder_base.h [modify] https://crrev.com/da77a48bd4d609e0bd44645665d8d76d8c35f9a7/services/metrics/public/cpp/ukm_recorder.cc [modify] https://crrev.com/da77a48bd4d609e0bd44645665d8d76d8c35f9a7/services/metrics/public/cpp/ukm_recorder.h [modify] https://crrev.com/da77a48bd4d609e0bd44645665d8d76d8c35f9a7/third_party/blink/renderer/core/html/media/autoplay_uma_helper.cc [modify] https://crrev.com/da77a48bd4d609e0bd44645665d8d76d8c35f9a7/third_party/blink/renderer/core/html/media/autoplay_uma_helper.h [modify] https://crrev.com/da77a48bd4d609e0bd44645665d8d76d8c35f9a7/third_party/blink/renderer/platform/ukm_time_aggregator.cc [modify] https://crrev.com/da77a48bd4d609e0bd44645665d8d76d8c35f9a7/tools/metrics/ukm/builders_template.py [modify] https://crrev.com/da77a48bd4d609e0bd44645665d8d76d8c35f9a7/ui/latency/latency_tracker.cc
Comment 1 by holte@chromium.org
, Aug 14 2017