New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 754889 link

Starred by 1 user
Status: Fixed
Owner:
█ holte@chromium.org
Last visit > 30 days ago
Closed: Apr 2018
Cc:
skare@chromium.org
isherman@chromium.org
asvitk...@chromium.org
█ rkaplow@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Task

Blocking:
issue 754895
issue 787209
issue 705741



Sign in to add a comment

Make it easy to get a UKM Source ID for WebContents content

Project Member Reported by holte@chromium.org, Aug 11 2017 
Now that we have NavigationIds on NavigationHandle, and can convert them to UKM SourceIds, we need to make them more accessible for code that records events.

It would be nice to be able to get one from a WebContents, similar to
web_contents->GetMainFrame()->GetLastCommittedURL()

Comment 1 by holte@chromium.org, Aug 11 2017

Blocking: 754895

Comment 2 by holte@chromium.org, Aug 11 2017

Labels: -Pri-3 Pri-2

Comment 3 by holte@chromium.org, Aug 11 2017

Blocking: 705741

Comment 4 by holte@chromium.org, Aug 24 2017

Summary: Make it easy to get a UKM Source ID for WebContents content (was: Propogate NavigationIds to WebContents)

Comment 5 by holte@chromium.org, Sep 1 2017

Components: Internals>Metrics>UKM

Comment 6 by chcunningham@chromium.org, Nov 21 2017

Blocking: 787209
Project Member

Comment 8 by bugdroid1@chromium.org, Dec 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a9033e279f1c87bcb28f69af4b3f218ef92ce794

commit a9033e279f1c87bcb28f69af4b3f218ef92ce794
Author: Steven Holte <holte@google.com>
Date: Wed Dec 06 01:38:09 2017

Migrate Sound UKM to shared SourceID.

Bug:  754889 
Change-Id: I7dd1233e282fab6a3e00c40526e5c69b54637726
Reviewed-on: https://chromium-review.googlesource.com/806925
Commit-Queue: Steven Holte <holte@chromium.org>
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521940}
[modify] https://crrev.com/a9033e279f1c87bcb28f69af4b3f218ef92ce794/chrome/browser/content_settings/sound_content_setting_observer.cc
[modify] https://crrev.com/a9033e279f1c87bcb28f69af4b3f218ef92ce794/chrome/browser/content_settings/sound_content_setting_observer_unittest.cc
Project Member

Comment 9 by bugdroid1@chromium.org, Dec 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5dda68171ef5604f4a7cac1cc74edddc0506de30

commit 5dda68171ef5604f4a7cac1cc74edddc0506de30
Author: Steven Holte <holte@google.com>
Date: Wed Dec 06 03:46:11 2017

Migrate Contextual Search UKM to shared SourceId.

Bug:  754889 
Change-Id: Iabbd43da20b9e1bf8f318b78b141b75f62dd62fd
Reviewed-on: https://chromium-review.googlesource.com/804827
Commit-Queue: Steven Holte <holte@chromium.org>
Reviewed-by: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521987}
[modify] https://crrev.com/5dda68171ef5604f4a7cac1cc74edddc0506de30/chrome/browser/android/contextualsearch/contextual_search_ranker_logger_impl.cc
[modify] https://crrev.com/5dda68171ef5604f4a7cac1cc74edddc0506de30/chrome/browser/android/contextualsearch/contextual_search_ranker_logger_impl.h
Project Member

Comment 10 by bugdroid1@chromium.org, Dec 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/615a264ce750d6b2e6ec4fb64d99827b758f1e6f

commit 615a264ce750d6b2e6ec4fb64d99827b758f1e6f
Author: Steven Holte <holte@google.com>
Date: Thu Dec 07 23:32:28 2017

Migrate Password UKMs to shared SourceIds

Bug:  754889 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I1ba28ebe8062179a619e09fb6349e6046a3378df
Reviewed-on: https://chromium-review.googlesource.com/807347
Commit-Queue: Steven Holte <holte@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522612}
[modify] https://crrev.com/615a264ce750d6b2e6ec4fb64d99827b758f1e6f/chrome/browser/password_manager/chrome_password_manager_client.cc
[modify] https://crrev.com/615a264ce750d6b2e6ec4fb64d99827b758f1e6f/chrome/browser/password_manager/chrome_password_manager_client.h
[modify] https://crrev.com/615a264ce750d6b2e6ec4fb64d99827b758f1e6f/chrome/browser/password_manager/save_password_infobar_delegate_android_unittest.cc
[modify] https://crrev.com/615a264ce750d6b2e6ec4fb64d99827b758f1e6f/chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc
[modify] https://crrev.com/615a264ce750d6b2e6ec4fb64d99827b758f1e6f/chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc
[modify] https://crrev.com/615a264ce750d6b2e6ec4fb64d99827b758f1e6f/components/password_manager/core/browser/password_autofill_manager_unittest.cc
[modify] https://crrev.com/615a264ce750d6b2e6ec4fb64d99827b758f1e6f/components/password_manager/core/browser/password_form_manager.cc
[modify] https://crrev.com/615a264ce750d6b2e6ec4fb64d99827b758f1e6f/components/password_manager/core/browser/password_form_manager_unittest.cc
[modify] https://crrev.com/615a264ce750d6b2e6ec4fb64d99827b758f1e6f/components/password_manager/core/browser/password_form_metrics_recorder.cc
[modify] https://crrev.com/615a264ce750d6b2e6ec4fb64d99827b758f1e6f/components/password_manager/core/browser/password_form_metrics_recorder.h
[modify] https://crrev.com/615a264ce750d6b2e6ec4fb64d99827b758f1e6f/components/password_manager/core/browser/password_form_metrics_recorder_unittest.cc
[modify] https://crrev.com/615a264ce750d6b2e6ec4fb64d99827b758f1e6f/components/password_manager/core/browser/password_manager_client.h
[modify] https://crrev.com/615a264ce750d6b2e6ec4fb64d99827b758f1e6f/components/password_manager/core/browser/password_manager_metrics_recorder.cc
[modify] https://crrev.com/615a264ce750d6b2e6ec4fb64d99827b758f1e6f/components/password_manager/core/browser/password_manager_metrics_recorder.h
[modify] https://crrev.com/615a264ce750d6b2e6ec4fb64d99827b758f1e6f/components/password_manager/core/browser/password_manager_metrics_recorder_unittest.cc
[modify] https://crrev.com/615a264ce750d6b2e6ec4fb64d99827b758f1e6f/components/password_manager/core/browser/stub_password_manager_client.cc
[modify] https://crrev.com/615a264ce750d6b2e6ec4fb64d99827b758f1e6f/components/password_manager/core/browser/stub_password_manager_client.h
[modify] https://crrev.com/615a264ce750d6b2e6ec4fb64d99827b758f1e6f/ios/chrome/browser/passwords/ios_chrome_password_manager_client.h
[modify] https://crrev.com/615a264ce750d6b2e6ec4fb64d99827b758f1e6f/ios/chrome/browser/passwords/ios_chrome_password_manager_client.mm
Project Member

Comment 11 by bugdroid1@chromium.org, Dec 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f37ead1c398f2e70c6d89252d4c6f9d292799a3

commit 5f37ead1c398f2e70c6d89252d4c6f9d292799a3
Author: Steven Holte <holte@google.com>
Date: Fri Dec 08 00:54:01 2017

Migrate UserActivityLoggerDelegateUkm to shared SourceIds.

Bug:  754889 
Change-Id: I10b41f1ffc2672a7163bc71ac0adfb3ef40c8475
Reviewed-on: https://chromium-review.googlesource.com/809938
Commit-Queue: Steven Holte <holte@chromium.org>
Reviewed-by: Jia Meng <jiameng@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522656}
[modify] https://crrev.com/5f37ead1c398f2e70c6d89252d4c6f9d292799a3/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/5f37ead1c398f2e70c6d89252d4c6f9d292799a3/chrome/browser/chromeos/power/ml/user_activity_logger_delegate_ukm.cc

Comment 12 by rkaplow@google.com, Jan 9 2018 

I'm not sure how to up to date the spreadsheet is - for what is left exactly. Steve, are you still working on this?

Comment 13 by holte@chromium.org, Jan 10 2018 

It's still up to date, though I've prioritized finishing this behind https://bugs.chromium.org/p/chromium/issues/detail?id=786190

Comment 14 by holte@chromium.org, Apr 27 2018

Status: Fixed (was: Assigned)
Bug for migrating remaining UpdateSourceUrl callers is crbug/754895
►

Sign in to add a comment