New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 754882 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug
Proj-Servicification



Sign in to add a comment

Support multiple URLLoaderThrottles in a ThrottledURLLoader

Project Member Reported by dtrainor@chromium.org, Aug 11 2017

Issue description

Add a version of URLLoaderThrottle that wraps a list of other throttles, allowing us to support multiple throttles for a single URLLoader.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d503387f1c0f7bec7accb9f435f49a5705df8a41

commit d503387f1c0f7bec7accb9f435f49a5705df8a41
Author: Ken Rockot <rockot@chromium.org>
Date: Fri Sep 15 20:49:53 2017

Support multiple throttles on ThrottlingURLLoader

This enables ThrottlingURLLoader to support construction over multiple
sequential throttles.

Derived from work on
https://chromium-review.googlesource.com/c/chromium/src/+/612403

BUG= 754882 , 721414 

Change-Id: I16601f6bed46585b825481c732671bd7ffd5e15b
Reviewed-on: https://chromium-review.googlesource.com/668137
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502359}
[modify] https://crrev.com/d503387f1c0f7bec7accb9f435f49a5705df8a41/content/common/throttling_url_loader.cc
[modify] https://crrev.com/d503387f1c0f7bec7accb9f435f49a5705df8a41/content/common/throttling_url_loader.h
[modify] https://crrev.com/d503387f1c0f7bec7accb9f435f49a5705df8a41/content/common/throttling_url_loader_unittest.cc
[modify] https://crrev.com/d503387f1c0f7bec7accb9f435f49a5705df8a41/content/public/common/url_loader_throttle.h

Status: Fixed (was: Started)

Comment 3 by laforge@google.com, Nov 7 2017

Components: -Internals>Network>Service Internals>Services>Network
Apologies, applied the wrong component in bulk.

Sign in to add a comment