New issue
Advanced search Search tips

Issue 754871 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

"result" struct member causes compile error in Mojo Java bindings

Project Member Reported by pwnall@chromium.org, Aug 11 2017

Issue description

CL: https://crrev.com/c/602673
Build error: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.android%2Fandroid_arm64_dbg_recipe%2F326829%2F%2B%2Frecipes%2Fsteps%2Fcompile__with_patch_%2F0%2Fstdout

Error text from the bot (I get a similar error on my machine):
[1178/29327] ACTION //third_party/WebKit/public:mojo_bindings_java__compile_java__javac(//build/toolchain/android:android_clang_arm64)
FAILED: gen/third_party/WebKit/public/mojo_bindings_java__compile_java.javac.jar gen/third_party/WebKit/public/mojo_bindings_java__compile_java.javac.jar.md5.stamp 
python ../../build/android/gyp/javac.py --depfile=gen/third_party/WebKit/public/mojo_bindings_java__compile_java__javac.d --jar-path=gen/third_party/WebKit/public/mojo_bindings_java__compile_java.javac.jar --java-srcjars=\[\"gen/third_party/WebKit/public/mojo_bindings_java_sources.srcjar\"\] --java-srcjars=@FileArg\(gen/third_party/WebKit/public/mojo_bindings_java.build_config:javac:srcjars\) --java-version=1.8 --classpath=@FileArg\(gen/third_party/WebKit/public/mojo_bindings_java.build_config:javac:interface_classpath\) --bootclasspath=lib.java/android.interface.jar
Traceback (most recent call last):
  File "../../build/android/gyp/javac.py", line 511, in <module>
    sys.exit(main(sys.argv[1:]))
  File "../../build/android/gyp/javac.py", line 507, in main
    pass_changes=True)
  File "/b/c/b/android_arm64_dbg_recipe/src/build/android/gyp/util/build_utils.py", line 595, in CallAndWriteDepfileIfStale
    pass_changes=True)
  File "/b/c/b/android_arm64_dbg_recipe/src/build/android/gyp/util/md5_check.py", line 87, in CallAndRecordIfStale
    function(*args)
  File "/b/c/b/android_arm64_dbg_recipe/src/build/android/gyp/util/build_utils.py", line 578, in on_stale_md5
    function(*args)
  File "../../build/android/gyp/javac.py", line 500, in <lambda>
    classpath_inputs),
  File "../../build/android/gyp/javac.py", line 260, in _OnStaleMd5
    attempt_build()
  File "../../build/android/gyp/javac.py", line 258, in <lambda>
    stderr_filter=ColorJavacOutput)
  File "/b/c/b/android_arm64_dbg_recipe/src/build/android/gyp/util/build_utils.py", line 179, in CheckOutput
    raise CalledProcessError(cwd, args, stdout + stderr)
util.build_utils.CalledProcessError: Command failed: ( cd /b/c/b/android_arm64_dbg_recipe/src/out/Debug; /usr/bin/javac -g -encoding UTF-8 -classpath lib.java/base/base_java.interface.jar:lib.java/mojo/public/java/bindings_java.interface.jar:lib.java/mojo/public/java/system_java.interface.jar:lib.java/third_party/WebKit/public/android_mojo_bindings_java.interface.jar:lib.java/third_party/WebKit/public/web_feature_mojo_bindings_java.interface.jar:lib.java/device/bluetooth/public/interfaces/interfaces_java.interface.jar:lib.java/device/screen_orientation/public/interfaces/interfaces_java.interface.jar:lib.java/mojo/common/common_custom_types_java.interface.jar:lib.java/services/network/public/interfaces/interfaces_java.interface.jar:lib.java/storage/public/interfaces/interfaces_java.interface.jar:lib.java/ui/gfx/geometry/mojo/mojo_java.interface.jar:lib.java/url/mojo/url_mojom_gurl_java.interface.jar:lib.java/url/mojo/url_mojom_origin_java.interface.jar:lib.java/build/android/build_hooks_java.interface.jar -sourcepath : -bootclasspath lib.java/android.interface.jar:/usr/lib/jvm/java-8-openjdk-amd64/jre/lib/rt.jar -source 1.8 -target 1.8 -XDignore.symbol.file -d /tmp/tmputtEjv/classes /tmp/tmputtEjv/java/org/chromium/blink/mojom/BudgetState.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/BackgroundSyncState.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/BackgroundFetchError.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/PresentationServiceClient_Internal.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/BackgroundSyncEventLastChance.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/PermissionStatus.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/SyncRegistration.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/Referrer.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/PermissionObserver.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/HttpHeader.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/NotificationAction.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/CookieStoreSetOptions.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/PresentationConnectionState.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/DisplayMode.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/WebBluetoothLeScanFilter.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/KeyboardLockRequestResult.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/PermissionName.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/MimeRegistry.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/WebSocketHandshakeResponse.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/CookieStore_Internal.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/PresentationConnectionMessage.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/WebSocketHandshakeRequest.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/AppBannerService.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/MediaEngagementClient.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/WebBluetoothService_Internal.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/MediaEngagementClient_Internal.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/PresentationErrorType.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/WindowFeatures.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/WebBluetoothServerClient.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/IconDefinition.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/CookieStoreGetOptions.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/AppBannerService_Internal.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/BackgroundSyncService.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/Manifest.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/BackgroundSyncError.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/BackgroundFetchService_Internal.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/PermissionDescriptorExtension.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/BudgetOperationType.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/PresentationError.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/MidiPermissionDescriptor.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/ReferrerPolicy.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/WebBluetoothRemoteGattCharacteristic.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/ServiceWorkerFetchType.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/CookieInfo.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/FetchRedirectMode.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/InsecureInputService_Internal.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/BackgroundFetchRegistration.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/RequestContextFrameType.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/PresentationConnectionCloseReason.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/ServiceWorkerStreamCallback.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/WebSocketClient.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/ServiceWorkerEventStatus.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/PermissionService.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/PresentationService.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/BackgroundFetchService.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/KeyboardLockService.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/PresentationServiceClient.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/BackgroundSyncNetworkState.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/MimeRegistry_Internal.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/CookieMatchType.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/WorkerContentSettingsProxy.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/PresentationConnection_Internal.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/FetchCredentialsMode.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/EngagementLevel.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/KeyboardLockService_Internal.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/ScreenAvailability.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/AppBannerEvent.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/ServiceWorkerStreamHandle.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/PermissionObserver_Internal.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/BroadcastChannelProvider_Internal.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/ManifestManager.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/WebBluetoothGattQueryQuantity.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/WebSocket.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/AppBannerController_Internal.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/WebBluetoothCharacteristicClient_Internal.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/BroadcastChannelProvider.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/BackgroundSyncService_Internal.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/EngagementClient_Internal.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/WebSocket_Internal.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/ConsoleMessageLevel.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/WebBluetoothRemoteGattService.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/BackgroundFetchOptions.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/PresentationConnection.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/WebSocketClient_Internal.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/PresentationService_Internal.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/RequestContextType.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/AppBannerController.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/WebBluetoothDevice.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/PermissionService_Internal.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/WorkerContentSettingsProxy_Internal.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/WebBluetoothResult.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/WebBluetoothDeviceId.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/ServiceWorkerStreamCallback_Internal.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/BroadcastChannelClient.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/PermissionDescriptor.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/NotificationService.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/NotificationService_Internal.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/BudgetService.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/WebSocketMessageType.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/AppBannerPromptReply.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/WebBluetoothService.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/CookieStore.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/ManifestManager_Internal.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/Hyphenation.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/WebBluetoothRemoteGattDescriptor.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/WebBluetoothRequestDeviceOptions.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/ManifestShareTarget.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/NotificationDirection.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/BroadcastChannelClient_Internal.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/BudgetServiceErrorType.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/WebBluetoothServerClient_Internal.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/FetchRequestMode.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/FetchApiRequest.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/InsecureInputService.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/Notification.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/ManifestIcon.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/BudgetService_Internal.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/AppBannerEvent_Internal.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/Hyphenation_Internal.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/ManifestRelatedApplication.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/NotificationActionType.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/WebBluetoothCharacteristicClient.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/EngagementClient.java /tmp/tmputtEjv/java/org/chromium/blink/mojom/PresentationInfo.java /tmp/tmputtEjv/java/org/chromium/content/mojom/ReportingServiceProxy_Internal.java /tmp/tmputtEjv/java/org/chromium/content/mojom/ReportingServiceProxy.java /tmp/tmputtEjv/java/org/chromium/webauth/mojom/PublicKeyCredentialEntity.java /tmp/tmputtEjv/java/org/chromium/webauth/mojom/PublicKeyCredentialParameters.java /tmp/tmputtEjv/java/org/chromium/webauth/mojom/AuthenticatorTransport.java /tmp/tmputtEjv/java/org/chromium/webauth/mojom/MakeCredentialOptions.java /tmp/tmputtEjv/java/org/chromium/webauth/mojom/Authenticator_Internal.java /tmp/tmputtEjv/java/org/chromium/webauth/mojom/PublicKeyCredentialInfo.java /tmp/tmputtEjv/java/org/chromium/webauth/mojom/AuthenticatorStatus.java /tmp/tmputtEjv/java/org/chromium/webauth/mojom/Authenticator.java /tmp/tmputtEjv/java/org/chromium/webauth/mojom/PublicKeyCredentialDescriptor.java /tmp/tmputtEjv/java/org/chromium/webauth/mojom/PublicKeyCredentialType.java /tmp/tmputtEjv/java/org/chromium/webauth/mojom/AuthenticatorResponse.java /tmp/tmputtEjv/java/org/chromium/password_manager/mojom/CredentialManager.java /tmp/tmputtEjv/java/org/chromium/password_manager/mojom/CredentialType.java /tmp/tmputtEjv/java/org/chromium/password_manager/mojom/CredentialInfo.java /tmp/tmputtEjv/java/org/chromium/password_manager/mojom/CredentialManagerError.java /tmp/tmputtEjv/java/org/chromium/password_manager/mojom/CredentialManager_Internal.java /tmp/tmputtEjv/java/org/chromium/password_manager/mojom/CredentialMediationRequirement.java /tmp/tmputtEjv/java/org/chromium/payments/mojom/PaymentRequestEventData.java /tmp/tmputtEjv/java/org/chromium/payments/mojom/CanMakePaymentEventData.java /tmp/tmputtEjv/java/org/chromium/payments/mojom/PaymentHandlerResponse.java /tmp/tmputtEjv/java/org/chromium/payments/mojom/PaymentHandlerResponseCallback_Internal.java /tmp/tmputtEjv/java/org/chromium/payments/mojom/PaymentManager.java /tmp/tmputtEjv/java/org/chromium/payments/mojom/PaymentHandlerResponseCallback.java /tmp/tmputtEjv/java/org/chromium/payments/mojom/PaymentManager_Internal.java /tmp/tmputtEjv/java/org/chromium/payments/mojom/PaymentInstrument.java /tmp/tmputtEjv/java/org/chromium/payments/mojom/ImageObject.java /tmp/tmputtEjv/java/org/chromium/payments/mojom/PaymentHandlerStatus.java )
/tmp/tmputtEjv/java/org/chromium/blink/mojom/CookieStore_Internal.java:438: error: incompatible types: int cannot be converted to Object[]
            result = prime * result + java.util.Arrays.deepHashCode(result);
                                                                    ^
Note: Some messages have been simplified; recompile with -Xdiags:verbose to get full output
1 error

I will submit a CL to fix this issue.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/752a5e37fc70e42aa8510bcedaae2886900fbaea

commit 752a5e37fc70e42aa8510bcedaae2886900fbaea
Author: Victor Costan <pwnall@chromium.org>
Date: Mon Aug 14 19:02:56 2017

mojo Java bindings: Qualify struct field names with this.

This fixes the compilation error described in the associated bug.

Bug:  754871 
Change-Id: I5f03022fc48b8ebbcebb58940f0e6d2f61c02c4c
Reviewed-on: https://chromium-review.googlesource.com/612515
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494119}
[modify] https://crrev.com/752a5e37fc70e42aa8510bcedaae2886900fbaea/mojo/public/tools/bindings/generators/java_templates/data_types_definition.tmpl

Comment 2 by pwnall@chromium.org, Aug 14 2017

Status: Fixed (was: Started)

Sign in to add a comment