New issue
Advanced search Search tips

Issue 754869 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

QUIC requires handshake confirmation even if the local IP is the same

Project Member Reported by rch@chromium.org, Aug 11 2017

Issue description

QuicStreamFactory::ConfigureSocket() attempts to check the local IP against the last local IP which supported QUIC. If they are the same, then handshake confirmation should not be required. Alas, there is a bug which prevents this from happening.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a12722b1a04ec1cfd5215f89479323b54a6f8c35

commit a12722b1a04ec1cfd5215f89479323b54a6f8c35
Author: Ryan Hamilton <rch@chromium.org>
Date: Sat Aug 12 02:23:20 2017

Fix a bug which caused QUIC to require handshake confirmation
even when the local IP is the same as the last time QUIC was used successfully.

The problem is that the factory requires confirmation until the first call to
ConfigureSocket happens, which determines the local IP address. ConfigureSocket
is called inside of CreateSession, so it's too late to affect this. Instead,
this CL delays the evaluation of the factory's state until after ConfigureSocket
happens.

Bug:  754869 
Change-Id: I8fa3311d30833f9e0e6615dd76cc1cf85282f34a
Reviewed-on: https://chromium-review.googlesource.com/611797
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493938}
[modify] https://crrev.com/a12722b1a04ec1cfd5215f89479323b54a6f8c35/net/quic/chromium/quic_chromium_client_session.h
[modify] https://crrev.com/a12722b1a04ec1cfd5215f89479323b54a6f8c35/net/quic/chromium/quic_stream_factory.cc
[modify] https://crrev.com/a12722b1a04ec1cfd5215f89479323b54a6f8c35/net/quic/chromium/quic_stream_factory_test.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e32a2b2e8e43f349b163be1262312f470d5b382

commit 8e32a2b2e8e43f349b163be1262312f470d5b382
Author: Ryan Hamilton <rch@chromium.org>
Date: Mon Aug 28 20:06:52 2017

Clear the persisted supports QUIC IP address after it is read
in case the network no longer supports QUIC so the next restart will
require confirmation. It will be re-persisted when the first job completes
successfully.

Bug:  754869 
Change-Id: I40c632b6683fc8750449b093d699021c1a15ac61
Reviewed-on: https://chromium-review.googlesource.com/612588
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497857}
[modify] https://crrev.com/8e32a2b2e8e43f349b163be1262312f470d5b382/net/quic/chromium/quic_chromium_client_session.cc
[modify] https://crrev.com/8e32a2b2e8e43f349b163be1262312f470d5b382/net/quic/chromium/quic_stream_factory.cc
[modify] https://crrev.com/8e32a2b2e8e43f349b163be1262312f470d5b382/net/quic/chromium/quic_stream_factory_test.cc

Comment 3 by rch@chromium.org, Nov 10 2017

Status: Fixed (was: Started)

Sign in to add a comment