New issue
Advanced search Search tips

Issue 754864 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocked on:
issue 754872

Blocking:
issue 794961



Sign in to add a comment

CastStreamingApiTestWithPiAxelOutput.EndToEnd (browser_test) fails in --mash

Project Member Reported by sky@chromium.org, Aug 11 2017

Issue description

This is likely because capture is still a work in progress, although I could be wrong.
 

Comment 1 by m...@chromium.org, Aug 11 2017

Owner: m...@chromium.org
Status: Assigned (was: Untriaged)
Yep! :)

Comment 2 by m...@chromium.org, Aug 11 2017

Blockedon: 754872

Comment 3 by sky@chromium.org, Nov 6 2017

Blocking: -740655 731255
As expected, browser_test --mash too.

Blocking: -731255
Summary: CastStreamingApiTestWithPixelOutput.EndToEnd (browser_test) fails in --mash (was: CastStreamingApiTestWithPixelOutput.EndToEnd (browser_test) fails in --mus)
Test now works with --mus after viz decouple.
Blocking: 794961
This does fail with --enable-viz as expected while in development
Cc: jonr...@chromium.org
Summary: CastStreamingApiTestWithPiAxelOutput.EndToEnd (browser_test) fails in --mash (was: CastStreamingApiTestWithPixelOutput.EndToEnd (browser_test) fails in --mash)
Also TabCaptureApiPixelTest.*
On Chrome OS ChromeScreenshotGrabberBrowserTest.TakeScreenshot is failing trying to processes the invalid results of capture

  FATAL:snapshot.cc(25)] Check failed: !image.AsImageSkia().GetRepresentation(1.0f).is_null(). 
  ui::(anonymous namespace)::EncodeImageAsPNG()

Comment 10 by m...@chromium.org, Feb 14 2018

Components: Internals>Cast>Streaming
I decided to give the TabCapture related tests a go, but with --enable-features=VizDisplayCompositor

A lot of them are now working thanks to all of the work in this space!

Remaining errors I see are:
  -  issue 810389 
  - TabCaptureApiPixelTest.OffscreenTab*
         - Flaky timeouts on CrOS
  - ThumbnailTest.ShouldCaptureOnNavigatingAwaySlowPageLoad 
         - Failure:
       chrome/browser/thumbnails/thumbnail_browsertest.cc:336: Failure
Actual function call count doesn't match EXPECT_CALL(*thumbnail_service(), SetPageThumbnail(Field(&ThumbnailingContext::url, red_url), ImageColorIs(static_cast<SkColor>(0xFFFF0000))))...
         Expected: to be called once
           Actual: never called - unsatisfied and active
  - ThumbnailTest.ShouldCaptureOnNavigatingAwayExplicitWait 
        - times out attempting to acquire a thread lock

Status: Fixed (was: Assigned)
I've update  issue 810389  which is better tracking know failures of Tab Capture.

The test listed in this issue has since been fixed. I can no longer reproduce the failure.

Sign in to add a comment