Bring up content_unittests under Fuchsia |
|||||||||||||||||||||||||||||||||||||||||||||
Issue descriptionWe should shoot for having content_unittests up and running, as an intermediate milestone between 'headless_shell' building and rehabbing the content_browsertests. ⛆ |
|
|
,
Aug 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e9ff0fe3d2ccba8bc7a8b4414e87c89122f189ec commit e9ff0fe3d2ccba8bc7a8b4414e87c89122f189ec Author: Kevin Marshall <kmarshall@chromium.org> Date: Tue Aug 22 23:20:06 2017 Fuchsia: miscellaneous fixes to make content_unittests buildable. * Disable POSIX signalling from BrowserTestBase for Fuchsia (not compatible). * Switch EXPECT_DEATH tests to EXPECT_DEATH_IF_SUPPORTED for TestBrowserThreadBundleTest. * Add fuchsia to the list of supported platforms in fieldtrial_to_struct.py. * Move webrtc deps into "enable_webrtc" conditional block. Bug: 754861 , 756269 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I2cce36ca3cebfeb0acf86ad0c2cf0cd0f8645f51 Reviewed-on: https://chromium-review.googlesource.com/619727 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by: Scott Graham <scottmg@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Reviewed-by: Alexei Svitkine (very slow) <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#496498} [modify] https://crrev.com/e9ff0fe3d2ccba8bc7a8b4414e87c89122f189ec/content/public/test/browser_test_base.cc [modify] https://crrev.com/e9ff0fe3d2ccba8bc7a8b4414e87c89122f189ec/content/public/test/test_browser_thread_bundle_unittest.cc [modify] https://crrev.com/e9ff0fe3d2ccba8bc7a8b4414e87c89122f189ec/content/test/BUILD.gn [modify] https://crrev.com/e9ff0fe3d2ccba8bc7a8b4414e87c89122f189ec/tools/variations/fieldtrial_to_struct.py
,
Aug 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bd62ab798044d0c88dff947c9e51798b6f99d9b6 commit bd62ab798044d0c88dff947c9e51798b6f99d9b6 Author: Scott Graham <scottmg@chromium.org> Date: Wed Aug 23 16:17:26 2017 fuchsia: Have fuchsia use more of _ozone for gpu and ui, using StubGL Bug: 746674 , 754861 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I4f4485d11a3a4ac6f1ccf6afeb5485e7acb1b344 Reviewed-on: https://chromium-review.googlesource.com/627596 Reviewed-by: John Bauman <jbauman@chromium.org> Reviewed-by: Michael Spang <spang@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#496701} [modify] https://crrev.com/bd62ab798044d0c88dff947c9e51798b6f99d9b6/gpu/config/gpu_control_list.cc [modify] https://crrev.com/bd62ab798044d0c88dff947c9e51798b6f99d9b6/gpu/config/gpu_control_list.h [modify] https://crrev.com/bd62ab798044d0c88dff947c9e51798b6f99d9b6/gpu/ipc/in_process_command_buffer.cc [modify] https://crrev.com/bd62ab798044d0c88dff947c9e51798b6f99d9b6/ui/gl/init/BUILD.gn [delete] https://crrev.com/1a113d423eecfcdf82a5354be090bdee22efb408/ui/gl/init/gl_factory_fuchsia.cc [delete] https://crrev.com/1a113d423eecfcdf82a5354be090bdee22efb408/ui/gl/init/gl_initializer_fuchsia.cc [modify] https://crrev.com/bd62ab798044d0c88dff947c9e51798b6f99d9b6/ui/gl/test/gl_surface_test_support.cc [modify] https://crrev.com/bd62ab798044d0c88dff947c9e51798b6f99d9b6/ui/ozone/platform/headless/headless_surface_factory.cc
,
Aug 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/681f559189cb660a8c503c4cf24d653df911bcd6 commit 681f559189cb660a8c503c4cf24d653df911bcd6 Author: Scott Graham <scottmg@chromium.org> Date: Wed Aug 23 18:40:31 2017 fuchsia: Add content_unittests to fyi waterfall (with filter) 184 filtered, 4349 passing locally. Bug: 754861 Change-Id: Id9b716472df974d3aef3d6476ca7c2d07f28268b Reviewed-on: https://chromium-review.googlesource.com/627623 Reviewed-by: Wez <wez@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#496739} [modify] https://crrev.com/681f559189cb660a8c503c4cf24d653df911bcd6/testing/buildbot/chromium.fyi.json [add] https://crrev.com/681f559189cb660a8c503c4cf24d653df911bcd6/testing/buildbot/filters/fuchsia.content_unittests.filter
,
Aug 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/50d80e2dd76f3796f4ee6e553a6ed74cf011ec8e commit 50d80e2dd76f3796f4ee6e553a6ed74cf011ec8e Author: Scott Graham <scottmg@chromium.org> Date: Wed Aug 23 20:39:02 2017 fuchsia: Add headless_shell and content_unittests to Fuchsia Compile (to match fyi bot) Bug: 746674 , 754861 Change-Id: If4a314e1e8c4eddcfeee1ea2a7db442c03b6d2b3 Reviewed-on: https://chromium-review.googlesource.com/628643 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#496794} [modify] https://crrev.com/50d80e2dd76f3796f4ee6e553a6ed74cf011ec8e/testing/buildbot/chromium.linux.json
,
Aug 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4a8d0ae9c4b3c7161e99a50ddd8d932273151cc1 commit 4a8d0ae9c4b3c7161e99a50ddd8d932273151cc1 Author: Scott Graham <scottmg@chromium.org> Date: Wed Aug 23 21:27:16 2017 Revert "fuchsia: Add headless_shell and content_unittests to Fuchsia Compile (to match fyi bot)" This reverts commit 50d80e2dd76f3796f4ee6e553a6ed74cf011ec8e. Reason for revert: Mojo build files are bad and should feel bad. https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.linux%2FFuchsia_Compile%2F364%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout I don't think this has anything to do with this CL (the tryrun was green), rather it just happens to be a relatively clean build so the fetch_api_request mojom failed. Original change's description: > fuchsia: Add headless_shell and content_unittests to Fuchsia Compile (to match fyi bot) > > Bug: 746674 , 754861 > Change-Id: If4a314e1e8c4eddcfeee1ea2a7db442c03b6d2b3 > Reviewed-on: https://chromium-review.googlesource.com/628643 > Commit-Queue: Scott Graham <scottmg@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#496794} TBR=scottmg@chromium.org,jbudorick@chromium.org Change-Id: I76f93bd5fef945584c23b9c759f5a3047c9da5b1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 746674 , 754861 Reviewed-on: https://chromium-review.googlesource.com/629898 Reviewed-by: Scott Graham <scottmg@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#496806} [modify] https://crrev.com/4a8d0ae9c4b3c7161e99a50ddd8d932273151cc1/testing/buildbot/chromium.linux.json
,
Aug 24 2017
,
Aug 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9596dcd976225c1db78067e9ffefb9bb5b1363cb commit 9596dcd976225c1db78067e9ffefb9bb5b1363cb Author: Scott Graham <scottmg@chromium.org> Date: Thu Aug 24 16:35:24 2017 fuchsia: Filter a couple tests in content_unittests that flake on bot TBR=wez@chromium.org Bug: 754861 Change-Id: I47f47a45f05c6d44ba14851b2714e771fdacb929 Reviewed-on: https://chromium-review.googlesource.com/632917 Reviewed-by: Scott Graham <scottmg@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#497080} [modify] https://crrev.com/9596dcd976225c1db78067e9ffefb9bb5b1363cb/testing/buildbot/filters/fuchsia.content_unittests.filter
,
Aug 24 2017
,
Aug 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/21b917d0199706826e1e8cb48a89535b78ebcfaf commit 21b917d0199706826e1e8cb48a89535b78ebcfaf Author: Scott Graham <scottmg@chromium.org> Date: Thu Aug 24 19:42:15 2017 fuchsia: triage some content_unittests failures TBR=wez@chromium.org Bug: 758634 , 754861 Change-Id: I82f6cc27d6fae34d998580dea92646dac4f5d865 Reviewed-on: https://chromium-review.googlesource.com/633889 Reviewed-by: Scott Graham <scottmg@chromium.org> Reviewed-by: Wez <wez@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#497157} [modify] https://crrev.com/21b917d0199706826e1e8cb48a89535b78ebcfaf/testing/buildbot/filters/fuchsia.content_unittests.filter
,
Aug 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/32aad1917780629253ce34543e7a90af0f418c90 commit 32aad1917780629253ce34543e7a90af0f418c90 Author: Scott Graham <scottmg@chromium.org> Date: Fri Aug 25 02:08:09 2017 fuchsia: Enable more content_unittests fixed by GetHandleLimit() fix These were fixed by https://chromium.googlesource.com/chromium/src/+/3f81e2e317fc3873b79c46148e6d873e6c2e8963. TBR=kmarshall@chromium.org Bug: 754861 Change-Id: Iaf17d43e2cd830af139b60747cd73e17e7661de0 Reviewed-on: https://chromium-review.googlesource.com/634519 Reviewed-by: Scott Graham <scottmg@chromium.org> Reviewed-by: Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#497300} [modify] https://crrev.com/32aad1917780629253ce34543e7a90af0f418c90/testing/buildbot/filters/fuchsia.content_unittests.filter
,
Aug 25 2017
,
Aug 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c80dc347a97f2104b6ba1fda41dc6404f4d1234a commit c80dc347a97f2104b6ba1fda41dc6404f4d1234a Author: Scott Graham <scottmg@chromium.org> Date: Fri Aug 25 18:42:18 2017 Add ScopedTaskEnvironment to V8ValueConverterImplTest test fixture This check https://gist.github.com/sgraham/72a114262ad5643db77034d8dfea3816 was hit on Fuchsia sometimes, depending on what other tests were run concurrently with V8ValueConverterImplTest, I guess. Adding base::test::ScopedTaskEnvironment seems to be the expected fix. Bug: 754861 Change-Id: I562b478115a407aaa02f7356f5ec97a5f9938e68 Reviewed-on: https://chromium-review.googlesource.com/629579 Reviewed-by: Jochen Eisinger <jochen@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#497475} [modify] https://crrev.com/c80dc347a97f2104b6ba1fda41dc6404f4d1234a/content/child/v8_value_converter_impl_unittest.cc [modify] https://crrev.com/c80dc347a97f2104b6ba1fda41dc6404f4d1234a/testing/buildbot/filters/fuchsia.content_unittests.filter
,
Aug 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f7e1576b2b1869dc5fa552dbabb2f93c87d09e37 commit f7e1576b2b1869dc5fa552dbabb2f93c87d09e37 Author: Scott Graham <scottmg@chromium.org> Date: Fri Aug 25 21:00:29 2017 fuchsia: Update content_unittests filter for recent changes - PresentationConnectionProxyTest are fixed by https://chromium-review.googlesource.com/c/chromium/src/+/636192 - AsyncResourceHandlerTest were fixed by the handle limit fix - disable the AppCacheUpdateJobTest and LegacyInputRouterImplTest as they've been flaking on the bot - move QuotaPolicyCookieStoreTest down with the other sqlite ones Bug: 759108 , 754861 TBR: kmarshall@chromium.org Change-Id: I726fe721db0426518bb84a730defa9289222c92e Reviewed-on: https://chromium-review.googlesource.com/636195 Reviewed-by: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#497530} [modify] https://crrev.com/f7e1576b2b1869dc5fa552dbabb2f93c87d09e37/testing/buildbot/filters/fuchsia.content_unittests.filter
,
Aug 26 2017
,
Aug 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8bbc81e078d9508bf5c4598ba70591a39d5ca78b commit 8bbc81e078d9508bf5c4598ba70591a39d5ca78b Author: Scott Graham <scottmg@chromium.org> Date: Sat Aug 26 02:25:47 2017 Revert "Revert "fuchsia: Add headless_shell and content_unittests to Fuchsia Compile (to match fyi bot)"" This reverts commit 4a8d0ae9c4b3c7161e99a50ddd8d932273151cc1. Reason for revert: https://chromium.googlesource.com/chromium/src/+/b660a88a3c3af5e75187b60a2667f3436053153c has landed, this part of the build shouldn't flake now. Original change's description: > Revert "fuchsia: Add headless_shell and content_unittests to Fuchsia Compile (to match fyi bot)" > > This reverts commit 50d80e2dd76f3796f4ee6e553a6ed74cf011ec8e. > > Reason for revert: Mojo build files are bad and should feel bad. https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.linux%2FFuchsia_Compile%2F364%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout > > I don't think this has anything to do with this CL (the tryrun was green), rather it just happens to be a relatively clean build so the fetch_api_request mojom failed. > > Original change's description: > > fuchsia: Add headless_shell and content_unittests to Fuchsia Compile (to match fyi bot) > > > > Bug: 746674 , 754861 > > Change-Id: If4a314e1e8c4eddcfeee1ea2a7db442c03b6d2b3 > > Reviewed-on: https://chromium-review.googlesource.com/628643 > > Commit-Queue: Scott Graham <scottmg@chromium.org> > > Reviewed-by: John Budorick <jbudorick@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#496794} > > TBR=scottmg@chromium.org,jbudorick@chromium.org > > Change-Id: I76f93bd5fef945584c23b9c759f5a3047c9da5b1 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 746674 , 754861 > Reviewed-on: https://chromium-review.googlesource.com/629898 > Reviewed-by: Scott Graham <scottmg@chromium.org> > Commit-Queue: Scott Graham <scottmg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#496806} TBR=scottmg@chromium.org,jbudorick@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 746674 , 754861 Change-Id: I788ac868fffa995ce65c9b0cf641ee6dfa24301e Reviewed-on: https://chromium-review.googlesource.com/636526 Reviewed-by: Scott Graham <scottmg@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#497638} [modify] https://crrev.com/8bbc81e078d9508bf5c4598ba70591a39d5ca78b/testing/buildbot/chromium.linux.json
,
Aug 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ce4114e91772f4864307481d681110ec2606ae8f commit ce4114e91772f4864307481d681110ec2606ae8f Author: Scott Graham <scottmg@chromium.org> Date: Mon Aug 28 07:33:46 2017 Fix creation of TaskScheduler in OneShotAccessibilityTreeSearchTest The previous creation of TaskScheduler didn't work with other tests in the same batch using ScopedTaskEnvironment because it wasn't tearing down its created instance. Instead of fixing that, switch to using ScopedTaskEnvironment as this fixture doesn't have any special requirements. This showed up as flake on Fuchsia, but is cross-platform. Bug: 759245 , 754861 Change-Id: I21b3121a7f971064efa82d352071cce0ae29629b Reviewed-on: https://chromium-review.googlesource.com/636086 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#497704} [modify] https://crrev.com/ce4114e91772f4864307481d681110ec2606ae8f/content/browser/accessibility/one_shot_accessibility_tree_search_unittest.cc [modify] https://crrev.com/ce4114e91772f4864307481d681110ec2606ae8f/testing/buildbot/filters/fuchsia.content_unittests.filter
,
Aug 28 2017
,
Aug 28 2017
,
Aug 28 2017
,
Aug 28 2017
,
Aug 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d0387a261f82dde24529a24642473112e42bdb5f commit d0387a261f82dde24529a24642473112e42bdb5f Author: Scott Graham <scottmg@chromium.org> Date: Mon Aug 28 20:51:11 2017 fuchsia: Fix AudioRendererMixerManagerTest.MixerParamsLatencyRtc Should use the same path as other POSIX-y platforms. Bug: 754861 Change-Id: I7a3e6ff5e2e59d8ecf3faedda000099fdd181f5a Reviewed-on: https://chromium-review.googlesource.com/638560 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by: Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#497869} [modify] https://crrev.com/d0387a261f82dde24529a24642473112e42bdb5f/content/renderer/media/audio_renderer_mixer_manager_unittest.cc [modify] https://crrev.com/d0387a261f82dde24529a24642473112e42bdb5f/testing/buildbot/filters/fuchsia.content_unittests.filter
,
Aug 28 2017
,
Aug 29 2017
,
Aug 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/35d64a51edb2cadc182cb63db57f9fd9967a7beb commit 35d64a51edb2cadc182cb63db57f9fd9967a7beb Author: Scott Graham <scottmg@chromium.org> Date: Tue Aug 29 02:29:46 2017 fuchsia: Include test data when is_fuchsia too (I'm not sure under what circumstances the target wouldn't want its data, but I guess there's some reason this is enumerated rather than always there.) On Fuchsia, this fixes PageStateSerializationTest.* which were missing their data files. Bug: 754861 Change-Id: Ie4a6b1568c8747458b7ac7f80936ec6a5b520a21 Reviewed-on: https://chromium-review.googlesource.com/639576 Reviewed-by: Wez <wez@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#497991} [modify] https://crrev.com/35d64a51edb2cadc182cb63db57f9fd9967a7beb/content/test/BUILD.gn [modify] https://crrev.com/35d64a51edb2cadc182cb63db57f9fd9967a7beb/testing/buildbot/filters/fuchsia.content_unittests.filter
,
Aug 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5b4c29f91a5aa37debc5b72fddf8c1ec3ca755f9 commit 5b4c29f91a5aa37debc5b72fddf8c1ec3ca755f9 Author: Scott Graham <scottmg@chromium.org> Date: Tue Aug 29 02:45:32 2017 fuchsia: Add simple implementation of MergeGPUInfo This makes GpuDataManagerImplPrivateTest.* pass on Fuchsia. Not super-important that this works right now, but this implementation matches other platforms, makes the tests pass, and is less code than the NOTIMPLEMENTED anyway. Bug: 754861 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I24ce08d599f598dfed60b11ebd027fdd1b2f2886 Reviewed-on: https://chromium-review.googlesource.com/639952 Reviewed-by: John Bauman <jbauman@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#497997} [modify] https://crrev.com/5b4c29f91a5aa37debc5b72fddf8c1ec3ca755f9/gpu/config/gpu_info_collector_fuchsia.cc [modify] https://crrev.com/5b4c29f91a5aa37debc5b72fddf8c1ec3ca755f9/testing/buildbot/filters/fuchsia.content_unittests.filter
,
Aug 30 2017
,
Aug 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/80cb2724dc06ba309e0aa9216b92209b7d9893db commit 80cb2724dc06ba309e0aa9216b92209b7d9893db Author: Scott Graham <scottmg@chromium.org> Date: Thu Aug 31 02:12:48 2017 Fix deinit of BrowserThreadImpl in BrowserMainLoopTest.CreateThreadsInSingleProcess BrowserMainLoop shuts down its BrowserThreadImpls, but SHUTDOWN is a distinct state from UNINITIALIZED which is what BrowserThreadImpl expects on initialization in the next test. Use ResetGlobalsForTesting() to clear up lingering state. This showed up on Fuchsia, but was cross-platform. Bug: 759793 , 754861 Change-Id: I2ffa5226e92e583ae317b8fb9f31bfce3e8e32ef Reviewed-on: https://chromium-review.googlesource.com/639332 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#498723} [modify] https://crrev.com/80cb2724dc06ba309e0aa9216b92209b7d9893db/content/browser/browser_main_loop_unittest.cc [modify] https://crrev.com/80cb2724dc06ba309e0aa9216b92209b7d9893db/testing/buildbot/filters/fuchsia.content_unittests.filter
,
Aug 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c7d3d02c6e92331f88bd3e070fc8d7aee365aa63 commit c7d3d02c6e92331f88bd3e070fc8d7aee365aa63 Author: Scott Graham <scottmg@chromium.org> Date: Thu Aug 31 03:22:14 2017 Roll src/third_party/googletest/src/ 42bc671f4..7f8fefabe (121 commits) https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/42bc671f47b1..7f8fefabedf2 $ git log 42bc671f4..7f8fefabe --date=short --no-merges --format='%ad %ae %s' 2017-08-30 gennadiycivil Removed "Trivial" 2017-08-30 gennadiycivil removed internal link ( not allowed in OSS) 2017-08-30 scottmg Note that it is preferable for Googlers to create a CL internally first 2017-08-30 thielen fix SetUp/TearDownTestCase() in AdvancedGuide 2017-08-29 scottmg Detect Fuchsia, and set GTEST_HAS_PTHREAD on GTEST_OS_FUCHSIA 2017-08-29 thielen use plural verb as mentioned in issue #1105 2017-08-29 thielen remove Yob's comma mentioned in issue #1105 2017-08-29 thielen run combined build only 2017-08-29 thielen switch on verbose make 2017-08-29 thielen fix typo: xUnit 2017-08-14 thielen fix typo in comment and string (SetUpTestCase) 2017-08-28 alyssar Applying lint checks from upstream google3 2017-08-22 arkady.shapkin Support x64 configuration for old VS2015 projects 2016-02-23 arkady.shapkin Remove gtest VS2005 projects 2016-02-23 arkady.shapkin Support x64 configuration for old VS2010 projects 2017-08-22 roman.perepelitsa Support ref-qualified member functions in Property(). 2017-08-21 Maurice.Gilden Remove unused variable 2017-08-20 gennadiycivil Added "explicit" as per compiler suggestion 2017-08-20 gennadiycivil Proposing these changes, please review 2017-08-18 henryschreineriii Adding CMake visibility policy setting 2017-08-18 Maurice.Gilden Change tabs to spaces in test case 2017-08-18 Maurice.Gilden Switch return type to class without default constructor 2017-08-18 Maurice.Gilden Fix test if exceptions are not supported 2017-08-18 Maurice.Gilden adds test for NiceMock with unknown return value 2017-08-16 gennadiycivil Update README.md 2017-08-16 alyssar Handling invalid flag values 2017-07-27 Maurice.Gilden Add function name to exception if there's no default action 2017-08-16 matthew.woehlke Fix problem installing gtest when gmock enabled 2017-08-14 misterg Change AppVeyor Status Badge to point to new AppVeyor Project Location 2017-08-14 misterg Change AppVeyor Status Badge to point to new AppVeyor Project Location 2017-08-14 soap Add documentation for pkg-config 2017-08-14 soap Add support for pkgconfig 2017-08-10 misterg Addressing Comments 2017-08-10 misterg Addressing comments 2017-08-10 gennadiycivil Update WORKSPACE 2017-08-10 thielen say "former version" instead of "released version" 2017-08-10 edu_kueyar Minor style fixes 2017-08-10 misterg Added Copyright 2017-08-10 misterg Initial Revision, review 164634031 2017-08-10 alyssar Adding a flag option to change the default mock type 2017-08-10 thielen clarify distinction regarding Test Case 2017-08-09 matthew.woehlke Fix library install destinations 2017-08-09 misterg WIP 2017-08-09 daniel.kruegler Infinite Loop when calling a mock function that takes boost::filesystem::path as parameter #521: Add is_same type trait and prevent infinite loops for recursive containers 2017-08-09 daniel.kruegler Infinite Loop when calling a mock function that takes boost::filesystem::path as parameter #521: Add is_same type trait 2017-08-09 misterg Added googlemock tests 2017-08-09 misterg Added googlemock tests 2017-08-09 misterg WIP 2017-08-09 thielen be more specific on Test Case 2017-08-09 eduherminio Punctuation 2017-08-08 misterg WIP, win testing 2017-08-08 misterg WIP, win testing 2017-08-08 misterg WIP, windows testing 2017-08-08 misterg WIP, windows testing 2017-08-08 misterg WIP, windows testing 2017-08-08 misterg WIP 2017-08-07 misterg Samples changes upstreaming 2017-08-07 misterg Samples changes upstreaming 2017-08-05 thielen add note about different definitions of Test Case 2017-08-05 thielen fix small typo in comment 2017-01-04 shlomif Correct some typos in a comment 2017-04-11 aconverse Use wider types to prevent unsigned overflow diagnostics 2017-08-03 joel.laity Fixed cmake policy issue 2017-08-02 git Fix policy issue with old cmakes 2017-08-02 misterg WIP 2017-08-02 misterg WIP 2017-08-01 misterg WIP 2017-08-01 misterg WIP 2016-07-10 kriss Fixed typo 2017-07-30 thielen fix links to Google C++ Style Guide 2017-07-30 thielen remove doc of former versions 2017-07-30 thielen remove obsolete reference to SVN trunk and fix link to pump manual 2017-07-30 thielen remove doc of former versions 2017-07-30 thielen remove obsolete reference to SVN trunk 2017-07-26 jnino docs: fix broken link 2017-07-16 zulkarnine2076 Remove duplicate code 2017-07-15 zulkarnine2076 Fix assumption for foreground bit offset 2017-07-11 pbos Add gtest-parallel to open-source projects. 2017-07-05 vincent.palancher Fixes a typo in FAQ.md 2017-07-01 coryan More tables that did not render correctly. 2017-07-01 coryan Remove silly claim that C++ lacks lambdas. 2017-07-01 coryan Same fixes for "current" version. 2017-07-01 coryan Fix typos too s/destoyed/destroyed/ 2017-07-01 coryan Fix table formatting. 2017-06-29 zulkarnine2076 Remove unnecessary const 2017-06-29 zulkarnine2076 Add helper functions for text color calculation 2017-06-22 zulkarnine2076 Fix a problem when bg_color == fg_color 2017-06-21 chris.sharpe.99 Colouring in help text 2017-06-21 zulkarnine2076 Add background_mask instead of using magic number 2017-06-20 zulkarnine2076 Fix background color in ColoredPrintf 2017-06-19 jnino docs: fix broken link from dummies guide to cook book 2017-06-19 hjd Fix typo in gmock-actions.h 2017-06-19 hjd Fixed misspelling in assertion message. 2017-06-11 BillyDonahue Create gtest-internal.h 2017-06-08 hernandezbravojorgeluis Fixing float comparison broken link 2017-05-30 lipkab Remove unnecessary 'the'. 2017-05-06 n54 Add NetBSD support 2017-03-12 danilcha Again rewrote everything 2017-03-12 danilcha Added explicit gtest library dependency 2017-03-11 danilcha Update README.md (...) Created with: roll-dep src/third_party/googletest/src R=pwnall@chromium.org Bug: 759916 , 754861 Change-Id: I72f8b283bcd29cc67575765fb3d5cace98b6151e Reviewed-on: https://chromium-review.googlesource.com/644161 Reviewed-by: Victor Costan <pwnall@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#498745} [modify] https://crrev.com/c7d3d02c6e92331f88bd3e070fc8d7aee365aa63/DEPS
,
Aug 31 2017
,
Aug 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f7bb7ea4f91fcc4cd9c140f8b2c092db704e268c commit f7bb7ea4f91fcc4cd9c140f8b2c092db704e268c Author: Scott Graham <scottmg@chromium.org> Date: Thu Aug 31 17:32:46 2017 fuchsia: Update content_unittests filter for recent changes/flakes - AudioRendererSinkCacheTest.SmokeTest was fixed by making gtest threadsafe (rolled already) - BrowsingDataRemoverImplTest.MultipleTasks is yet-another sqlite one that needs locks (just moved in the filter) - CacheStorageManagerTest.GetAllOriginsUsageWithOldIndex was fixed in Fuchsia and by SDK roll elsewhere (mtime fix for parent dirs) - RendererAudioOutputStreamFactoryIntegrationTest.StreamIntegrationTest was (likely) also fixed by the gtest fix. (At least, it uses gmock, and I can't reproduce failure any more. - URLLoaderImplTest.CantSniffEmptyHtml has flaked a few times, disable it along with the rest of the URLLoaderImplTest - NavigationURLLoaderTest.RequestFailedCertError and NavigationURLLoaderTest.RequestFailedCertErrorFatal started failing after the SDK roll, disable. Bug: 760687, 759916 , 754861 , 761033 Change-Id: I53baaa13f7526172675f44cba1aee9371b6dfac2 TBR: wez@chromium.org Reviewed-on: https://chromium-review.googlesource.com/646527 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by: Wez <wez@chromium.org> Reviewed-by: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#498909} [modify] https://crrev.com/f7bb7ea4f91fcc4cd9c140f8b2c092db704e268c/testing/buildbot/filters/fuchsia.content_unittests.filter
,
Aug 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1cbfce07f24d93329eb9d7840ebb371c60adeaf5 commit 1cbfce07f24d93329eb9d7840ebb371c60adeaf5 Author: Scott Graham <scottmg@chromium.org> Date: Thu Aug 31 19:48:17 2017 fuchsia: passthrough of --gtest_break_on_failure, and make gtest_repeat disable timeout --gtest_repeat=-1 --gtest_break_on_failure are useful for reproing some test failures. (I considered doing a bulk passthrough of --gtest_*, but it's non-trivial because some take values and some don't, and values can be either the same entry in argv with =, or the N+1'th entry, so it can't just be a trivial filter before passing to argparse. So add yet another forwarding variable to the argparse setup for gtest_break_on_failure.) Bug: 754861 Change-Id: I0fba6e1fd3560a576a57bd7610a9981100aaf729 Reviewed-on: https://chromium-review.googlesource.com/646577 Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#498958} [modify] https://crrev.com/1cbfce07f24d93329eb9d7840ebb371c60adeaf5/build/fuchsia/test_runner.py
,
Aug 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ce186b12bc9c664ae8feae3264d65b6249ff5e43 commit ce186b12bc9c664ae8feae3264d65b6249ff5e43 Author: Scott Graham <scottmg@chromium.org> Date: Thu Aug 31 23:20:25 2017 fuchsia: Update content_unittests filter after cert fixes Fixed by https://chromium.googlesource.com/chromium/src/+/4039bfa76af61b9ca5ba2f390852b0bf8d36ffd9 TBR: sergeyu@chromium.org Bug: 761033 , 754861 Change-Id: Id42863af3e696bd21267d423204ca530c0016a23 Reviewed-on: https://chromium-review.googlesource.com/646836 Reviewed-by: Scott Graham <scottmg@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#499067} [modify] https://crrev.com/ce186b12bc9c664ae8feae3264d65b6249ff5e43/testing/buildbot/filters/fuchsia.content_unittests.filter
,
Sep 1 2017
,
Sep 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/77dcd14773244dc6b8edcaa96b229fd7ea31dee7 commit 77dcd14773244dc6b8edcaa96b229fd7ea31dee7 Author: Scott Graham <scottmg@chromium.org> Date: Fri Sep 01 20:14:05 2017 Roll Fuchsia SDK to d9ccb5f3ba70118dba419f8202ebd74613005c9c Includes https://fuchsia.googlesource.com/magenta/+/be89b326bedee758902868d7e5346862075abf6f which fixes the behaviour seen in https://bugs.chromium.org/p/chromium/issues/detail?id=761214#c3. Bug: 707030, 761214, 754861 Change-Id: I53e708a66c0a51bba9b26ffb42d094d90fe2eae6 TBR: sergeyu@chromium.org Reviewed-on: https://chromium-review.googlesource.com/648220 Reviewed-by: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#499272} [modify] https://crrev.com/77dcd14773244dc6b8edcaa96b229fd7ea31dee7/DEPS
,
Sep 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/04dacb77609289f7db577ecc5bbdd6fecba25c4f commit 04dacb77609289f7db577ecc5bbdd6fecba25c4f Author: Scott Graham <scottmg@chromium.org> Date: Tue Sep 05 18:37:32 2017 Null out MemoryCoordinator on ChildMemoryCoordinatorImpl teardown Otherwise, when run as --gtest_filter=ChildMemoryCoordinatorImplTest.SingleClient:ChildMemoryCoordinatorImplTest.MultipleClients content_unittests DCHECKs reliably. This showed up on Fuchsia, but is cross-platform (and had been reported earlier in crbug.com/701774.) Bug: 701774, 754861 Change-Id: I93da6d698a6fbe5ab8cd2f399896f21994b4dd98 Reviewed-on: https://chromium-review.googlesource.com/646707 Reviewed-by: Chris Hamilton <chrisha@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#499687} [modify] https://crrev.com/04dacb77609289f7db577ecc5bbdd6fecba25c4f/content/child/memory/child_memory_coordinator_impl.cc [modify] https://crrev.com/04dacb77609289f7db577ecc5bbdd6fecba25c4f/testing/buildbot/filters/fuchsia.content_unittests.filter
,
Sep 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4309df854fd178fa2c7da30130d4047d88e3b0e4 commit 4309df854fd178fa2c7da30130d4047d88e3b0e4 Author: Scott Graham <scottmg@chromium.org> Date: Thu Sep 07 21:26:06 2017 fuchsia: Disable DomStorageAreaParamTest in content_unittests NOTRY=true TBR: sergeyu@chromium.org Bug: 754861 , 758634 Change-Id: Ibd48b5ec82559ba2ea589886d3e666ce04f4c710 Reviewed-on: https://chromium-review.googlesource.com/656065 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#500386} [modify] https://crrev.com/4309df854fd178fa2c7da30130d4047d88e3b0e4/testing/buildbot/filters/fuchsia.content_unittests.filter
,
Sep 11 2017
,
Sep 12 2017
,
Sep 16 2017
,
Sep 18 2017
,
Sep 18 2017
,
Sep 18 2017
,
Sep 18 2017
,
Sep 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6495ddd82d6dfb862069cf0a63241557b958063e commit 6495ddd82d6dfb862069cf0a63241557b958063e Author: Scott Graham <scottmg@chromium.org> Date: Tue Sep 19 02:33:00 2017 fuchsia: Triage remaining content_unittests that are filtered Mostly just triaging and assigning bugs for specific tests. I couldn't repro these three ServiceWorkerDatabaseTest.DatabaseVersion_CorruptedSchemaVersion ServiceWorkerProviderHostTest.ActiveIsNotController WebContentsAudioInputStreamTest.MirroringOneStreamAfterTargetChange/0 so optimistically try enabling them. (URLLoaderImplTest.* are fixed by https://chromium-review.googlesource.com/c/chromium/src/+/671767 which is in review). Bug: 766356, 766360, 766362 , 754861 , 766223 Change-Id: I781b158a0b53277e7809c69a506df89911a348aa Reviewed-on: https://chromium-review.googlesource.com/671214 Commit-Queue: Scott Graham <scottmg@chromium.org> Commit-Queue: Wez <wez@chromium.org> Reviewed-by: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#502764} [modify] https://crrev.com/6495ddd82d6dfb862069cf0a63241557b958063e/testing/buildbot/filters/fuchsia.content_unittests.filter
,
Sep 20 2017
,
Sep 25 2017
,
Sep 27 2017
,
Oct 3 2017
,
Oct 3 2017
,
Oct 4 2017
,
Oct 16 2017
,
Oct 16 2017
,
Oct 19 2017
,
Oct 19 2017
,
Oct 24 2017
,
Oct 24 2017
,
Oct 30 2017
,
Nov 1 2017
,
Nov 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f6326ea2cfb6b50ec8bc9525e95ca34fb335f78e commit f6326ea2cfb6b50ec8bc9525e95ca34fb335f78e Author: Scott Graham <scottmg@chromium.org> Date: Sat Nov 04 00:01:15 2017 fuchsia: Add content_unittests to main CQ/waterfall content_unittests (with filter) has been stable on FYI for a while now, add this test binary to the main CQ. Bug: 754861 Change-Id: I3949469b246e66c4d0ed53b948043cef3a43dd37 Reviewed-on: https://chromium-review.googlesource.com/753966 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#513975} [modify] https://crrev.com/f6326ea2cfb6b50ec8bc9525e95ca34fb335f78e/testing/buildbot/chromium.linux.json
,
Nov 13 2017
,
Dec 8 2017
,
Dec 8 2017
,
Dec 18 2017
,
Sep 11
,
Sep 11
,
Sep 11
I guess "bring up" is Fixed. We obviously have a huge number of flakes logged against this binary, but they can be addressed elsewhere. |
||||||||||||||||||||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||||||||||||||||||||||
Comment 1 by scottmg@chromium.org
, Aug 22 2017Status: Started (was: Untriaged)