New issue
Advanced search Search tips

Issue 754854 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Stack sampler crashing trybots

Project Member Reported by a...@chromium.org, Aug 11 2017

Issue description

https://chromium-review.googlesource.com/c/606987 has a trybot https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/522440 .

In the browser_tests log (https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.mac%2Fmac_chromium_rel_ng%2F522440%2F%2B%2Frecipes%2Fsteps%2Fbrowser_tests__with_patch_%2F0%2Fstdout) we have:

BrowserTestBase received signal: Segmentation fault: 11. Backtrace:
0   browser_tests                       0x0000000106235f5c base::debug::StackTrace::StackTrace(unsigned long) + 28
1   browser_tests                       0x0000000106ac3af8 content::(anonymous namespace)::DumpStackTraceSignalHandler(int) + 200
2   libsystem_platform.dylib            0x00007fff8fc805aa _sigtramp + 26
3   ???                                 0x0000000000000000 0x0 + 0
4   libunwind.dylib                     0x00007fff8f180349 libunwind::CompactUnwinder_x86_64<libunwind::LocalAddressSpace>::stepWithCompactEncoding(unsigned int, unsigned long long, libunwind::LocalAddressSpace&, libunwind::Registers_x86_64&) + 55
5   libunwind.dylib                     0x00007fff8f1802e1 libunwind::UnwindCursor<libunwind::LocalAddressSpace, libunwind::Registers_x86_64>::step() + 113
6   browser_tests                       0x00000001062a8278 _ZN4base12_GLOBAL__N_120WalkStackFromContextIZNS0_21NativeStackSamplerMac27SuspendThreadAndRecordStackEPNS_18NativeStackSampler11StackBufferEPNS_21StackSamplingProfiler6SampleEE3$_1EEbP13unw_context_tmPmRKT_ + 1416
7   browser_tests                       0x00000001062a79f4 base::(anonymous namespace)::NativeStackSamplerMac::RecordStackSample(base::NativeStackSampler::StackBuffer*, base::StackSamplingProfiler::Sample*) + 1332
8   browser_tests                       0x00000001062ab2ef base::StackSamplingProfiler::SamplingThread::RecordSample(base::StackSamplingProfiler::SamplingThread::CollectionContext*) + 1087
9   browser_tests                       0x00000001062ab5fc base::StackSamplingProfiler::SamplingThread::PerformCollectionTask(int) + 236
10  browser_tests                       0x00000001062368db base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) + 251
11  browser_tests                       0x0000000106273179 base::MessageLoop::RunTask(base::PendingTask*) + 441
12  browser_tests                       0x00000001062734ce base::MessageLoop::DeferOrRunPendingTask(base::PendingTask) + 206
13  browser_tests                       0x0000000106273a82 base::MessageLoop::DoDelayedWork(base::TimeTicks*) + 370
14  browser_tests                       0x0000000106277e13 base::MessagePumpCFRunLoopBase::RunWork() + 67
15  browser_tests                       0x000000010625bc3a base::mac::CallWithEHFrame(void () block_pointer) + 10
16  browser_tests                       0x00000001062776ef base::MessagePumpCFRunLoopBase::RunWorkSource(void*) + 63
17  CoreFoundation                      0x00007fff884485b1 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17
18  CoreFoundation                      0x00007fff88439c62 __CFRunLoopDoSources0 + 242
19  CoreFoundation                      0x00007fff884393ef __CFRunLoopRun + 831
20  CoreFoundation                      0x00007fff88438e75 CFRunLoopRunSpecific + 309
21  browser_tests                       0x000000010627824f base::MessagePumpCFRunLoop::DoRun(base::MessagePump::Delegate*) + 79
22  browser_tests                       0x0000000106276f0c base::MessagePumpCFRunLoopBase::Run(base::MessagePump::Delegate*) + 92
23  browser_tests                       0x0000000106272bc2 base::MessageLoop::Run() + 146
24  browser_tests                       0x00000001062ae7f8 base::RunLoop::Run() + 168
25  browser_tests                       0x00000001062f702e base::Thread::Run(base::RunLoop*) + 206
26  browser_tests                       0x00000001062f75ec base::Thread::ThreadMain() + 908
27  browser_tests                       0x00000001062ec8af base::(anonymous namespace)::ThreadFunc(void*) + 95
28  libsystem_pthread.dylib             0x00007fff89c1b899 _pthread_body + 138
29  libsystem_pthread.dylib             0x00007fff89c1b72a _pthread_struct_init + 0
30  libsystem_pthread.dylib             0x00007fff89c1ffc9 thread_start + 13

and

BrowserTestBase received signal: Segmentation fault: 11. Backtrace:
0   browser_tests                       0x0000000108368f5c base::debug::StackTrace::StackTrace(unsigned long) + 28
1   browser_tests                       0x0000000108bf6af8 content::(anonymous namespace)::DumpStackTraceSignalHandler(int) + 200
2   libsystem_platform.dylib            0x00007fff8fc805aa _sigtramp + 26
3   ???                                 0x0000000000000000 0x0 + 0
4   libunwind.dylib                     0x00007fff8f180349 libunwind::CompactUnwinder_x86_64<libunwind::LocalAddressSpace>::stepWithCompactEncoding(unsigned int, unsigned long long, libunwind::LocalAddressSpace&, libunwind::Registers_x86_64&) + 55
5   libunwind.dylib                     0x00007fff8f1802e1 libunwind::UnwindCursor<libunwind::LocalAddressSpace, libunwind::Registers_x86_64>::step() + 113
6   browser_tests                       0x00000001083db278 _ZN4base12_GLOBAL__N_120WalkStackFromContextIZNS0_21NativeStackSamplerMac27SuspendThreadAndRecordStackEPNS_18NativeStackSampler11StackBufferEPNS_21StackSamplingProfiler6SampleEE3$_1EEbP13unw_context_tmPmRKT_ + 1416
7   browser_tests                       0x00000001083da9f4 base::(anonymous namespace)::NativeStackSamplerMac::RecordStackSample(base::NativeStackSampler::StackBuffer*, base::StackSamplingProfiler::Sample*) + 1332
8   browser_tests                       0x00000001083de2ef base::StackSamplingProfiler::SamplingThread::RecordSample(base::StackSamplingProfiler::SamplingThread::CollectionContext*) + 1087
9   browser_tests                       0x00000001083de5fc base::StackSamplingProfiler::SamplingThread::PerformCollectionTask(int) + 236
10  browser_tests                       0x00000001083698db base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) + 251
11  browser_tests                       0x00000001083a6179 base::MessageLoop::RunTask(base::PendingTask*) + 441
12  browser_tests                       0x00000001083a64ce base::MessageLoop::DeferOrRunPendingTask(base::PendingTask) + 206
13  browser_tests                       0x00000001083a6a82 base::MessageLoop::DoDelayedWork(base::TimeTicks*) + 370
14  browser_tests                       0x00000001083aae13 base::MessagePumpCFRunLoopBase::RunWork() + 67
15  browser_tests                       0x000000010838ec3a base::mac::CallWithEHFrame(void () block_pointer) + 10
16  browser_tests                       0x00000001083aa6ef base::MessagePumpCFRunLoopBase::RunWorkSource(void*) + 63
17  CoreFoundation                      0x00007fff884485b1 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17
18  CoreFoundation                      0x00007fff88439c62 __CFRunLoopDoSources0 + 242
19  CoreFoundation                      0x00007fff884393ef __CFRunLoopRun + 831
20  CoreFoundation                      0x00007fff88438e75 CFRunLoopRunSpecific + 309
21  browser_tests                       0x00000001083ab24f base::MessagePumpCFRunLoop::DoRun(base::MessagePump::Delegate*) + 79
22  browser_tests                       0x00000001083a9f0c base::MessagePumpCFRunLoopBase::Run(base::MessagePump::Delegate*) + 92
23  browser_tests                       0x00000001083a5bc2 base::MessageLoop::Run() + 146
24  browser_tests                       0x00000001083e17f8 base::RunLoop::Run() + 168
25  browser_tests                       0x000000010842a02e base::Thread::Run(base::RunLoop*) + 206
26  browser_tests                       0x000000010842a5ec base::Thread::ThreadMain() + 908
27  browser_tests                       0x000000010841f8af base::(anonymous namespace)::ThreadFunc(void*) + 95
28  libsystem_pthread.dylib             0x00007fff89c1b899 _pthread_body + 138
29  libsystem_pthread.dylib             0x00007fff89c1b72a _pthread_struct_init + 0
30  libsystem_pthread.dylib             0x00007fff89c1ffc9 thread_start + 13

Dozens and dozens of these.
 
I'll disable the profiler until Leonard has a chance to look into this.
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5dcceb90e60de35408603bdd857b43277d7c63b4

commit 5dcceb90e60de35408603bdd857b43277d7c63b4
Author: Mike Wittman <wittman@chromium.org>
Date: Mon Aug 14 23:15:41 2017

[Mac stack sampler] Disable until crash issues are addressed

Crashes seen on trybots will likely be fixed by
https://chromium-review.googlesource.com/c/602468, but this will not
land for 1+ weeks.

Bug:  754854 
Change-Id: I823e2ada1052b8827e656c2f5acedf9f66de0387
Reviewed-on: https://chromium-review.googlesource.com/612510
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Mike Wittman <wittman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494236}
[modify] https://crrev.com/5dcceb90e60de35408603bdd857b43277d7c63b4/chrome/common/stack_sampling_configuration.cc

Status: Fixed (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3fa54af85cb9090e507f15fc4f1887cf83bd27a1

commit 3fa54af85cb9090e507f15fc4f1887cf83bd27a1
Author: Leonard Grey <lgrey@chromium.org>
Date: Mon Aug 21 23:50:15 2017

Revert "[Mac stack sampler] Disable until crash issues are addressed"

This reverts commit 5dcceb90e60de35408603bdd857b43277d7c63b4.

Reason for revert: https://chromium-review.googlesource.com/c/chromium/src/+/602468 has landed, which we think will fix this

Original change's description:
> [Mac stack sampler] Disable until crash issues are addressed
> 
> Crashes seen on trybots will likely be fixed by
> https://chromium-review.googlesource.com/c/602468, but this will not
> land for 1+ weeks.
> 
> Bug:  754854 
> Change-Id: I823e2ada1052b8827e656c2f5acedf9f66de0387
> Reviewed-on: https://chromium-review.googlesource.com/612510
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Commit-Queue: Mike Wittman <wittman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#494236}

TBR=thakis@chromium.org,wittman@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  754854 
Change-Id: I48e212f68ec6bb11086e88e1dd2b1a934f02bc6d
Reviewed-on: https://chromium-review.googlesource.com/624874
Reviewed-by: Mike Wittman <wittman@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496125}
[modify] https://crrev.com/3fa54af85cb9090e507f15fc4f1887cf83bd27a1/chrome/common/stack_sampling_configuration.cc

Sign in to add a comment