Issue metadata
Sign in to add a comment
|
10% regression in loading.desktop at 493097:493198 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Aug 11 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8971524347669158064
,
Aug 11 2017
=== Auto-CCing suspected CL author shaseley@google.com === Hi shaseley@google.com, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : Scott Haseley Commit : c3f876b18c07c50b360b93fb91ec67549b58deb8 Date : Thu Aug 10 00:40:36 2017 Subject: Use swap time for all first paint times in TBM, UMA, UKM & web perf API Bisect Details Configuration: winx64_10_perf_bisect Benchmark : loading.desktop Metric : timeToFirstContentfulPaint_avg/pcv1-warm/FDA Change : 10.81% | 177.081833333 -> 196.223833323 Revision Result N chromium@493096 177.082 +- 10.7533 6 good chromium@493147 176.66 +- 4.5934 6 good chromium@493173 182.216 +- 8.7138 6 good chromium@493186 181.788 +- 7.79929 6 good chromium@493189 179.516 +- 12.7151 6 good chromium@493190 177.847 +- 9.32694 6 good chromium@493191 197.563 +- 4.87957 6 bad <-- chromium@493192 199.427 +- 16.2136 6 bad chromium@493198 196.224 +- 8.89118 6 bad To Run This Test src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=FDA loading.desktop More information on addressing performance regressions: http://g.co/ChromePerformanceRegressions Debug information about this bisect: https://chromeperf.appspot.com/buildbucket_job_status/8971524347669158064 For feedback, file a bug with component Speed>Bisection
,
Aug 11 2017
Hi, This "regression" is due to crbug.com/738235 , and this behavior is not unexpected. The CL causing the apparent regression changed where the underlying first contentful paint metric timestamp is captured. We now record the timestamp later in the rendering pipeline, which is causing the discrepancy. The reason for the change was to make the timestamps for First Paint, First Contentful Paint, and First Meaningful Paint more accurate, per web dev feedback. But, as a side effect it is causing the appearance of regressions since previous results were measured when the FCP timestamp was captured at an earlier point in the rendering pipeline. So, in this case performance only appeared to regress but did not actually regress. I added a trace event that illustrates the difference between the old and new versions of FCP, and I've uploaded the data and an an image. The rail around 3090ms is the old timestamp, and the rail around 3097ms is the new timestamp. This discrepancy from moving the timestamp is why the test is failing.
,
Aug 14 2017
,
Aug 15 2017
,
Aug 15 2017
Issue 755662 has been merged into this issue.
,
Aug 29 2017
,
Aug 29 2017
,
Sep 5 2017
Issue 754812 has been merged into this issue. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Aug 11 2017