New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 754846 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 731255
issue 740655



Sign in to add a comment

RenderWidget::DidReceiveCompositorFrameAck is not called as often as it was without --mus

Project Member Reported by sky@chromium.org, Aug 11 2017

Issue description

This is triggered by the browser_test ConstrainedWebDialogBrowserTest.ContentResizeInAutoResizingDialog . The test seems to be relying on the size of a webcontents changing, which AFAICT in non --mus is triggered by calls to RenderWidget::DidReceiveCompositorFrameAck(). Those don't happen in --mus so that the test ends up failing.

Fady/Sadrul, any suggestions?
 

Comment 1 by sky@chromium.org, Aug 11 2017

Blocking: 740655

Comment 2 by sadrul@chromium.org, Aug 18 2017

Cc: kylec...@chromium.org
+kylechar@
Owner: fsam...@chromium.org
Status: Assigned (was: Untriaged)
Per triage: please take a look. Thanks.

Comment 4 by fsamuel@google.com, Oct 11 2017

This might be fixed already. I fixed autosize with surface sync enabled a couple of weeks ago. https://chromium-review.googlesource.com/#/c/688041/
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/73f609d62096e6ba344d71226702ff69cd58da57

commit 73f609d62096e6ba344d71226702ff69cd58da57
Author: Scott Violet <sky@chromium.org>
Date: Thu Oct 12 02:04:00 2017

chromeos: enable more browser_tests for mus

These tests are passing and no longer need to be disabled.

BUG= 754846 , 753593 , 759156 , 755272 

Change-Id: I5bc6305d000d515688166575ad8ac7af6c7e8afd
Reviewed-on: https://chromium-review.googlesource.com/714118
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508221}
[modify] https://crrev.com/73f609d62096e6ba344d71226702ff69cd58da57/testing/buildbot/filters/mus.browser_tests.filter

Comment 6 by sky@chromium.org, Oct 12 2017

Status: Fixed (was: Assigned)
Fady did indeed fix this. The test is now passing on the bot.

Comment 7 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 8 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment