New issue
Advanced search Search tips

Issue 754835 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Sep 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

security_AccountsBaseline failing on bots

Project Member Reported by jdufault@chromium.org, Aug 11 2017

Issue description

Summary: Bot ran without all CLs in CQ-DEPEND set (was: Both ran without all CLs in CQ-DEPEND set)
Cc: dgarr...@chromium.org
Owner: jorgelo@chromium.org
Actually, it seems like the bot has both CLs. Passing to jorgelo@
Labels: -Pri-2 Pri-1
Summary: security_AccountsBaseline failing on bots (was: Bot ran without all CLs in CQ-DEPEND set)
Owner: jdufault@chromium.org
This CL passed both PreCQ and CQ, which runs this test as well. Why would it fail PFQ? It makes no sense.

If you download the bot's artifacts (https://pantheon.corp.google.com/storage/browser/chromeos-image-archive/lumpy-chrome-pfq/R62-9832.0.0-rc1), you see that the baseline.group file in the test on the bots is:

disk:!:6:root,adm
chronos-access:!:1001:root,ipsec,chronos,ntfs-3g,avfs,fuse-exfat,chaps,imageloaderd

But the CL diff is:
diff --git a/client/site_tests/security_AccountsBaseline/baseline.group b/client/site_tests/security_AccountsBaseline/baseline.group
index 7749b82..c1783ad 100644
--- a/client/site_tests/security_AccountsBaseline/baseline.group
+++ b/client/site_tests/security_AccountsBaseline/baseline.group
@@ -3,7 +3,7 @@
 daemon:!:2:root,bin,daemon
 sys:!:3:root,bin,adm
 adm:!:4:root,adm,daemon
-disk:!:6:root,adm
+disk:!:6:root,adm,cros-disks
 lp:!:7:lp,lpadmin,cups,chronos
 mem:!:8:
 kmem:!:9:
@@ -23,7 +23,7 @@
 nogroup:!:65533:
 nobody:!:65534:
 chronos:!:1000:
-chronos-access:!:1001:root,ipsec,chronos,ntfs-3g,avfs,fuse-exfat,chaps,imageloaderd
+chronos-access:!:1001:root,ipsec,chronos,ntfs-3g,avfs,fuse-exfat,chaps,cros-disks,imageloaderd
 sslh:!:200:
 messagebus:!:201:
 syslog:!:202:

Clearly the diff is not being applied. The CL adds the "cros-disks" user to the "disk" and "chronos-access" groups, but the bot artifacts don't reflect that.

This has happened before (see issue 716151). This is not a test problem. It can't be -- the test passed PreCQ and CQ.


Owner: dgarr...@chromium.org
I missed this bug during my last deputy shift.

Is it resolved?
Status: WontFix (was: Untriaged)

Sign in to add a comment