New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 754822 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
(currently inactive on Chromium)
Closed: Sep 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task
Proj-VR
Proj-XR
Proj-XR-VR

Blocked on:
issue 754820



Sign in to add a comment

VR: Implement target getters for other value types in vr::AnimationPlayer

Project Member Reported by tiborg@chromium.org, Aug 11 2017

Issue description

Implement the target getter functions for other value types in vr::AnimationPlayer.
 

Comment 1 by tiborg@chromium.org, Aug 11 2017

Blockedon: 754820

Comment 2 by tiborg@chromium.org, Aug 14 2017

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/affa8f07a698002608af8dfd6a532dd97a8128f1

commit affa8f07a698002608af8dfd6a532dd97a8128f1
Author: Yash Malik <ymalik@google.com>
Date: Tue Sep 19 18:55:13 2017

[vr] Add GetTarget* getters for all animation types in vr::AnimationPlayer

There's a lot of room for duplicate code removal using templates. This is
tracked in  crbug.com/754820 .

Bug:  754822 ,  765775 
Change-Id: I310ea2414735b13df52c52bd018173b92597a6e4
Reviewed-on: https://chromium-review.googlesource.com/671065
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Commit-Queue: Yash Malik <ymalik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502903}
[modify] https://crrev.com/affa8f07a698002608af8dfd6a532dd97a8128f1/chrome/browser/vr/animation_player.cc
[modify] https://crrev.com/affa8f07a698002608af8dfd6a532dd97a8128f1/chrome/browser/vr/animation_player.h
[modify] https://crrev.com/affa8f07a698002608af8dfd6a532dd97a8128f1/chrome/browser/vr/animation_player_unittest.cc
[modify] https://crrev.com/affa8f07a698002608af8dfd6a532dd97a8128f1/chrome/browser/vr/elements/ui_element.cc
[modify] https://crrev.com/affa8f07a698002608af8dfd6a532dd97a8128f1/chrome/browser/vr/elements/ui_element.h
[modify] https://crrev.com/affa8f07a698002608af8dfd6a532dd97a8128f1/chrome/browser/vr/test/animation_utils.cc
[modify] https://crrev.com/affa8f07a698002608af8dfd6a532dd97a8128f1/chrome/browser/vr/test/animation_utils.h
[modify] https://crrev.com/affa8f07a698002608af8dfd6a532dd97a8128f1/chrome/browser/vr/test/constants.h
[modify] https://crrev.com/affa8f07a698002608af8dfd6a532dd97a8128f1/chrome/browser/vr/ui_scene_manager.cc
[modify] https://crrev.com/affa8f07a698002608af8dfd6a532dd97a8128f1/chrome/browser/vr/ui_scene_manager_unittest.cc

Comment 4 by tiborg@chromium.org, Sep 19 2017

Owner: ymalik@chromium.org

Comment 5 by ymalik@chromium.org, Sep 19 2017

Status: Fixed (was: Started)

Sign in to add a comment