New issue
Advanced search Search tips

Issue 754820 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task
Proj-VR
Proj-XR
Proj-XR-VR

Blocking:
issue 754822



Sign in to add a comment

VR: Remove duplicate code in vr::AnimationPlayer

Project Member Reported by tiborg@chromium.org, Aug 11 2017

Issue description

Remove duplicate code from the transition-to functions in vr::AnimationPlayer by using templates.
 

Comment 1 by tiborg@chromium.org, Aug 11 2017

Blocking: 754822

Comment 2 by tiborg@chromium.org, Aug 14 2017

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3504eab4afb5cf691b3bfd67f5a3f8f79162f0d8

commit 3504eab4afb5cf691b3bfd67f5a3f8f79162f0d8
Author: Tibor Goldschwendt <tiborg@chromium.org>
Date: Tue Oct 03 20:21:32 2017

[vr] Remove duplicate code in vr::AnimationPlayer

Bug:  754820 
Change-Id: I94543dbe9d92b92745e804f87fc6db4b05ec0d80
Reviewed-on: https://chromium-review.googlesource.com/612050
Reviewed-by: Ian Vollick <vollick@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506154}
[modify] https://crrev.com/3504eab4afb5cf691b3bfd67f5a3f8f79162f0d8/chrome/browser/vr/animation_player.cc
[modify] https://crrev.com/3504eab4afb5cf691b3bfd67f5a3f8f79162f0d8/chrome/browser/vr/animation_player.h

Status: Fixed (was: Started)

Sign in to add a comment