The tests in external/wpt/longtask-timing were marked as NeverFixTests, which is wrong. However, most of them are failing, so they need to be fixed.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/91858a77d72fe1a020188114b4834a96324e7b6b commit 91858a77d72fe1a020188114b4834a96324e7b6b Author: Nicolas Pena <npm@chromium.org> Date: Mon Aug 14 19:55:53 2017 Move longtask-timing test failures to TestExpectations This CL moves external/wpt/longtask-timing tests to TestExpectations and adds panicker@ as OWNER of that directory. There is one passing test: longtask-in-parentiframe.html. Bug: chromium:754819 Change-Id: I24d33bf82fae0c1270f54108745190a8bbc2bb7e Reviewed-on: https://chromium-review.googlesource.com/612426 Reviewed-by: Shubhie Panicker <panicker@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Nicolás Peña <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#494146} [modify] https://crrev.com/91858a77d72fe1a020188114b4834a96324e7b6b/third_party/WebKit/LayoutTests/NeverFixTests [modify] https://crrev.com/91858a77d72fe1a020188114b4834a96324e7b6b/third_party/WebKit/LayoutTests/TestExpectations [add] https://crrev.com/91858a77d72fe1a020188114b4834a96324e7b6b/third_party/WebKit/LayoutTests/external/wpt/longtask-timing/OWNERS
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b52204f58374c26b0197100aa5cad82df161eaf5 commit b52204f58374c26b0197100aa5cad82df161eaf5 Author: Nicolas Pena <npm@chromium.org> Date: Thu Aug 17 01:02:40 2017 Fix most external/wpt/longtask-timing tests This CL fixes all external/wpt/longtask-timing tests except for those with cross-origin iframes, which may pass or timeout. It also fixes some nits like using 'const' instead of 'var' and single quotes in js. Finally, it also removes a folder containing duplicate tests: http/tests/performance-timing/longtask Bug: chromium:754819 Change-Id: Ib1931ba47522d9d3c64f519d781d080ba2b62b91 Reviewed-on: https://chromium-review.googlesource.com/614095 Reviewed-by: Shubhie Panicker <panicker@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Nicolás Peña <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#495025} [modify] https://crrev.com/b52204f58374c26b0197100aa5cad82df161eaf5/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/b52204f58374c26b0197100aa5cad82df161eaf5/third_party/WebKit/LayoutTests/external/wpt/longtask-timing/longtask-attributes.html [modify] https://crrev.com/b52204f58374c26b0197100aa5cad82df161eaf5/third_party/WebKit/LayoutTests/external/wpt/longtask-timing/longtask-in-childiframe-crossorigin.html [modify] https://crrev.com/b52204f58374c26b0197100aa5cad82df161eaf5/third_party/WebKit/LayoutTests/external/wpt/longtask-timing/longtask-in-childiframe.html [modify] https://crrev.com/b52204f58374c26b0197100aa5cad82df161eaf5/third_party/WebKit/LayoutTests/external/wpt/longtask-timing/longtask-in-externalscript.html [modify] https://crrev.com/b52204f58374c26b0197100aa5cad82df161eaf5/third_party/WebKit/LayoutTests/external/wpt/longtask-timing/longtask-in-parentiframe.html [modify] https://crrev.com/b52204f58374c26b0197100aa5cad82df161eaf5/third_party/WebKit/LayoutTests/external/wpt/longtask-timing/longtask-in-raf.html [modify] https://crrev.com/b52204f58374c26b0197100aa5cad82df161eaf5/third_party/WebKit/LayoutTests/external/wpt/longtask-timing/longtask-in-sibling-iframe-crossorigin.html [modify] https://crrev.com/b52204f58374c26b0197100aa5cad82df161eaf5/third_party/WebKit/LayoutTests/external/wpt/longtask-timing/longtask-in-sibling-iframe.html [modify] https://crrev.com/b52204f58374c26b0197100aa5cad82df161eaf5/third_party/WebKit/LayoutTests/external/wpt/longtask-timing/resources/makelongtask.js [modify] https://crrev.com/b52204f58374c26b0197100aa5cad82df161eaf5/third_party/WebKit/LayoutTests/external/wpt/longtask-timing/resources/raflongtask.js [modify] https://crrev.com/b52204f58374c26b0197100aa5cad82df161eaf5/third_party/WebKit/LayoutTests/external/wpt/longtask-timing/resources/subframe-observing-longtask.html [modify] https://crrev.com/b52204f58374c26b0197100aa5cad82df161eaf5/third_party/WebKit/LayoutTests/external/wpt/longtask-timing/resources/subframe-with-longtask.html [delete] https://crrev.com/186ae95ba108e03aa563202419a3b1c54dce1415/third_party/WebKit/LayoutTests/http/tests/performance-timing/longtask/longtask-attributes.html [delete] https://crrev.com/186ae95ba108e03aa563202419a3b1c54dce1415/third_party/WebKit/LayoutTests/http/tests/performance-timing/longtask/longtask-externalscript.html [delete] https://crrev.com/186ae95ba108e03aa563202419a3b1c54dce1415/third_party/WebKit/LayoutTests/http/tests/performance-timing/longtask/longtask-raf.html [delete] https://crrev.com/186ae95ba108e03aa563202419a3b1c54dce1415/third_party/WebKit/LayoutTests/http/tests/performance-timing/longtask/resources/slow.js [delete] https://crrev.com/186ae95ba108e03aa563202419a3b1c54dce1415/third_party/WebKit/LayoutTests/http/tests/performance-timing/longtask/resources/slowraf.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cc5b74405b8290b6f401e09f5356fb9b7e824c46 commit cc5b74405b8290b6f401e09f5356fb9b7e824c46 Author: Nicolas Pena <npm@chromium.org> Date: Mon Dec 04 18:16:41 2017 Fix longtask layout tests This CL fixes the 3 remaining tests in longtask-timing that Timeout. The iframes are added from script instead of html because this seems to make frame attribution easier. The cross-origin tests are changed to use the sandbox property of iframes instead of changing the src. Bug: 754819 Change-Id: I1dfd0e3d7c1d2f29feb0eba5e98b683faa5ab44c Reviewed-on: https://chromium-review.googlesource.com/798155 Reviewed-by: Timothy Dresser <tdresser@chromium.org> Reviewed-by: Shubhie Panicker <panicker@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#521388} [modify] https://crrev.com/cc5b74405b8290b6f401e09f5356fb9b7e824c46/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/cc5b74405b8290b6f401e09f5356fb9b7e824c46/third_party/WebKit/LayoutTests/external/wpt/longtask-timing/longtask-in-childiframe-crossorigin.html [modify] https://crrev.com/cc5b74405b8290b6f401e09f5356fb9b7e824c46/third_party/WebKit/LayoutTests/external/wpt/longtask-timing/longtask-in-parentiframe.html [modify] https://crrev.com/cc5b74405b8290b6f401e09f5356fb9b7e824c46/third_party/WebKit/LayoutTests/external/wpt/longtask-timing/longtask-in-sibling-iframe-crossorigin.html [modify] https://crrev.com/cc5b74405b8290b6f401e09f5356fb9b7e824c46/third_party/WebKit/LayoutTests/external/wpt/longtask-timing/longtask-in-sibling-iframe.html [modify] https://crrev.com/cc5b74405b8290b6f401e09f5356fb9b7e824c46/third_party/WebKit/LayoutTests/external/wpt/longtask-timing/resources/subframe-observing-longtask.html
Comment 1 by bugdroid1@chromium.org
, Aug 14 2017