New issue
Advanced search Search tips

Issue 754816 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug-Regression
Proj-XR
Proj-XR-VR

Blocking:
issue 703354



Sign in to add a comment

VR: Navigating from the New Tab Page doesn't work

Project Member Reported by mthiesse@chromium.org, Aug 11 2017

Issue description

Navigating from the New Tab Page leaves the URL bar and page blank, but when you exit VR, the page loads and the URL bar is updated. Re-entering VR on the properly-loaded page works as expected, and navigation continues to work.
 

Comment 1 by tiborg@chromium.org, Aug 11 2017

Owner: tiborg@chromium.org
Status: Started (was: Available)

Comment 2 by tiborg@chromium.org, Aug 14 2017

Labels: M-62

Comment 3 by tiborg@chromium.org, Aug 14 2017

Status: Assigned (was: Started)
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ea39dc2e5db08297e77e3638e5245bda45284cf

commit 1ea39dc2e5db08297e77e3638e5245bda45284cf
Author: Tibor Goldschwendt <tiborg@chromium.org>
Date: Thu Aug 17 17:24:31 2017

[vr] Fix navigation from New Tab Page

The navigation did not work because we were referencing the new web
contents even though we thought they were the old web contents. Thus,
we bailed out early since it seemed no new setup is necessary.

I reverted back to an earlier state where we held on to the web
contents, in case it was not a native page, instead of the tab. By doing
so, we have the correct references. However, I still want to hold on to
the web contents even if it is native page because I need to pass the
web contents to the tab model in a follow-up change.

Bug:  754816 
Change-Id: Iec410bcb2eb4d000dce795f0f017f7b70abef44c
Reviewed-on: https://chromium-review.googlesource.com/617883
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495206}
[modify] https://crrev.com/1ea39dc2e5db08297e77e3638e5245bda45284cf/chrome/browser/android/vr_shell/vr_shell.cc
[modify] https://crrev.com/1ea39dc2e5db08297e77e3638e5245bda45284cf/chrome/browser/android/vr_shell/vr_shell.h

Comment 5 by tiborg@chromium.org, Aug 17 2017

Status: Fixed (was: Assigned)
Blocking: 703354

Sign in to add a comment