New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 754807 link

Starred by 2 users
Status: Fixed
Owner:
█ ltian@chromium.org
Last visit > 30 days ago
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Support for downloading single files from URLs alone

Project Member Reported by sbirch@chromium.org, Aug 11 2017 
Currently saving based on a URL is only supported for webpages; for browser actions we don't know in advance what the type of the URL will be, and it would be useful to download other media types (e.g. an image.)
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/60912922a6716223fe47e6243a716a4cbf627e3d

commit 60912922a6716223fe47e6243a716a4cbf627e3d
Author: Lei Tian <ltian@google.com>
Date: Mon Sep 11 22:37:57 2017

Implement download for Browser Actions

This CL implements the "Download page" option in Browser Actions menu.
Since Browser Actions only has the url, it uses
OfflinePageBridge.savePageLater() which now only supports download
webpages.

BUG= 754807 

Change-Id: I9780349a195ed3d8d18fd86284d1af52c44fd971
Reviewed-on: https://chromium-review.googlesource.com/622216
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Dmitry Titov <dimich@chromium.org>
Reviewed-by: Cathy Li <chili@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Lei Tian <ltian@google.com>
Cr-Commit-Position: refs/heads/master@{#501070}
[modify] https://crrev.com/60912922a6716223fe47e6243a716a4cbf627e3d/chrome/android/java/src/org/chromium/chrome/browser/browseractions/BrowserActionsContextMenuHelper.java
[modify] https://crrev.com/60912922a6716223fe47e6243a716a4cbf627e3d/chrome/android/java/src/org/chromium/chrome/browser/browseractions/BrowserActionsContextMenuItemDelegate.java
[modify] https://crrev.com/60912922a6716223fe47e6243a716a4cbf627e3d/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java
[modify] https://crrev.com/60912922a6716223fe47e6243a716a4cbf627e3d/chrome/android/javatests/src/org/chromium/chrome/browser/browseractions/BrowserActionActivityTest.java
[modify] https://crrev.com/60912922a6716223fe47e6243a716a4cbf627e3d/components/offline_pages/core/client_namespace_constants.cc
[modify] https://crrev.com/60912922a6716223fe47e6243a716a4cbf627e3d/components/offline_pages/core/client_namespace_constants.h
[modify] https://crrev.com/60912922a6716223fe47e6243a716a4cbf627e3d/components/offline_pages/core/client_policy_controller.cc
[modify] https://crrev.com/60912922a6716223fe47e6243a716a4cbf627e3d/tools/metrics/histograms/histograms.xml

Comment 2 by ltian@chromium.org, Mar 8 2018

Status: Fixed (was: Available)
►

Sign in to add a comment