New issue
Advanced search Search tips

Issue 754782 link

Starred by 3 users
Status: Available
Owner: ----
Cc:
scottmg@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 3
Type: Bug

Blocking:
issue 707031



Sign in to add a comment

Should we have use_aura=1 on for Fuchsia?

Project Member Reported by scottmg@chromium.org, Aug 11 2017 
Linking in all of Aura is likely pretty expensive in binary size. If our first target is headless, it "logically" shouldn't be necessary. We should confirm if it makes sense, and/or if most or all of the Aura code is stripped by the linker.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/549c712977c9bd8c81ac978548be8fa0f84fa7e9

commit 549c712977c9bd8c81ac978548be8fa0f84fa7e9
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Wed Oct 25 07:02:36 2017

Add views::MenuConfig::Init() implementation for Fuchsia

Component build of cast_shell was failing without this

Bug:  772488 , 754782
Change-Id: I6d819a3af53d445ee03598a85db830a7fa49f8ac
Reviewed-on: https://chromium-review.googlesource.com/734703
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511399}
[modify] https://crrev.com/549c712977c9bd8c81ac978548be8fa0f84fa7e9/ui/views/BUILD.gn
[add] https://crrev.com/549c712977c9bd8c81ac978548be8fa0f84fa7e9/ui/views/controls/menu/menu_config_fuchsia.cc

Comment 2 by scottmg@chromium.org, Sep 11

Cc: scottmg@chromium.org
Owner: ----
Status: Available (was: Assigned)
►

Sign in to add a comment