New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 754779 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug


Show other hotlists

Hotlists containing this issue:
Payment-Interop


Sign in to add a comment

PaymentMethodData.supportedMethods should not be a sequence

Project Member Reported by rbyers@chromium.org, Aug 11 2017

Issue description

I noticed a number of the WPT IDL tests are failing:

https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/external/wpt/payment-request/interfaces.https-expected.txt

FAIL PaymentRequest must be primary interface of new PaymentRequest([{supportedMethods: 'foo'}], {total: {label: 'bar', amount: {currency: 'BAZ', value: '0'}}}) assert_equals: Unexpected exception when evaluating object expected null but got object "TypeError: Failed to construct 'PaymentRequest': The provided value cannot be converted to a sequence."
FAIL Stringification of new PaymentRequest([{supportedMethods: 'foo'}], {total: {label: 'bar', amount: {currency: 'BAZ', value: '0'}}}) assert_equals: Unexpected exception when evaluating object expected null but got object "TypeError: Failed to construct 'PaymentRequest': The provided value cannot be converted to a sequence."
FAIL PaymentRequest interface: new PaymentRequest([{supportedMethods: 'foo'}], {total: {label: 'bar', amount: {currency: 'BAZ', value: '0'}}}) must inherit property "show" with the proper type (0) assert_equals: Unexpected exception when evaluating object expected null but got object "TypeError: Failed to construct 'PaymentRequest': The provided value cannot be converted to a sequence."
FAIL PaymentRequest interface: new PaymentRequest([{supportedMethods: 'foo'}], {total: {label: 'bar', amount: {currency: 'BAZ', value: '0'}}}) must inherit property "abort" with the proper type (1) assert_equals: Unexpected exception when evaluating object expected null but got object "TypeError: Failed to construct 'PaymentRequest': The provided value cannot be converted to a sequence."
FAIL PaymentRequest interface: new PaymentRequest([{supportedMethods: 'foo'}], {total: {label: 'bar', amount: {currency: 'BAZ', value: '0'}}}) must inherit property "canMakePayment" with the proper type (2) assert_equals: Unexpected exception when evaluating object expected null but got object "TypeError: Failed to construct 'PaymentRequest': The provided value cannot be converted to a sequence."
FAIL PaymentRequest interface: new PaymentRequest([{supportedMethods: 'foo'}], {total: {label: 'bar', amount: {currency: 'BAZ', value: '0'}}}) must inherit property "id" with the proper type (3) assert_equals: Unexpected exception when evaluating object expected null but got object "TypeError: Failed to construct 'PaymentRequest': The provided value cannot be converted to a sequence."
FAIL PaymentRequest interface: new PaymentRequest([{supportedMethods: 'foo'}], {total: {label: 'bar', amount: {currency: 'BAZ', value: '0'}}}) must inherit property "shippingAddress" with the proper type (4) assert_equals: Unexpected exception when evaluating object expected null but got object "TypeError: Failed to construct 'PaymentRequest': The provided value cannot be converted to a sequence."
FAIL PaymentRequest interface: new PaymentRequest([{supportedMethods: 'foo'}], {total: {label: 'bar', amount: {currency: 'BAZ', value: '0'}}}) must inherit property "shippingOption" with the proper type (5) assert_equals: Unexpected exception when evaluating object expected null but got object "TypeError: Failed to construct 'PaymentRequest': The provided value cannot be converted to a sequence."
FAIL PaymentRequest interface: new PaymentRequest([{supportedMethods: 'foo'}], {total: {label: 'bar', amount: {currency: 'BAZ', value: '0'}}}) must inherit property "shippingType" with the proper type (6) assert_equals: Unexpected exception when evaluating object expected null but got object "TypeError: Failed to construct 'PaymentRequest': The provided value cannot be converted to a sequence."
FAIL PaymentRequest interface: new PaymentRequest([{supportedMethods: 'foo'}], {total: {label: 'bar', amount: {currency: 'BAZ', value: '0'}}}) must inherit property "onshippingaddresschange" with the proper type (7) assert_equals: Unexpected exception when evaluating object expected null but got object "TypeError: Failed to construct 'PaymentRequest': The provided value cannot be converted to a sequence."
FAIL PaymentRequest interface: new PaymentRequest([{supportedMethods: 'foo'}], {total: {label: 'bar', amount: {currency: 'BAZ', value: '0'}}}) must inherit property "onshippingoptionchange" with the proper type (8) assert_equals: Unexpected exception when evaluating object expected null but got object "TypeError: Failed to construct 'PaymentRequest': The provided value cannot be converted to a sequence."

I think this is because of this IDL difference: 
Spec https://w3c.github.io/payment-request/#dom-paymentmethoddata:
dictionary PaymentMethodData {
    required DOMString supportedMethods;
    ...
};

Blink dictionary PaymentMethodData {
    required sequence<DOMString> supportedMethods;
    ...
};

Looks like the spec was changed a couple months ago here: https://github.com/w3c/payment-request/pull/551


 
Cc: -rouslan@chromium.org
Owner: rouslan@chromium.org
Status: Assigned (was: Untriaged)
Owner: rob.b...@samsung.com
Rob has volunteered to update our implementation to match the changed spec.
Hi Rob,

I found this issue during writing an intent to deprecate[1].
If you are not working on this, can I take a this issue?
(I already have WIP CL[2].)

[1] https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/FvyYfe-um5o
[2] https://chromium-review.googlesource.com/c/601649
Cc: rob.buis@chromium.org
Owner: jinho.b...@samsung.com
I mistook who's who -- my bad.

Comment 5 by rbyers@chromium.org, Aug 25 2017

[Typo in bug number in CL description]

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ce18bf7c445c25aec490bda84ded2733933844f

commit 4ce18bf7c445c25aec490bda84ded2733933844f
Author: Jinho Bang <jinho.bang@samsung.com>
Date: Thu Aug 24 18:33:06 2017

PaymentRequest: supportedMethods should be DOMString.

The PaymentMethodData.supportedMethods member was changed to DOMString[1][2].
It might break a existing web, so, this patch defines it as union type of
DOMString and sequence<DOMString> temporarily for now and add a use counter.
If the use counter data is very low, we will able to remove a legacy type.

Intent to deprecate:
  https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/FvyYfe-um5o

[1] https://github.com/w3c/payment-request/pull/551
[2] https://w3c.github.io/payment-request/#paymentmethoddata-dictionary

Bug: 754799
Change-Id: I97d015ce048075a66fc02a79b3f85944b8c2555e
Reviewed-on: https://chromium-review.googlesource.com/601649
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Rick Byers <rbyers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497131}
[delete] https://crrev.com/b2fbea12e27ac2fca470df1c2d95c49f7e54cfeb/third_party/WebKit/LayoutTests/external/wpt/payment-request/allowpaymentrequest/active-document-cross-origin.https.sub-expected.txt
[delete] https://crrev.com/b2fbea12e27ac2fca470df1c2d95c49f7e54cfeb/third_party/WebKit/LayoutTests/external/wpt/payment-request/allowpaymentrequest/active-document-same-origin.https-expected.txt
[delete] https://crrev.com/b2fbea12e27ac2fca470df1c2d95c49f7e54cfeb/third_party/WebKit/LayoutTests/external/wpt/payment-request/allowpaymentrequest/allowpaymentrequest-attribute-cross-origin-bc-containers.https-expected.txt
[delete] https://crrev.com/b2fbea12e27ac2fca470df1c2d95c49f7e54cfeb/third_party/WebKit/LayoutTests/external/wpt/payment-request/allowpaymentrequest/allowpaymentrequest-attribute-same-origin-bc-containers.https-expected.txt
[delete] https://crrev.com/b2fbea12e27ac2fca470df1c2d95c49f7e54cfeb/third_party/WebKit/LayoutTests/external/wpt/payment-request/allowpaymentrequest/basic.https-expected.txt
[delete] https://crrev.com/b2fbea12e27ac2fca470df1c2d95c49f7e54cfeb/third_party/WebKit/LayoutTests/external/wpt/payment-request/allowpaymentrequest/no-attribute-cross-origin-bc-containers.https-expected.txt
[delete] https://crrev.com/b2fbea12e27ac2fca470df1c2d95c49f7e54cfeb/third_party/WebKit/LayoutTests/external/wpt/payment-request/allowpaymentrequest/no-attribute-same-origin-bc-containers.https-expected.txt
[modify] https://crrev.com/4ce18bf7c445c25aec490bda84ded2733933844f/third_party/WebKit/LayoutTests/external/wpt/payment-request/allowpaymentrequest/removing-allowpaymentrequest.https.sub-expected.txt
[delete] https://crrev.com/b2fbea12e27ac2fca470df1c2d95c49f7e54cfeb/third_party/WebKit/LayoutTests/external/wpt/payment-request/allowpaymentrequest/setting-allowpaymentrequest-timing.https.sub-expected.txt
[modify] https://crrev.com/4ce18bf7c445c25aec490bda84ded2733933844f/third_party/WebKit/LayoutTests/external/wpt/payment-request/allowpaymentrequest/setting-allowpaymentrequest.https.sub-expected.txt
[modify] https://crrev.com/4ce18bf7c445c25aec490bda84ded2733933844f/third_party/WebKit/LayoutTests/external/wpt/payment-request/interfaces.https-expected.txt
[delete] https://crrev.com/b2fbea12e27ac2fca470df1c2d95c49f7e54cfeb/third_party/WebKit/LayoutTests/external/wpt/payment-request/payment-default-feature-policy.https.sub-expected.txt
[modify] https://crrev.com/4ce18bf7c445c25aec490bda84ded2733933844f/third_party/WebKit/LayoutTests/external/wpt/payment-request/payment-request-abort-method.https-expected.txt
[modify] https://crrev.com/4ce18bf7c445c25aec490bda84ded2733933844f/third_party/WebKit/LayoutTests/external/wpt/payment-request/payment-request-canmakepayment-method.https-expected.txt
[delete] https://crrev.com/b2fbea12e27ac2fca470df1c2d95c49f7e54cfeb/third_party/WebKit/LayoutTests/external/wpt/payment-request/payment-request-constructor-crash.https-expected.txt
[modify] https://crrev.com/4ce18bf7c445c25aec490bda84ded2733933844f/third_party/WebKit/LayoutTests/external/wpt/payment-request/payment-request-constructor.https-expected.txt
[modify] https://crrev.com/4ce18bf7c445c25aec490bda84ded2733933844f/third_party/WebKit/LayoutTests/external/wpt/payment-request/payment-request-ctor-currency-code-checks.https-expected.txt
[modify] https://crrev.com/4ce18bf7c445c25aec490bda84ded2733933844f/third_party/WebKit/LayoutTests/external/wpt/payment-request/payment-request-ctor-pmi-handling.https-expected.txt
[delete] https://crrev.com/b2fbea12e27ac2fca470df1c2d95c49f7e54cfeb/third_party/WebKit/LayoutTests/external/wpt/payment-request/payment-request-id-attribute.https-expected.txt
[delete] https://crrev.com/b2fbea12e27ac2fca470df1c2d95c49f7e54cfeb/third_party/WebKit/LayoutTests/external/wpt/payment-request/payment-request-onshippingaddresschange-attribute.https-expected.txt
[delete] https://crrev.com/b2fbea12e27ac2fca470df1c2d95c49f7e54cfeb/third_party/WebKit/LayoutTests/external/wpt/payment-request/payment-request-onshippingoptionchange-attribute.https-expected.txt
[delete] https://crrev.com/b2fbea12e27ac2fca470df1c2d95c49f7e54cfeb/third_party/WebKit/LayoutTests/external/wpt/payment-request/payment-request-shippingType-attribute.https-expected.txt
[delete] https://crrev.com/b2fbea12e27ac2fca470df1c2d95c49f7e54cfeb/third_party/WebKit/LayoutTests/external/wpt/payment-request/payment-request-show-method.https-expected.txt
[delete] https://crrev.com/b2fbea12e27ac2fca470df1c2d95c49f7e54cfeb/third_party/WebKit/LayoutTests/external/wpt/payment-request/payment-request-update-event-constructor.https-expected.txt
[delete] https://crrev.com/b2fbea12e27ac2fca470df1c2d95c49f7e54cfeb/third_party/WebKit/LayoutTests/external/wpt/payment-request/payment-request-update-event-updatewith-method.https-expected.txt
[modify] https://crrev.com/4ce18bf7c445c25aec490bda84ded2733933844f/third_party/WebKit/LayoutTests/payments/payment-request-interface.html
[modify] https://crrev.com/4ce18bf7c445c25aec490bda84ded2733933844f/third_party/WebKit/Source/core/frame/Deprecation.cpp
[modify] https://crrev.com/4ce18bf7c445c25aec490bda84ded2733933844f/third_party/WebKit/Source/modules/payments/PaymentDetailsModifier.idl
[modify] https://crrev.com/4ce18bf7c445c25aec490bda84ded2733933844f/third_party/WebKit/Source/modules/payments/PaymentEventDataConversion.cpp
[modify] https://crrev.com/4ce18bf7c445c25aec490bda84ded2733933844f/third_party/WebKit/Source/modules/payments/PaymentEventDataConversionTest.cpp
[modify] https://crrev.com/4ce18bf7c445c25aec490bda84ded2733933844f/third_party/WebKit/Source/modules/payments/PaymentMethodData.idl
[modify] https://crrev.com/4ce18bf7c445c25aec490bda84ded2733933844f/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp
[modify] https://crrev.com/4ce18bf7c445c25aec490bda84ded2733933844f/third_party/WebKit/Source/modules/payments/PaymentTestHelper.cpp
[modify] https://crrev.com/4ce18bf7c445c25aec490bda84ded2733933844f/third_party/WebKit/public/platform/web_feature.mojom
[modify] https://crrev.com/4ce18bf7c445c25aec490bda84ded2733933844f/tools/metrics/histograms/enums.xml

Comment 7 by ma...@chromium.org, Oct 30 2017

Is this still an issue?
This issue needs to stay open until Chrome removes support for supportedMethods as a sequence.
As far as I know, we decided to postpone removing this until early next year.
Project Member

Comment 10 by bugdroid1@chromium.org, Jun 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a3b550348f0c0a76c439a97d7b08de97f6b047be

commit a3b550348f0c0a76c439a97d7b08de97f6b047be
Author: Jinho Bang <jinho.bang@samsung.com>
Date: Wed Jun 20 23:00:17 2018

PaymentRequest: Remove the sequence version of supportedMethods (renderer)

This is one of several patches that will remove the sequence version of
supportedMethods member. This patch stops using it by removing the
related code in renderer side.
  - [1/2] This patch
  - [2/2] https://crrev.com/c/1108057

The value of |supportedMethods| was changed from array to string, but
the name was left as a plural to maintain compatibility with existing
content on the Web. But it might reduce readability in implementation
perspective. So, using [ImplmenetedAs] extended attribute, this patch
just change a plural to |supportedMethod| internally.

Intent to remove:
  https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/JAnUvBqXElU

Bug:  754779 
Change-Id: I90e50a218b3e8d9e0d92e4b6293835a9b038231c
Reviewed-on: https://chromium-review.googlesource.com/1078687
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#569067}
[modify] https://crrev.com/a3b550348f0c0a76c439a97d7b08de97f6b047be/chrome/browser/ui/views/payments/payment_request_browsertest.cc
[modify] https://crrev.com/a3b550348f0c0a76c439a97d7b08de97f6b047be/content/browser/payments/payment_app_browsertest.cc
[modify] https://crrev.com/a3b550348f0c0a76c439a97d7b08de97f6b047be/content/renderer/service_worker/service_worker_type_converters.cc
[modify] https://crrev.com/a3b550348f0c0a76c439a97d7b08de97f6b047be/content/test/data/payments/payment_app.js
[delete] https://crrev.com/d4e2c599c066e4cd31589f713733bd9b55575a93/third_party/WebKit/LayoutTests/external/wpt/payment-request/historical.https-expected.txt
[delete] https://crrev.com/d4e2c599c066e4cd31589f713733bd9b55575a93/third_party/WebKit/LayoutTests/external/wpt/payment-request/payment-request-ctor-pmi-handling.https-expected.txt
[modify] https://crrev.com/a3b550348f0c0a76c439a97d7b08de97f6b047be/third_party/WebKit/LayoutTests/http/tests/payments/resources/payment-request-event.js
[modify] https://crrev.com/a3b550348f0c0a76c439a97d7b08de97f6b047be/third_party/WebKit/LayoutTests/payments/payment-request-interface.html
[modify] https://crrev.com/a3b550348f0c0a76c439a97d7b08de97f6b047be/third_party/blink/public/platform/modules/payments/web_payment_details_modifier.h
[modify] https://crrev.com/a3b550348f0c0a76c439a97d7b08de97f6b047be/third_party/blink/public/platform/modules/payments/web_payment_method_data.h
[modify] https://crrev.com/a3b550348f0c0a76c439a97d7b08de97f6b047be/third_party/blink/public/platform/web_feature.mojom
[modify] https://crrev.com/a3b550348f0c0a76c439a97d7b08de97f6b047be/third_party/blink/renderer/core/frame/deprecation.cc
[modify] https://crrev.com/a3b550348f0c0a76c439a97d7b08de97f6b047be/third_party/blink/renderer/modules/payments/basic_card_helper.cc
[modify] https://crrev.com/a3b550348f0c0a76c439a97d7b08de97f6b047be/third_party/blink/renderer/modules/payments/basic_card_helper.h
[modify] https://crrev.com/a3b550348f0c0a76c439a97d7b08de97f6b047be/third_party/blink/renderer/modules/payments/payment_details_modifier.idl
[modify] https://crrev.com/a3b550348f0c0a76c439a97d7b08de97f6b047be/third_party/blink/renderer/modules/payments/payment_event_data_conversion.cc
[modify] https://crrev.com/a3b550348f0c0a76c439a97d7b08de97f6b047be/third_party/blink/renderer/modules/payments/payment_event_data_conversion_test.cc
[modify] https://crrev.com/a3b550348f0c0a76c439a97d7b08de97f6b047be/third_party/blink/renderer/modules/payments/payment_method_data.idl
[modify] https://crrev.com/a3b550348f0c0a76c439a97d7b08de97f6b047be/third_party/blink/renderer/modules/payments/payment_request.cc
[modify] https://crrev.com/a3b550348f0c0a76c439a97d7b08de97f6b047be/third_party/blink/renderer/modules/payments/payment_test_helper.cc

Project Member

Comment 11 by bugdroid1@chromium.org, Jul 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d252ebf5b17eb7f8ccc6b73f756a9cdb1d136d44

commit d252ebf5b17eb7f8ccc6b73f756a9cdb1d136d44
Author: Jinho Bang <jinho.bang@samsung.com>
Date: Wed Jul 18 00:00:59 2018

PaymentRequest: Remove the sequence version of supportedMethods (browser)

This is one of several patches that will remove the sequence version of
supportedMethods member. This patch stops using it by removing the
related code in browser side.
  - [1/2] https://crrev.com/c/1078687
  - [2/2] This patch

Intent to remove:
  https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/JAnUvBqXElU

Bug:  754779 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ia276a90240dc817e60ce8cf793454eb822e67a4e
Reviewed-on: https://chromium-review.googlesource.com/1108057
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#575862}
[modify] https://crrev.com/d252ebf5b17eb7f8ccc6b73f756a9cdb1d136d44/chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentApp.java
[modify] https://crrev.com/d252ebf5b17eb7f8ccc6b73f756a9cdb1d136d44/chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java
[modify] https://crrev.com/d252ebf5b17eb7f8ccc6b73f756a9cdb1d136d44/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/d252ebf5b17eb7f8ccc6b73f756a9cdb1d136d44/chrome/android/java/src/org/chromium/chrome/browser/payments/ServiceWorkerPaymentAppBridge.java
[modify] https://crrev.com/d252ebf5b17eb7f8ccc6b73f756a9cdb1d136d44/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestDataUrlTest.java
[modify] https://crrev.com/d252ebf5b17eb7f8ccc6b73f756a9cdb1d136d44/chrome/browser/android/payments/service_worker_payment_app_bridge.cc
[modify] https://crrev.com/d252ebf5b17eb7f8ccc6b73f756a9cdb1d136d44/chrome/browser/payments/service_worker_payment_app_factory_browsertest.cc
[modify] https://crrev.com/d252ebf5b17eb7f8ccc6b73f756a9cdb1d136d44/components/payments/content/installable_payment_app_crawler.cc
[modify] https://crrev.com/d252ebf5b17eb7f8ccc6b73f756a9cdb1d136d44/components/payments/content/payment_request_converter.cc
[modify] https://crrev.com/d252ebf5b17eb7f8ccc6b73f756a9cdb1d136d44/components/payments/content/payment_request_spec.cc
[modify] https://crrev.com/d252ebf5b17eb7f8ccc6b73f756a9cdb1d136d44/components/payments/content/payment_request_spec_unittest.cc
[modify] https://crrev.com/d252ebf5b17eb7f8ccc6b73f756a9cdb1d136d44/components/payments/content/payment_request_state_unittest.cc
[modify] https://crrev.com/d252ebf5b17eb7f8ccc6b73f756a9cdb1d136d44/components/payments/content/payment_response_helper_unittest.cc
[modify] https://crrev.com/d252ebf5b17eb7f8ccc6b73f756a9cdb1d136d44/components/payments/content/service_worker_payment_app_factory.cc
[modify] https://crrev.com/d252ebf5b17eb7f8ccc6b73f756a9cdb1d136d44/components/payments/content/service_worker_payment_app_factory_unittest.cc
[modify] https://crrev.com/d252ebf5b17eb7f8ccc6b73f756a9cdb1d136d44/components/payments/content/service_worker_payment_instrument.cc
[modify] https://crrev.com/d252ebf5b17eb7f8ccc6b73f756a9cdb1d136d44/components/payments/content/service_worker_payment_instrument.h
[modify] https://crrev.com/d252ebf5b17eb7f8ccc6b73f756a9cdb1d136d44/components/payments/content/service_worker_payment_instrument_unittest.cc
[modify] https://crrev.com/d252ebf5b17eb7f8ccc6b73f756a9cdb1d136d44/components/payments/core/autofill_payment_instrument.cc
[modify] https://crrev.com/d252ebf5b17eb7f8ccc6b73f756a9cdb1d136d44/components/payments/core/autofill_payment_instrument.h
[modify] https://crrev.com/d252ebf5b17eb7f8ccc6b73f756a9cdb1d136d44/components/payments/core/payment_details_modifier.cc
[modify] https://crrev.com/d252ebf5b17eb7f8ccc6b73f756a9cdb1d136d44/components/payments/core/payment_details_modifier_unittest.cc
[modify] https://crrev.com/d252ebf5b17eb7f8ccc6b73f756a9cdb1d136d44/components/payments/core/payment_details_validation.cc
[modify] https://crrev.com/d252ebf5b17eb7f8ccc6b73f756a9cdb1d136d44/components/payments/core/payment_details_validation_unittest.cc
[modify] https://crrev.com/d252ebf5b17eb7f8ccc6b73f756a9cdb1d136d44/components/payments/core/payment_instrument.h
[modify] https://crrev.com/d252ebf5b17eb7f8ccc6b73f756a9cdb1d136d44/components/payments/core/payment_method_data.cc
[modify] https://crrev.com/d252ebf5b17eb7f8ccc6b73f756a9cdb1d136d44/components/payments/core/payment_method_data.h
[modify] https://crrev.com/d252ebf5b17eb7f8ccc6b73f756a9cdb1d136d44/components/payments/core/payment_method_data_unittest.cc
[modify] https://crrev.com/d252ebf5b17eb7f8ccc6b73f756a9cdb1d136d44/components/payments/core/payment_request_data_util.cc
[modify] https://crrev.com/d252ebf5b17eb7f8ccc6b73f756a9cdb1d136d44/components/payments/core/web_payment_request_unittest.cc
[modify] https://crrev.com/d252ebf5b17eb7f8ccc6b73f756a9cdb1d136d44/content/browser/payments/payment_app_browsertest.cc
[modify] https://crrev.com/d252ebf5b17eb7f8ccc6b73f756a9cdb1d136d44/content/browser/payments/payment_app_provider_impl_unittest.cc
[modify] https://crrev.com/d252ebf5b17eb7f8ccc6b73f756a9cdb1d136d44/content/browser/service_worker/embedded_worker_test_helper.cc
[modify] https://crrev.com/d252ebf5b17eb7f8ccc6b73f756a9cdb1d136d44/content/renderer/service_worker/service_worker_type_converters.cc
[modify] https://crrev.com/d252ebf5b17eb7f8ccc6b73f756a9cdb1d136d44/ios/chrome/browser/payments/ios_payment_instrument.h
[modify] https://crrev.com/d252ebf5b17eb7f8ccc6b73f756a9cdb1d136d44/ios/chrome/browser/payments/ios_payment_instrument.mm
[modify] https://crrev.com/d252ebf5b17eb7f8ccc6b73f756a9cdb1d136d44/ios/chrome/browser/payments/ios_payment_instrument_launcher_unittest.mm
[modify] https://crrev.com/d252ebf5b17eb7f8ccc6b73f756a9cdb1d136d44/ios/chrome/browser/payments/payment_request.mm
[modify] https://crrev.com/d252ebf5b17eb7f8ccc6b73f756a9cdb1d136d44/ios/chrome/browser/payments/payment_request_test_util.mm
[modify] https://crrev.com/d252ebf5b17eb7f8ccc6b73f756a9cdb1d136d44/ios/chrome/browser/payments/payment_request_unittest.mm
[modify] https://crrev.com/d252ebf5b17eb7f8ccc6b73f756a9cdb1d136d44/ios/chrome/browser/ui/payments/payment_request_data_url_egtest.mm
[modify] https://crrev.com/d252ebf5b17eb7f8ccc6b73f756a9cdb1d136d44/ios/chrome/browser/ui/payments/payment_request_payment_method_identifier_egtest.mm
[modify] https://crrev.com/d252ebf5b17eb7f8ccc6b73f756a9cdb1d136d44/ios/chrome/browser/web/resources/payment_request.js
[modify] https://crrev.com/d252ebf5b17eb7f8ccc6b73f756a9cdb1d136d44/third_party/blink/public/platform/modules/payments/payment_request.mojom
[modify] https://crrev.com/d252ebf5b17eb7f8ccc6b73f756a9cdb1d136d44/third_party/blink/renderer/modules/payments/payment_request.cc

Status: Fixed (was: Assigned)

Sign in to add a comment